From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11129A0548 for ; Fri, 10 Sep 2021 15:10:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3DED410EB; Fri, 10 Sep 2021 15:10:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 91995406B4 for ; Fri, 10 Sep 2021 15:10:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631279432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jkqKBrM9ms8yBQGvhVam1J1xftkiSyt+SIx1wXOcz3s=; b=iae026WtDanWWKCc+nuXoQa5vfgSIRI+OnlTaorfqvhNQwpNu7zVwUZnJqV7GjVpL+Zh+F IcEwYpZRe5PdPYH3CcoQZFIwTD+DTRDg+4beEA8sxRbWbfOikfp//OiAcCHhj2M+Otc3ZL dyavZyyATi50lkXeOPAbZ0csRNUsLKU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-09mACe2JMGyt77Vrucdg_Q-1; Fri, 10 Sep 2021 09:10:29 -0400 X-MC-Unique: 09mACe2JMGyt77Vrucdg_Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97CBD1023F4E; Fri, 10 Sep 2021 13:10:27 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9215E5D9F4; Fri, 10 Sep 2021 13:10:21 +0000 (UTC) To: Andrew Rybchenko , dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com References: <20210910091734.7023-1-maxime.coquelin@redhat.com> <20210910091734.7023-2-maxime.coquelin@redhat.com> <7b22e721-c091-6529-88f0-50169e7ab1ba@redhat.com> <9af789b9-78a8-19ff-fc3a-f64dd653b901@oktetlabs.ru> From: Maxime Coquelin Message-ID: <8c5b37ef-2fd1-117c-3dfa-c47375528ce4@redhat.com> Date: Fri, 10 Sep 2021 15:10:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <9af789b9-78a8-19ff-fc3a-f64dd653b901@oktetlabs.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH 1/3] net/virtio: add initial RSS support X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 9/10/21 2:58 PM, Andrew Rybchenko wrote: > On 9/10/21 2:44 PM, Maxime Coquelin wrote: >> Thanks for the review! >> >> On 9/10/21 12:06 PM, Andrew Rybchenko wrote: >>> On 9/10/21 12:17 PM, Maxime Coquelin wrote: >>>> >>> I've failed to find F_RSS definion in virtio spec. >>> Could you share the reference, please. >>> >>> Without the sepc it is almost impossible to review the code. >> >> Sorry, I forgot to add the link, you can find it on the Virtio-spec >> github master branch: >> >> https://github.com/oasis-tcs/virtio-spec/blob/master/content.tex >> >> For readability, I would suggest you to clone it and build the HTML or >> PDF versions. > > Many thanks. > >>>> diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini >>>> index 48f6f393b1..883dd1426c 100644 >>>> --- a/doc/guides/nics/features/virtio.ini >>>> +++ b/doc/guides/nics/features/virtio.ini >>>> @@ -14,6 +14,8 @@ Promiscuous mode = Y >>>> Allmulticast mode = Y >>>> Unicast MAC filter = Y >>>> Multicast MAC filter = Y >>> >>> I'd say that >>> RSS has = P >>> should be added here. >> >> OK, as I mentionned in the cover letter, I was not sure becasue the doc >> says "RSS hash" uses DEV_RX_OFFLOAD_RSS_HASH and provides mbuf.rss, >> which this patch does not since it does not support (yet) >> VIRTIO_NET_F_HASH_REPORT. >> http://doc.dpdk.org/guides/nics/features.html#rss-hash > > Yes, I've seen question in cover letter. It is some kind of gap > in features to claim overall RSS support - just hashing and > distribution across queues without hash forwarding to user. > The item definition covers both generic support and offload to > deliver RSS hash. That's why I suggest P (partial). Ok, got it! Thanks, Maxime >> I can try to add VIRTIO_NET_F_HASH_REPORT in v2, so that we can set RSS >> hash = Y without any doubts :) >> >> Regards, >> Maxime >> >