From: Jochen Behrens <jochen.behrens@broadcom.com>
To: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [PATCH v3] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions
Date: Thu, 23 Oct 2025 17:36:37 -0700 [thread overview]
Message-ID: <8e750656-787c-4dce-8cbe-241e7929d2a0@broadcom.com> (raw)
In-Reply-To: <20251023083019.18792-1-amiyaranjan.mohakud@gmail.com>
Acked-by: Jochen Behrens <jochen.behrens@broadcom.com>
On 10/23/25 01:30, Amiya Ranjan Mohakud wrote:
> It fixes the issue of v4 RSS configuration failure in
> vmxnet3_v4_rss_configure() while writing to BAR register. It's very
> specific to single queue configuration.
>
> https://mails.dpdk.org/archives/users/2025-April/008236.html
>
> Bugzilla ID:1789
> Fixes: 52ec00fd1474e8 ("net/vmxnet3: fix RSS setting on v4")
> Cc: stable@dpdk.org
>
> v2:
> - Fixed typo in commit message
> v3:
> - Checking if RSS is already enabled
>
> Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
> ---
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index f4cdb1bb31..a0306af86c 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -534,6 +534,13 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
>
> PMD_INIT_FUNC_TRACE();
>
> + /* Disabling RSS for single queue pair */
> + if (dev->data->nb_rx_queues == 1 &&
> + dev->data->dev_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_RSS) {
> + dev->data->dev_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
> + PMD_INIT_LOG(ERR, "WARN: Disabling RSS for single Rx queue");
> + }
> +
> if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)
> dev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
>
next prev parent reply other threads:[~2025-10-24 0:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 12:58 [PATCH] " Amiya Ranjan Mohakud
2025-10-22 13:32 ` Amiya Ranjan Mohakud
2025-10-22 13:35 ` Amiya Ranjan Mohakud
2025-10-22 15:56 ` [PATCH v2] " Amiya Ranjan Mohakud
2025-10-23 7:22 ` [PATCH v3] " Amiya Ranjan Mohakud
2025-10-23 8:24 ` Amiya Ranjan Mohakud
2025-10-23 8:30 ` Amiya Ranjan Mohakud
2025-10-23 16:54 ` Stephen Hemminger
2025-10-24 0:36 ` Jochen Behrens [this message]
2025-10-22 16:28 ` [PATCH] " Stephen Hemminger
2025-10-22 16:32 ` Ronak Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e750656-787c-4dce-8cbe-241e7929d2a0@broadcom.com \
--to=jochen.behrens@broadcom.com \
--cc=amiyaranjan.mohakud@gmail.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).