From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <radu.nicolau@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 108171B1A8;
Mon, 21 May 2018 14:58:41 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
21 May 2018 05:58:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,426,1520924400"; d="scan'208";a="57076964"
Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.67])
([10.237.221.67])
by fmsmga001.fm.intel.com with ESMTP; 21 May 2018 05:58:40 -0700
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org
References: <1526902547-12710-1-git-send-email-radu.nicolau@intel.com>
<5146448.Vdf9GQnNb8@xps>
From: Radu Nicolau <radu.nicolau@intel.com>
Message-ID: <8ed23c52-4b88-b40a-ccc5-31c6993654a1@intel.com>
Date: Mon, 21 May 2018 13:58:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <5146448.Vdf9GQnNb8@xps>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-stable] [PATCH] test: fix hang on FreeBSD
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2018 12:58:42 -0000
On 5/21/2018 1:30 PM, Thomas Monjalon wrote:
> 21/05/2018 13:35, Radu Nicolau:
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> ---
>> @@ -34,7 +34,8 @@ test_panic(void)
>> printf("Fork Failed\n");
>> return -1;
>> }
>> - wait(&status);
>> + sleep(1);
>> + waitpid(pid, &status, WNOHANG);
> Please give an explanation why you are adding this sleep.
>
To give a chance to the child process to complete before calling waitpid.