From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Shaiq Wani <shaiq.wani@intel.com>, <dev@dpdk.org>,
<bruce.richardson@intel.com>, <aman.deep.singh@intel.com>
Cc: <stable@dpdk.org>
Subject: Re: [PATCH] net/ice: revert count drop-all filter in Rx stats
Date: Tue, 14 Oct 2025 10:41:38 +0200 [thread overview]
Message-ID: <8ff1b2df-c3bd-45d4-981c-c711409c173d@intel.com> (raw)
In-Reply-To: <20251014054324.3908737-1-shaiq.wani@intel.com>
On 10/14/2025 7:43 AM, Shaiq Wani wrote:
> This reverts commit af05f9e37153c53335938bcde2978a359c5f4efa
>
> This patch caused testpmd to count packets not destined for our MAC
> even when promiscuous mode is off.This behaviour is inconsistent with
> other drivers and leads to incorrect Rx statistics.
>
> Fixes: af05f9e ("net/ice: count drop-all filter in Rx stats")
> Cc: stable@dpdk.org
IIRC this change is still in next-net so no need for CC stable
>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
> index a9a49cd924..9d0fbd2a5a 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -6353,13 +6353,12 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
>
> stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
> pf->main_vsi->eth_stats.rx_multicast +
> - ns->eth.rx_unknown_protocol +
> pf->main_vsi->eth_stats.rx_broadcast -
> pf->main_vsi->eth_stats.rx_discards;
> stats->opackets = ns->eth.tx_unicast +
> ns->eth.tx_multicast +
> ns->eth.tx_broadcast;
> - stats->ibytes = ns->eth.rx_bytes;
> + stats->ibytes = pf->main_vsi->eth_stats.rx_bytes;
> stats->obytes = ns->eth.tx_bytes;
> stats->oerrors = ns->eth.tx_errors +
> pf->main_vsi->eth_stats.tx_errors;
--
Thanks,
Anatoly
next prev parent reply other threads:[~2025-10-14 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 5:43 Shaiq Wani
2025-10-14 8:41 ` Burakov, Anatoly [this message]
2025-10-14 14:07 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff1b2df-c3bd-45d4-981c-c711409c173d@intel.com \
--to=anatoly.burakov@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).