From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B9298374E; Mon, 20 Feb 2017 12:43:51 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 20 Feb 2017 03:43:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,186,1484035200"; d="scan'208";a="227470860" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga004.fm.intel.com with ESMTP; 20 Feb 2017 03:43:49 -0800 To: Qi Zhang , jingjing.wu@intel.com, helin.zhang@intel.com References: <1487549305-5301-1-git-send-email-qi.z.zhang@intel.com> Cc: dev@dpdk.org, stable@dpdk.org From: Ferruh Yigit Message-ID: <9035b7f4-1bee-75d4-adb6-8a8cbed04c49@intel.com> Date: Mon, 20 Feb 2017 11:43:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1487549305-5301-1-git-send-email-qi.z.zhang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix compile error X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2017 11:43:52 -0000 On 2/20/2017 12:08 AM, Qi Zhang wrote: > This patch fix the compile error when RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC > is disabled. Compile error: CC i40e_rxtx_vec_sse.o .../drivers/net/i40e/i40e_rxtx_vec_sse.c:72:26: error: no member named 'fake_mbuf' in 'struct i40e_rx_queue' rxep[i].mbuf = &rxq->fake_mbuf; ~~~ ^ > > Fixes: 9ed94e5bb04e ("i40e: add vector Rx") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_rxtx.c | 2 +- > drivers/net/i40e/i40e_rxtx.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 48429cc..40f4a45 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -2209,11 +2209,11 @@ i40e_reset_rx_queue(struct i40e_rx_queue *rxq) > for (i = 0; i < len * sizeof(union i40e_rx_desc); i++) > ((volatile char *)rxq->rx_ring)[i] = 0; > > -#ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC > memset(&rxq->fake_mbuf, 0x0, sizeof(rxq->fake_mbuf)); > for (i = 0; i < RTE_PMD_I40E_RX_MAX_BURST; ++i) > rxq->sw_ring[rxq->nb_rx_desc + i].mbuf = &rxq->fake_mbuf; > > +#ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC Hi Qi, Just to double check, below update in i40e_rxtx.h is enough to fix the build error. Can you please confirm assigning fake_mbuf to sw_ring[] is required step, independent from RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC enabled or not? And it can be good to document this in commit log. Thanks, ferruh > rxq->rx_nb_avail = 0; > rxq->rx_next_avail = 0; > rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1); > diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h > index 9df8a56..4f7f319 100644 > --- a/drivers/net/i40e/i40e_rxtx.h > +++ b/drivers/net/i40e/i40e_rxtx.h > @@ -119,11 +119,11 @@ struct i40e_rx_queue { > uint16_t nb_rx_hold; /**< number of held free RX desc */ > struct rte_mbuf *pkt_first_seg; /**< first segment of current packet */ > struct rte_mbuf *pkt_last_seg; /**< last segment of current packet */ > + struct rte_mbuf fake_mbuf; /**< dummy mbuf */ > #ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC > uint16_t rx_nb_avail; /**< number of staged packets ready */ > uint16_t rx_next_avail; /**< index of next staged packets */ > uint16_t rx_free_trigger; /**< triggers rx buffer allocation */ > - struct rte_mbuf fake_mbuf; /**< dummy mbuf */ > struct rte_mbuf *rx_stage[RTE_PMD_I40E_RX_MAX_BURST * 2]; > #endif > >