patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] meter: remove inline functions from export list
@ 2020-06-17  8:15 Fady Bader
  2020-06-17  8:24 ` [dpdk-stable] [PATCH v2] " Fady Bader
  0 siblings, 1 reply; 3+ messages in thread
From: Fady Bader @ 2020-06-17  8:15 UTC (permalink / raw)
  To: dev
  Cc: talshn, fady, thomasm, tbashar, harini.ramakrishnan, ocardona,
	pallavi.kadam, ranjit.menon, cristian.dumitrescu, stable

The code didn't compile when using exported meter functions under windows.

error LNK2001: unresolved external symbol rte_meter_srtcm_color_aware_check
error LNK2001: unresolved external symbol rte_meter_srtcm_color_blind_check
error LNK2001: unresolved external symbol rte_meter_trtcm_color_aware_check
error LNK2001: unresolved external symbol rte_meter_trtcm_color_blind_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_blind_check

The cause was that there were some inline functions that were included in the
export list.
To solve this the functions were removed from rte_meter_version.map export list
which are implemented in the header and shouldn't be exported.

Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM")
Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning")
Cc: stable@dpdk.org

Signed-off-by: Fady Bader <fady@mellanox.com>
---
 lib/librte_meter/rte_meter_version.map | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index b493bcebe9..58859d4d76 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -1,12 +1,8 @@
 DPDK_20.0 {
 	global:
 
-	rte_meter_srtcm_color_aware_check;
-	rte_meter_srtcm_color_blind_check;
 	rte_meter_srtcm_config;
 	rte_meter_srtcm_profile_config;
-	rte_meter_trtcm_color_aware_check;
-	rte_meter_trtcm_color_blind_check;
 	rte_meter_trtcm_config;
 	rte_meter_trtcm_profile_config;
 
@@ -16,8 +12,6 @@ DPDK_20.0 {
 DPDK_21 {
 	global:
 
-	rte_meter_trtcm_rfc4115_color_aware_check;
-	rte_meter_trtcm_rfc4115_color_blind_check;
 	rte_meter_trtcm_rfc4115_config;
 	rte_meter_trtcm_rfc4115_profile_config;
 
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-stable] [PATCH v2] meter: remove inline functions from export list
  2020-06-17  8:15 [dpdk-stable] [PATCH] meter: remove inline functions from export list Fady Bader
@ 2020-06-17  8:24 ` " Fady Bader
  2020-06-23 17:36   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Fady Bader @ 2020-06-17  8:24 UTC (permalink / raw)
  To: dev
  Cc: talshn, fady, thomasm, tbashar, harini.ramakrishnan, ocardona,
	pallavi.kadam, ranjit.menon, cristian.dumitrescu, stable

The code didn't compile when using exported meter functions under windows.

error LNK2001: unresolved external symbol
rte_meter_srtcm_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_srtcm_color_blind_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_color_blind_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_blind_check

The cause was that there were some inline functions that were included in
the export list.
To solve this the functions were removed from rte_meter_version.map export
list which are implemented in the header and shouldn't be exported.

Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM")
Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning")
Cc: stable@dpdk.org

Signed-off-by: Fady Bader <fady@mellanox.com>

---

v2: fixed commit message style issue
---
 lib/librte_meter/rte_meter_version.map | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index b493bcebe9..58859d4d76 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -1,12 +1,8 @@
 DPDK_20.0 {
 	global:
 
-	rte_meter_srtcm_color_aware_check;
-	rte_meter_srtcm_color_blind_check;
 	rte_meter_srtcm_config;
 	rte_meter_srtcm_profile_config;
-	rte_meter_trtcm_color_aware_check;
-	rte_meter_trtcm_color_blind_check;
 	rte_meter_trtcm_config;
 	rte_meter_trtcm_profile_config;
 
@@ -16,8 +12,6 @@ DPDK_20.0 {
 DPDK_21 {
 	global:
 
-	rte_meter_trtcm_rfc4115_color_aware_check;
-	rte_meter_trtcm_rfc4115_color_blind_check;
 	rte_meter_trtcm_rfc4115_config;
 	rte_meter_trtcm_rfc4115_profile_config;
 
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v2] meter: remove inline functions from export list
  2020-06-17  8:24 ` [dpdk-stable] [PATCH v2] " Fady Bader
@ 2020-06-23 17:36   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-06-23 17:36 UTC (permalink / raw)
  To: Fady Bader
  Cc: dev, stable, talshn, fady, tbashar, harini.ramakrishnan,
	ocardona, pallavi.kadam, ranjit.menon, cristian.dumitrescu

17/06/2020 10:24, Fady Bader:
> The code didn't compile when using exported meter functions under windows.
> 
> error LNK2001: unresolved external symbol
> rte_meter_srtcm_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_srtcm_color_blind_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_color_blind_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_rfc4115_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_rfc4115_color_blind_check
> 
> The cause was that there were some inline functions that were included in
> the export list.
> To solve this the functions were removed from rte_meter_version.map export
> list which are implemented in the header and shouldn't be exported.
> 
> Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM")
> Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fady Bader <fady@mellanox.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17  8:15 [dpdk-stable] [PATCH] meter: remove inline functions from export list Fady Bader
2020-06-17  8:24 ` [dpdk-stable] [PATCH v2] " Fady Bader
2020-06-23 17:36   ` Thomas Monjalon

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox