From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 11C05A0547
for <public@inbox.dpdk.org>; Thu, 25 Feb 2021 11:41:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id F3DAA160785;
Thu, 25 Feb 2021 11:41:27 +0100 (CET)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id D8C224067B;
Thu, 25 Feb 2021 11:41:25 +0100 (CET)
IronPort-SDR: SQ2f1Wsujs7yjRlRyzTdUu/g9RVUsULGng9UKyMZ1CALAt1YJfbr75E0tpnd0eVWx/X99k52Mo
Yr0xKS/Xnm8A==
X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="164704998"
X-IronPort-AV: E=Sophos;i="5.81,205,1610438400"; d="scan'208";a="164704998"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
25 Feb 2021 02:41:23 -0800
IronPort-SDR: sBzMtwek/A6w4nLpmTEslSzWW4pgNyO+vDOiN0ePHsDNrVo9Nr1UJ20nBwrXtdGAfdJsO2FE0D
WlFudcZezCzw==
X-IronPort-AV: E=Sophos;i="5.81,205,1610438400"; d="scan'208";a="404219174"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.17.100])
([10.252.17.100])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
25 Feb 2021 02:41:21 -0800
To: David Marchand <david.marchand@redhat.com>
Cc: David Hunt <david.hunt@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>, Aaron Conole <aconole@redhat.com>,
=?UTF-8?Q?Juraj_Linke=c5=a1?= <juraj.linkes@pantheon.tech>,
Thomas Monjalon <thomas@monjalon.net>
References: <20210121172201.22582-1-david.hunt@intel.com>
<20210224145434.3108928-1-ferruh.yigit@intel.com>
<CAJFAV8ysDiVrHK_ev56OvVGA=3ErkCOimTQeBdmbnKZ28dD1Lg@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <914805d2-d927-4b44-8db5-cf47bfb3bb55@intel.com>
Date: Thu, 25 Feb 2021 10:41:17 +0000
MIME-Version: 1.0
In-Reply-To: <CAJFAV8ysDiVrHK_ev56OvVGA=3ErkCOimTQeBdmbnKZ28dD1Lg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] power: remove duplicated
symbols from map file
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On 2/25/2021 9:11 AM, David Marchand wrote:
> Hello Ferruh,
>
> On Wed, Feb 24, 2021 at 3:55 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> This is also causing build error, like:
>> https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104
>>
>> Also '@internal' marker removed from doxygen comment, since public API
>> should not be internal.
>>
>> Fixes: 4d3892dcd77b ("power: make channel message functions public")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Aaron Conole <aconole@redhat.com>
>> Cc: Bruce Richardson <bruce.richardson@intel.com>
>> Cc: David Marchand <david.marchand@redhat.com>
>> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
>> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
>> ---
>> lib/librte_power/rte_power_guest_channel.h | 4 ----
>> lib/librte_power/version.map | 2 --
>> 2 files changed, 6 deletions(-)
>>
>> diff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_power/rte_power_guest_channel.h
>> index ed4fbfdcd38a..7586e9491f11 100644
>> --- a/lib/librte_power/rte_power_guest_channel.h
>> +++ b/lib/librte_power/rte_power_guest_channel.h
>> @@ -119,8 +119,6 @@ struct rte_power_channel_packet_caps_list {
>> };
>>
>> /**
>> - * @internal
>> - *
>> * @warning
>> * @b EXPERIMENTAL: this API may change without prior notice.
>> *
>> @@ -141,8 +139,6 @@ int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt,
>> unsigned int lcore_id);
>>
>> /**
>> - * @internal
>> - *
>> * @warning
>> * @b EXPERIMENTAL: this API may change without prior notice.
>> *
>> diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map
>> index 3ba9390241d2..bce5110dd5b4 100644
>> --- a/lib/librte_power/version.map
>> +++ b/lib/librte_power/version.map
>> @@ -12,7 +12,6 @@ DPDK_21 {
>> rte_power_get_capabilities;
>> rte_power_get_env;
>> rte_power_get_freq;
>> - rte_power_guest_channel_send_msg;
>
> This symbol was marked stable so far.
> Did I miss something?
> I would just remove the experimental tagging for this symbol which is
> incorrect in v21.02.
>
You are right,
The header that has the declares the API was not public before the v21.02, so I
assumed the symbol is internal and added to the stable section by mistake, but
the intention seems to have it as public API.
I will keep the 'rte_power_guest_channel_send_msg' API, but
'rte_power_guest_channel_receive_msg' is already experimental, so will keep it
as it is.
> Something like:
> diff --git a/lib/librte_power/rte_power_guest_channel.h
> b/lib/librte_power/rte_power_guest_channel.h
> index ed4fbfdcd3..b5de1bd243 100644
> --- a/lib/librte_power/rte_power_guest_channel.h
> +++ b/lib/librte_power/rte_power_guest_channel.h
> @@ -119,11 +119,6 @@ struct rte_power_channel_packet_caps_list {
> };
>
> /**
> - * @internal
> - *
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
> * Send a message contained in pkt over the Virtio-Serial to the host endpoint.
> *
> * @param pkt
> @@ -136,13 +131,10 @@ struct rte_power_channel_packet_caps_list {
> * - 0 on success.
> * - Negative on error.
> */
> -__rte_experimental
> int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt,
> unsigned int lcore_id);
>
> /**
> - * @internal
> - *
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice.
> *
> diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map
> index 3ba9390241..b004e3e4a9 100644
> --- a/lib/librte_power/version.map
> +++ b/lib/librte_power/version.map
> @@ -38,6 +38,4 @@ EXPERIMENTAL {
> # added in 21.02
> rte_power_ethdev_pmgmt_queue_disable;
> rte_power_ethdev_pmgmt_queue_enable;
> - rte_power_guest_channel_receive_msg;
> - rte_power_guest_channel_send_msg;
> };
>
>
>
> Sidenote, we can probably catch these duplicates during build.
> For duplicate entries with the same version, this is easy.
> I'll see if I can catch the other case too.
>
Wasn't there a script for it already, I slightly remember it but not sure, cc'ed
Thomas, perhaps he remembers.