From: "Eads, Gage" <gage.eads@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] bus/vdev: fix wrong error log on secondary device scan
Date: Tue, 4 Sep 2018 14:45:20 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E44718085@fmsmsx101.amr.corp.intel.com> (raw)
In-Reply-To: <20180903085022.45183-1-qi.z.zhang@intel.com>
Acked-by: Gage Eads <gage.eads@intel.com>
Thanks!
Gage
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, September 3, 2018 3:50 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Eads, Gage <gage.eads@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] bus/vdev: fix wrong error log on secondary device scan
>
> When a secondary process handles VDEV_SCAN_ONE mp action, it is possible
> the device is already be inserted. This happens when we have multiple secondary
> processes which cause multiple broadcasts from primary during
> bus->scan. So we don't need to log any error for -EEXIST.
>
> Bugzilla ID: 84
> Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
> Cc: stable@dpdk.org
>
> Reported-by: Eads Gage <gage.eads@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>
> v2:
> - change log level to DEBUG for the case device already exist.
>
> drivers/bus/vdev/vdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index
> 6139dd551..69dee89a8 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -346,6 +346,7 @@ vdev_action(const struct rte_mp_msg *mp_msg, const
> void *peer)
> const struct vdev_param *in = (const struct vdev_param *)mp_msg-
> >param;
> const char *devname;
> int num;
> + int ret;
>
> strlcpy(mp_resp.name, VDEV_MP_KEY, sizeof(mp_resp.name));
> mp_resp.len_param = sizeof(*ou);
> @@ -380,7 +381,10 @@ vdev_action(const struct rte_mp_msg *mp_msg, const
> void *peer)
> break;
> case VDEV_SCAN_ONE:
> VDEV_LOG(INFO, "receive vdev, %s", in->name);
> - if (insert_vdev(in->name, NULL, NULL) < 0)
> + ret = insert_vdev(in->name, NULL, NULL);
> + if (ret == -EEXIST)
> + VDEV_LOG(DEBUG, "device already exist, %s", in-
> >name);
> + else if (ret < 0)
> VDEV_LOG(ERR, "failed to add vdev, %s", in->name);
> break;
> default:
> --
> 2.13.6
next prev parent reply other threads:[~2018-09-04 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 12:27 [dpdk-stable] [PATCH] " Qi Zhang
2018-08-27 16:16 ` Burakov, Anatoly
2018-09-03 8:49 ` Qi Zhang
2018-09-03 8:50 ` [dpdk-stable] [PATCH v2] " Qi Zhang
2018-09-04 14:45 ` Eads, Gage [this message]
2018-09-16 9:35 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E44718085@fmsmsx101.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).