patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ray Kinsella <mdr@ashroe.eu>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	dpdk stable <stable@dpdk.org>, dev <dev@dpdk.org>,
	Eelco Chaudron <echaudro@redhat.com>,
	Kevin Traynor <ktraynor@redhat.com>,
	Ian Stokes <ian.stokes@intel.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental
Date: Thu, 30 Jan 2020 16:33:29 +0000	[thread overview]
Message-ID: <9272ec9c-2bcc-332b-fcfc-4b35088457d4@ashroe.eu> (raw)
In-Reply-To: <f315b3c1-c6dc-70a5-ef9e-e088cbc3c5be@intel.com>



On 16/01/2020 12:42, Ferruh Yigit wrote:
> On 1/16/2020 11:54 AM, Neil Horman wrote:
>> On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote:
>>> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron <echaudro@redhat.com> wrote:
>>>>
>>>> Moved RFC4115 APIs to none experimental as they have been there
>>>> since 19.02. Also, these APIs are the same as the none RFC4115 APIs.
>>>>
>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>>
>>> There is a discussion on the OVS ml at the moment to get these symbols
>>> in the stable ABI for 19.11.
>>> I want to understand how this would be done.
>>>
>>> - I take this patch in 20.02, these symbols are added in the 20.0.1 ABI.
>>> On the other hand, the 19.11 release maintains the 20.0 ABI.
>>>
>>> Does it mean the backport adds these symbols with the 20.0 version in
>>> the 19.11 branch?
>>> Or is 20.0.1 version acceptable / a thing we want?
>>>
>>>
>>> - These symbol already existed in the 20.0 ABI, versioned as EXPERIMENTAL.
>>> We can go and remove these entries since we are not bound to preserve
>>> the experimental APIs.
>>> But, on the other hand, nothing should prevent us from keeping some
>>> aliases so that the symbols versioned EXPERIMENTAL are still available
>>> to existing users.
>>>
>> I would say that choice is up to you.  If you want to alias them to be nice to
>> prior users, thats fine by me. But experimental means experimental, and so users
>> have to be prepared to rebuild when things change, even if that change is
>> changing the version from experimental to a concrete version.
>>
> 
> I would prefer to keep the alias and don't break the existing users, specially
> for the case experimental API is becoming mature without change.
> 

Apologies for dragging up an older thread.
I had a thought later that we should add something formal to the ABI Policy.

Such that if we have an API that has been part of DPDK as experimental for a long time, 
to the point it has a number of users - out of kindness, the maintainer may ask a
contributor to add an alias until the next major ABI version is declared?
So as not to break consuming projects - make sense?

Thanks, 

Ray K

      parent reply	other threads:[~2020-01-30 16:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 13:07 Eelco Chaudron
2019-12-17 13:52 ` Dumitrescu, Cristian
2020-01-20 15:17   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-01-16 11:25 ` [dpdk-stable] " David Marchand
2020-01-16 11:54   ` Neil Horman
2020-01-16 12:42     ` Ferruh Yigit
2020-01-16 14:38       ` Thomas Monjalon
2020-01-17  8:27         ` David Marchand
2020-01-17 10:46           ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2020-01-22 13:55       ` [dpdk-stable] " Ray Kinsella
2020-01-30 16:33       ` Ray Kinsella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9272ec9c-2bcc-332b-fcfc-4b35088457d4@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=bluca@debian.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=echaudro@redhat.com \
    --cc=ferruh.yigit@intel.com \
    --cc=i.maximets@ovn.org \
    --cc=ian.stokes@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).