From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4FC922A5D; Fri, 17 Feb 2017 17:35:00 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 17 Feb 2017 08:34:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="824511049" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 17 Feb 2017 08:34:58 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 17 Feb 2017 08:34:58 -0800 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.230]) by FMSMSX109.amr.corp.intel.com ([169.254.15.41]) with mapi id 14.03.0248.002; Fri, 17 Feb 2017 08:34:58 -0800 From: "Wiles, Keith" To: "Yigit, Ferruh" CC: "dev@dpdk.org" , dpdk stable Thread-Topic: [dpdk-dev] [PATCH v4] net/tap: fix coverity warning on strncpy Thread-Index: AQHSiTSWDr9dkBf1fE6a6BMvg8kxEaFt55mAgAADpQA= Date: Fri, 17 Feb 2017 16:34:58 +0000 Message-ID: <93F4E359-E193-477D-97AD-E758BF755E75@intel.com> References: <20170217154304.50214-1-keith.wiles@intel.com> <37245ce5-de84-27fb-14a7-36ad8934a8d6@intel.com> In-Reply-To: <37245ce5-de84-27fb-14a7-36ad8934a8d6@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.93.69] Content-Type: text/plain; charset="us-ascii" Content-ID: <640EF735FE430848B2ADDC42E999D079@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/tap: fix coverity warning on strncpy X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 16:35:01 -0000 > On Feb 17, 2017, at 10:21 AM, Yigit, Ferruh wrot= e: >=20 > On 2/17/2017 3:43 PM, Keith Wiles wrote: >> Calling strncpy with a maximum size argument of 16 bytes on destination >> array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the >> destination string unterminated. >>=20 >> Signed-off-by: Keith Wiles >=20 > net/tap: fix possibly unterminated string >=20 > Coverity issue: 1407499 > Fixes: 6b38b2725cdb ("net/tap: fix multi-queue support") > Cc: stable@dpdk.org >=20 > Applied to dpdk-next-net/master, thanks. >=20 >=20 > (Updates: > - patch title: > It is preferred to mention from problem solved instead of the tool that > found it. >=20 > - Added coverity tag: > This helps to trace coverity issues, defined syntax is: >=20 > Coverity issue: xxx > Fixes: yyyy >=20 > - Added Cc: tag for stable tree: > In case stable tree wants get this patch, to make patch visible. I agree this is good, but to many rules not listed or checked in the tools.= We need a much easier method to submit patches in the format that is defin= ed and checked. Today it is way to hard to know every little internal format for every type= of patch. We need to fix this problem to make it easier to submit patches = to dpdk.org, we can not continue like this as we grow it will become way to= much work for the repo maintainers and the submitter. Using a better tool then submitting via email seems like a better solution = as long as we can add the given checks to the tool. Using a tools should al= so reduce the email traffic for most everyone, but we need to allow anyone = to ask for all of the commits to the repo or pull requests like patches. How can we handle these types of issues in the future? > ) Regards, Keith