From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6CD2F1B0F9 for ; Wed, 21 Nov 2018 18:08:59 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7BF273082143; Wed, 21 Nov 2018 17:08:58 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3753560A9C; Wed, 21 Nov 2018 17:08:55 +0000 (UTC) To: Jeff Guo , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, thomas@monjalon.net, shaopeng.he@intel.com Cc: helin.zhang@intel.com, "stable@dpdk.org" References: <1534502916-31636-9-git-send-email-jia.guo@intel.com> <1539844035-11524-1-git-send-email-jia.guo@intel.com> From: Kevin Traynor Organization: Red Hat Message-ID: <93e5d7a5-3c78-8300-1397-996acf9c201a@redhat.com> Date: Wed, 21 Nov 2018 17:08:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1539844035-11524-1-git-send-email-jia.guo@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 21 Nov 2018 17:08:58 +0000 (UTC) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] igb_uio: fix unexpected removal for hot-unplug X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 17:08:59 -0000 On 10/18/2018 07:27 AM, Jeff Guo wrote: > When a device is hot-unplugged, pci_remove will be invoked unexpectedly > before pci_release, it will caused kernel hung issue which will throw the > error info of "Trying to free already-free IRQ XXX". And on the other hand, > if pci_remove before pci_release, the interrupt will not got chance to be > disabled. So this patch aim to fix this issue by adding pci_release call > in pci_remove, it will gurranty that all pci clean up will be done before > pci removal. > Hi, is this patch for the stable branch? > Signed-off-by: Jeff Guo > --- > kernel/linux/igb_uio/igb_uio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c > index fede66c..3cf394b 100644 > --- a/kernel/linux/igb_uio/igb_uio.c > +++ b/kernel/linux/igb_uio/igb_uio.c > @@ -570,6 +570,8 @@ igbuio_pci_remove(struct pci_dev *dev) > { > struct rte_uio_pci_dev *udev = pci_get_drvdata(dev); > > + igbuio_pci_release(&udev->info, NULL); > + > sysfs_remove_group(&dev->dev.kobj, &dev_attr_grp); > uio_unregister_device(&udev->info); > igbuio_pci_release_iomem(&udev->info); >