From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0061AA046B for ; Tue, 23 Jul 2019 09:11:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E041C1BF91; Tue, 23 Jul 2019 09:11:59 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9DA721BF91; Tue, 23 Jul 2019 09:11:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 00:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,298,1559545200"; d="scan'208";a="192977168" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 23 Jul 2019 00:11:56 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jul 2019 00:11:56 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jul 2019 00:11:56 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by shsmsx102.ccr.corp.intel.com ([169.254.2.3]) with mapi id 14.03.0439.000; Tue, 23 Jul 2019 15:11:53 +0800 From: "Xing, Beilei" To: "Ye, Xiaolong" , "Yigit, Ferruh" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Li, Xiaoyun" Thread-Topic: [PATCH 2/2] net/i40e: fix fdir rule destroy failure Thread-Index: AQHVQQxf5BgFuKIYfUqMTRZD4pn0mqbXyYuw Date: Tue, 23 Jul 2019 07:11:53 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CE093A6@SHSMSX101.ccr.corp.intel.com> References: <20190722120639.62468-1-xiaolong.ye@intel.com> <20190722120639.62468-2-xiaolong.ye@intel.com> In-Reply-To: <20190722120639.62468-2-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 2/2] net/i40e: fix fdir rule destroy failure X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, July 22, 2019 8:07 PM > To: Yigit, Ferruh ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; stable@dpdk.org; > Li, Xiaoyun > Subject: [PATCH 2/2] net/i40e: fix fdir rule destroy failure >=20 > We should tear down the fdir when the last flow is destroyed, current log= ic is > opposite to expected behavior, this patch fixes this issue. >=20 > Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") > Cc: stable@dpdk.org > Cc: xiaoyun.li@intel.com >=20 > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/i40e_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 3c0af70c0..c60c9e240 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4771,7 +4771,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev, > &((struct i40e_fdir_filter *)flow->rule)->fdir, 0); >=20 > /* If the last flow is destroyed, disable fdir. */ > - if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) { > + if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) { > i40e_fdir_teardown(pf); > dev->data->dev_conf.fdir_conf.mode =3D > RTE_FDIR_MODE_NONE; > -- > 2.17.0 Acked-by: Beilei Xing