From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, David Hunt <david.hunt@intel.com>
Subject: Re: [PATCH] distributor: fix potential overflow bug
Date: Sun, 27 Feb 2022 19:07:20 +0100 [thread overview]
Message-ID: <9516596.EvYhyI6sBW@thomas> (raw)
In-Reply-To: <153e9fb1-8568-1c82-0281-ca74bce0376d@intel.com>
17/02/2022 16:24, David Hunt:
> Hi Bruce,
>
> On 17/2/2022 3:02 PM, Bruce Richardson wrote:
> > Coverity flags the fact that the tag values used in distributor are
> > 32-bit, which means that when we use bit-manipulation to convert a tag
> > match/no-match to a bit in an array, we need to typecast to a 64-bit
> > type before shifting past 32 bits.
> >
> > Coverity issue: 375808
> > Fixes: 08ccf3faa6a9 ("distributor: new packet distributor library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> LGTM
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks.
prev parent reply other threads:[~2022-02-27 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 15:02 Bruce Richardson
2022-02-17 15:24 ` David Hunt
2022-02-27 18:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9516596.EvYhyI6sBW@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).