From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAB44A034C for ; Tue, 15 Feb 2022 17:46:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4A5B41157; Tue, 15 Feb 2022 17:46:45 +0100 (CET) Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by mails.dpdk.org (Postfix) with ESMTP id 441D44113E; Tue, 15 Feb 2022 17:46:43 +0100 (CET) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21FGUEvx031611; Tue, 15 Feb 2022 16:46:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=PEByf2YHNNpUUtIznQT7GxiYCu41EKI+O8xLVnlhC/w=; b=xpXqT7/ZZsg3IrSUvZYYP6K6RFiXYB6FmmQA/4LfGGSlBMM0WuHy5zei5DNsZfdPKq6A wb2hSeBlwhnW9RAxHDXHixbyP+Vx8zOPCulv5Ak3ib9Z7zxFYQ0gBE+oeN6txTj5rjxA mNEcxL11YlybtffW1RIvtZb5qeKNSBWXSiyZD1UdS3l+4Cm2z/xATDE744F4WAcW+nXu ldDBIgnofBnKqKU9drAg9Ii8QC36abeA9JEpn7FnXGTLa95ZKmMQGDibriOV+dxB0fU4 GCPeF5l4a7ByHLbeXzRi2pzIJIEsMfDX5XzHvwwpZGT3HReWPe7vDLS8ni0BSAUzIJKm ig== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3e820njdty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Feb 2022 16:46:42 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21FGfBOd098897; Tue, 15 Feb 2022 16:46:40 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by userp3020.oracle.com with ESMTP id 3e66bnw4hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Feb 2022 16:46:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgRqoNNNBvSPewJ8oDNdeCDgxFG4OohHbTRuneV+mdxVvvM1bsAZ4+zb1qXgwTr5/BnO9UCFq0uAKqPZNFgDLjNkUtuHNBfAKbiVQqx7eIRagk4gxoSBfWCpdNx/X8Bq2OoTQthwxlnl+3mIumBvqGNWVsrQ2TOKhitsaClsclrOoMv0+GmklGSyAGniwUZ2cb1N0mO6+TPx0fGhrdKdaf6+oWHqlcLhrMyJshatLnDl481rN2Iu4NaaYRiL+fGCPdSyUy7L8iLUs8KXDANj/Lc0FTrixDcIbxZcz/7niyp//e5TQuTM3mWrwsI/7b26c2r5Y3s2+wDFYzWnouxZ/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PEByf2YHNNpUUtIznQT7GxiYCu41EKI+O8xLVnlhC/w=; b=CG7L9M22yhtqcTl3J47V4Ni+Z8YTil/uqUpFigzxSQzhD3QaHxA0VxRPjDRzR13+3TqZUAmpTdh2s4D0rsFEQJt0HfGZBnIGc6bnBSQ2aCcE8O6O5I8PmoYbw1yTUmKcOs5yRw9T4kyLSkrzXJO7CBLwihJ+dMTnsJb0wpSSeJnTEEQ9qDp6vIX/E5AykH4OhmncmDSeaf3emwQH7Npoi09wmuRmrzPbL5lghbh3FejopfwMIP6C8CG4i7zDSMT9JhkglfXE5c2HzKyu8ibfZmITsypOaipFxkdT1+laFL9myyIESaU584BiLFlfk2hrXzLlhQhRK+0uJ+gI/SAlHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PEByf2YHNNpUUtIznQT7GxiYCu41EKI+O8xLVnlhC/w=; b=OpK/cBPNQU7ll57m4xTWapI1RtyBZkQobSwCh9oEc/MVBrtpdsQOZyGSbk02Jh0d7OOU4OiizsnjTkQsFPHyhgD0LCBA0gpSRIa6Z4JwV4VFYK5X4Q5CMMyzZSwzDVnclZLuBcYcYNSIs5gln6YOOyY1iU3NVmBJWe1LdDb8SBo= Received: from PH0PR10MB5514.namprd10.prod.outlook.com (2603:10b6:510:106::17) by DM5PR10MB1337.namprd10.prod.outlook.com (2603:10b6:3:10::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Tue, 15 Feb 2022 16:46:38 +0000 Received: from PH0PR10MB5514.namprd10.prod.outlook.com ([fe80::7080:9532:83ec:6f68]) by PH0PR10MB5514.namprd10.prod.outlook.com ([fe80::7080:9532:83ec:6f68%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 16:46:38 +0000 Message-ID: <952c9880-9ad9-bfa6-e39a-271a06226640@oracle.com> Date: Tue, 15 Feb 2022 22:16:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2] net/failsafe: link_update request crashing at boot Content-Language: en-US From: Vipul Ashri To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org, =?UTF-8?Q?Ga=c3=abtan_Rivet?= References: <20211021115139.2634-1-vipul.ashri@oracle.com> <20211021214215.1633-1-vipul.ashri@oracle.com> <87c84612-4116-4fe7-a711-f5f364513c3d@www.fastmail.com> Organization: Oracle Corporation In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0021.apcprd02.prod.outlook.com (2603:1096:3:17::33) To PH0PR10MB5514.namprd10.prod.outlook.com (2603:10b6:510:106::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 141c8b8b-2c7b-420e-0055-08d9f0a2bc07 X-MS-TrafficTypeDiagnostic: DM5PR10MB1337:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: apW5m92ikW/no5xhn69pNRLQgMu95BuNufGA92S00PVcEBHx4AyDXEM3Cxe+tw51VV+g8PZrvcPj0m7aGtUS8NvGWWMfPidzU67mzNbRBzUZvFZLrpN1IfR905HW5WIupgjJgEUPuRByHuqSmYSznC8RoIOVhvS1ed8q+QBxGWLAKHLhjNM/wAGtfSZbJsmPv6z6YBE6sIj7ey6/kpcjntNZXcozP71wD4lO4TvAZ1NWzVrRptTU/7DMfu2AEvXwrf+ZFcU6VB6AbzOt46s01qKUTbBoXh2xQwHgMZtp+lfs6Xj7/qmuIahwtnZDqfZ7HxaprDivQS5o4NmgxW+l/T6kuEVzbep9dXPvTzzqbVmvaLfwsgOhhT/ILjT4J6PwE0XiSa0WQXfuK+jJ7YL14P202Y+uoi0HaSVQb1PNkJkFzyOUUGxKWN6QrkESUg+JSjjwBxOFzdHvXJVm1ZsvVJVf3mDDYGIdO5V/tiHxx3xUk69EMb6bn6bFe/AhxKPFkrSMiWhd7G43le6i25nlKIbB6Fgb+R6WWaemLGRo2gybVxJU2t+YTLHS2mAC5VTJUPx9h9TYbYYy+0hvpDhur5uvAxSRY6WMSu8/2Xzpf5GffWtHP9QICnd3bOgVn6ghcCUcCis1OaXU1oq5ebFsRYpRN478rDy+bwl2+vg98VxDMoCsVUYM8+nExuNmZoCVUvzbA5l/yNpQt3b2jE2oOyriEyent3QmzfC2JVMkWYU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR10MB5514.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6916009)(6506007)(316002)(508600001)(86362001)(83380400001)(6486002)(6512007)(31686004)(6666004)(38100700002)(44832011)(186003)(31696002)(2906002)(2616005)(36756003)(8676002)(4326008)(36916002)(66476007)(53546011)(66556008)(5660300002)(66946007)(8936002)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3p3VVB2WlR5RlIyNWs1YjI3eTd6d2pTazNxSWNUVy9XY2wzUmZ4dmUxU2pP?= =?utf-8?B?MWtNMHRENndRaFZLaTQydFRLUUNOVE1jcFVsQ2VnWmNpcFVQdGxxbWJJbm9y?= =?utf-8?B?K21hVWRIdXk3RjAxb250Z3lIK20xSnVwYU5wRkY1alUyVzBhcGdER2JqY0Zq?= =?utf-8?B?WG5IWjJtY2daMmF2c2NVby91eDZrb3owd001ekZaNDI2bzRQZE13NEhVTXkw?= =?utf-8?B?VmtmQmk1TytIODl0aWFBd0JyYk9qTk84Y01YOFdKSFBucWtnaGZVR05xaWFq?= =?utf-8?B?SjBFdWllMkdNVHZNNUs2QXdrT1BibXFrVFpQNTI5aUN2STZzSXpBRGdickJ3?= =?utf-8?B?K05qcjlmdnZrWXJyYVR2MlA2dnZPSGpmNHUzUFdaNlJva08yV0NCMjR2ZWE3?= =?utf-8?B?eVZRaEdodGh0SlF2clc4Q1gxUERtV2Y2SVR5alR2dE9kdHRRT2xmUWkxTG1B?= =?utf-8?B?S0hSckdzOGowZ0NTd0t3WlF3clAycE9KSUVSWjRWVkVuSjVaaXd0UUIvOXhy?= =?utf-8?B?UHVmOFZ2d2ZJVmVRaG5NQTVqVWFoa3Axem4zZEE2WDRMb1phV2IzTkVXVGxL?= =?utf-8?B?eWNqdkVxd3RaSmtENUVVQnY2Mlp0QjdRUHVBM0g3ckZBekhkeCt4UGR1RGtM?= =?utf-8?B?SXZoNjBIeE4zVjQ3TmNrdFpEQmFqcFlJcGVmbEJ5ZEFieW96MWdiQzJnb1Vw?= =?utf-8?B?bzBtSkdKWjE5UnFWT29lZkdCTEVUSWRUaXUyYjhSUE5qQ0tFNGRHUXUxWkk3?= =?utf-8?B?dUlJb3pNMnkza1pHako4MmNoTlFXNE00c1pyeENNNG5YeHF4SG1jTnMxUVFw?= =?utf-8?B?YzRVcUEwbHI0MWNBc3JjYjZuY2ppelFwb2wzaTBYUzhoT3ltd1Z0RWhZUVdU?= =?utf-8?B?QmlCYm5Xc1BvbnBmSzgvMlZ6Mnc2Q1UzanJXa21LVUhTL1FpVXFleTRKWktX?= =?utf-8?B?VTEvN1RPNGJtOXYrRDYxWXBrbVFkSmpIUnBrK1ZRUEdhOTdJSU44NlZhWGRD?= =?utf-8?B?Yjg3dy9lUS93QzZzU3ZTMDI1RzcvM21FOU5NYWovTURpM3VwWU5WVCtVZkdh?= =?utf-8?B?MUVZMXZGQm9Xa2tRdkdtMjdtUU5YRy9QSThkM0JkdW9jb3ZCUmtadXVaNk14?= =?utf-8?B?eW9PSmNzTVpWdTBYKzRVRnl3cXdEbjNEcFd6SERHbXhVRUhZUUoyVnNNeU5y?= =?utf-8?B?Vk5iMllmS3ZTTUo2dFc2QkNmQjRYYXg5REN6cFZ4NDJDbk9xWEYxaDdDT3Fl?= =?utf-8?B?NUQ2NEFaWlFoWWdKVDhjcFppQ1Q3RGV3dFhMT25Uc3dXUHoxeFpQbE5tOEEy?= =?utf-8?B?d3dkODNTREJpdFM0T2Q4N1U4R25ocGpjWCtTYTg4RXVKY1R2V2pFNDhkVVd2?= =?utf-8?B?aU1RWEdZSEYvSkh6NFN5cDlwSTlFci92eEJXUzBCM0tTbmhpYXQvNk4ybnMx?= =?utf-8?B?MlRHSURrSnFqOVVBajVVRlJRVzFqZ1NKcVk3cUhQWTVNa2ZaN3FRcVFFZlk3?= =?utf-8?B?NXBHL2hLczVXdXBHcTNGUkdIUndBcjQvQStQaTNUdnR4Rko4VmFWSlNraVFG?= =?utf-8?B?TVduQ3R6MDhtcHBwOWRvTHczK09CVDQ3K3Z0NEExV1ZpTExhU2JvWE8vWTdo?= =?utf-8?B?UEw3UndBaUhVa1FBeUk1c2R4Um1wKytCYVlqcDU5dHBxVnJMb0twdERwQkVu?= =?utf-8?B?Q2JFSHd2Q3E5ODZ5YjJBK1l0T2Y3SzUzVkNLdmRlZTBvUDBqdXFxdkZPZGkw?= =?utf-8?B?ZHg2V0lMMnBzNTllMWEycDJ6MDA4Zm5VT2IzMmtiV09sSVpqcjlsUHNRaGlV?= =?utf-8?B?Y1dUL2w3SDRicGlKRkJFZnBxdGhwZGVWQmpzSkpzRmZVazNUb2gveUE5Ylpj?= =?utf-8?B?TnQ2OHk5VXIyVmpKbmM0L2I5WUZLWkt5Zkpud0c4SFFFTWpKb3VXTjB4VFhh?= =?utf-8?B?WEdHMWVUWTIzZE9ycW1pU1NsRnZyTmdtSGlOZUVBWWxYQklMd2R1Z1RqZTZE?= =?utf-8?B?MjBIVjQvdllpS2tpWlpmaW1idVJaSndYNWpyYVQyb1N3aDVkeVVlNjl1TUw5?= =?utf-8?B?WU5FeUNGd0NKWW9VK2oxcnVDei9YYWtyUFhtZ1lpWjNGd0l1OHdjbUxYR3la?= =?utf-8?B?ZlhRT2MxYXlSVldBZUcxSnQ4Mmp6Qkd5K0NsVWdab09JWm9XNGJJaHp5cmNQ?= =?utf-8?Q?kQudYVBqsCB9wgGBQ1PnHvE=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 141c8b8b-2c7b-420e-0055-08d9f0a2bc07 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5514.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:46:38.2380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KPFPLITP6PB4T5NUmrBmotO0kDHYzJXB/Ul1kf8lOWlLxbP8kxceGGrqaz15Lx3Us57fRkiWFv1ps3sgk/aUFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1337 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10258 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202150098 X-Proofpoint-ORIG-GUID: UOOkjDSWa913O1c12ar-lxkAxqiMsBCC X-Proofpoint-GUID: UOOkjDSWa913O1c12ar-lxkAxqiMsBCC X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/14/2022 10:24 PM, Stephen Hemminger wrote: > On Mon, 14 Feb 2022 13:09:19 +0000 > Vipul Ashri wrote: > >> PORT 0 supports 16 rx queues and 16 tx queues (driver_name = net_failsafe, driver_type = 16) >> >> PORT 0 is polling for link-change, interrupts disabled >> >> [DPDK] tap_flow_create(): Kernel refused TC filter rule creation (17): File exists > Looks like secondary process support doesn't work with the flow rules logic. > Maybe after that you are into error paths that may not recover correctly?? Thanks! Stephen for looking at my analysis, yes some hotplug synchronization issue between eal_intr_thread and primary thread, but we are able to recover with this patch. Reason is this fail-safe flow is inside our custom added boot-time polling to update DPDK stats and calling ifindex ioctl to get interface data. Ideally we should not start polling so early. but moreover calling ifindex ioctl is generic functionality and should not break failsafe. We added this patch and gracefully prevented the so many multiple crashes. Setup details : Azure testbed with Accelerated Networking(SRIOV) enabled, failsafe using tap + mellanox driver. Warm Regards