From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 552FF43DA3 for ; Mon, 8 Apr 2024 15:14:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DE1E402C0; Mon, 8 Apr 2024 15:14:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 74F4240289 for ; Mon, 8 Apr 2024 15:13:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712582022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRzRHNdbvA9YcCyRhkzbcf/N/pNxWqE54zSJUW9/5RE=; b=eccI85KdK/vJMgei0j0IHW/2sg6qnNC4+Z6fhrPXbztQFepG7TJZExCtV9NJqpFF2OiLpM /0LZFWYaA3RtLnw6qj/a/PrxB1hmg9wqRTTh39XaKNCFtez0+kBEZAI467fijUw8Af0mYR YWKJiHKJ07zqwZncAdsnZyW8s48vnwg= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-8BrwEGZVPwClsQQOTsTCqg-1; Mon, 08 Apr 2024 09:12:19 -0400 X-MC-Unique: 8BrwEGZVPwClsQQOTsTCqg-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-43479131062so20936191cf.3 for ; Mon, 08 Apr 2024 06:12:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712581924; x=1713186724; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QRzRHNdbvA9YcCyRhkzbcf/N/pNxWqE54zSJUW9/5RE=; b=li0W7QWbkU4Zrd+gkbbVLsUW19mmKUrbS8vVtr2AZqaZZ/FKY5KXGuzNHWg8fRLqUj WGcmA208AZws10VZSZPA67PlBFpuWbKI+BsKk2pZ2hVoQKJlnQRc1boQ2Bg9ANTpa6Gn 3VPUSVK2+S/mDfV8GUY1VUBr7xlrpBWhOcn9WTPF+P2pwPZ5VpXVeRPOKn8Bz8WgpWsp nT9SOTLo1NgRXuRZEIVFEeyf6Oq4SObj5yyf1Qy6zoh1j52yg3+lXbTFEz5X4sh92Q/2 qpj0v2McNNrDr4KP7nw5ooQWEvWm0bjBkW4WYo0XlNhQTsPM5C1NNUC+irQW7URjwfwH q2ag== X-Forwarded-Encrypted: i=1; AJvYcCVLg5amu4zrCFWo1YDS+x85AbBiMpQ5FcwNgS9aItHmZZCrLWnJJW0sxhiGvo7QyETii3GrfvOW2BsuVXxT5ow= X-Gm-Message-State: AOJu0YwZSuTJ8F9cBoDlGzUVPUW89yfn6T3YQZUqQx6EpbrVtfOV1/bf faaAt6g1CSMLjvJ5mOdqYezyCpm18Ta4oYZ3L0pDB19n8PUEJSBz34/m/27PwIdAsJqmCG3Wkob tVljbyQ2LiKoS44xigPV2Lu6P+84WoVX1jWupJopkiL47 X-Received: by 2002:a05:622a:118b:b0:434:66f7:47a3 with SMTP id m11-20020a05622a118b00b0043466f747a3mr10028474qtk.61.1712581924650; Mon, 08 Apr 2024 06:12:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHn5h8OaMMDBQ4Sn/xHvn0n/1txfH4mYNaLj8b3tv4tuX03sHVR8CXwiz9hO7sDF9YuKGtAxA== X-Received: by 2002:a05:622a:118b:b0:434:66f7:47a3 with SMTP id m11-20020a05622a118b00b0043466f747a3mr10028452qtk.61.1712581924379; Mon, 08 Apr 2024 06:12:04 -0700 (PDT) Received: from [192.168.0.12] ([78.19.74.23]) by smtp.gmail.com with ESMTPSA id kr19-20020ac861d3000000b004347dd80b8asm1850739qtb.66.2024.04.08.06.12.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 06:12:03 -0700 (PDT) Message-ID: <9531ba96-d5e9-49aa-93da-823fc4c76549@redhat.com> Date: Mon, 8 Apr 2024 14:12:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v13 2/3] net/af_xdp: fix multi interface support for K8s To: "Loftus, Ciara" , "ferruh.yigit@amd.com" , "stephen@networkplumber.org" , "lihuisong@huawei.com" , "fengchengwen@huawei.com" , "liuyonglong@huawei.com" , "Marchand, David" , "Koikkara Reeny, Shibin" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20240404142326.2151118-1-mtahhan@redhat.com> <20240404142326.2151118-3-mtahhan@redhat.com> From: Maryam Tahhan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 08/04/2024 11:46, Loftus, Ciara wrote: >> +#ifdef ETH_AF_XDP_UPDATE_XSKMAP >> +static __rte_always_inline int >> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx >> __rte_unused) >> +{ >> + return xsk_socket__update_xskmap(xsk, map_fd); >> +} >> +#else >> +static __rte_always_inline int >> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx) >> +{ >> + int fd = xsk_socket__fd(xsk); > 'fd' computed here is not used in this function so generates an unused variable warning. Just for clarification on the fix - the 3rd argument to the bpf_map_update_elem() should be that xsk fd. So I will update the code to reflect this: ` return bpf_map_update_elem(map_fd, &xsk_queue_idx, &fd, 0);` Thanks again and great catch. BR Maryam >> + return bpf_map_update_elem(map_fd, &xsk_queue_idx, &map_fd, >> 0); >> +} >> +#endif >> +