From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D444A04FF for <public@inbox.dpdk.org>; Mon, 4 Apr 2022 12:33:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 313F74068C; Mon, 4 Apr 2022 12:33:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E35E042821 for <stable@dpdk.org>; Mon, 4 Apr 2022 12:33:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649068396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AEXauAOnAdurl9tdoOLaWttmHHs3HWkqjk2NImbZ5tM=; b=io8ZFetM4+bRp1flAqtBhnrCVN7zySGXrkQHNjAOW/TzqHck+58zU+GSeJMfTR4XNplKE2 8h565z4GMVrH8GGN3mjwRRVxVtSBuHQlD0WZeozqEn+/RNwgG/fctY05UZLg8xrCd04lS0 fKjiUyDo1puUXzxK17wJeMagcdd8txg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-JuCgCl3oM_KLnC_Mf2gNWw-1; Mon, 04 Apr 2022 06:33:15 -0400 X-MC-Unique: JuCgCl3oM_KLnC_Mf2gNWw-1 Received: by mail-wr1-f69.google.com with SMTP id v3-20020adf8b43000000b00205e463b017so1588177wra.10 for <stable@dpdk.org>; Mon, 04 Apr 2022 03:33:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=AEXauAOnAdurl9tdoOLaWttmHHs3HWkqjk2NImbZ5tM=; b=yYgbgT7MEoEZ7E6qKNPy3LxxDnSf2rSBmbpJT575d4CNMKiTp7K06FtVnQLTsAllcL 1/SEzBEgzLJIJzXQ3AV4m8qwRK1DfAK5Rb38mXqSbOMC8tLQwnXVeHB/TQG+GLPArGdR 7yb6+MkuXUz8RUIL4I7ImpomjkuXe06VWP/DvwITbmaltsQtM1Eu+WHkOyS0hwIphhig U4nzAmDANA6DWj0EaKoONe6i8LG7yKLx/KX0s7jihLI6/i9zjynCy7Om4NUmfQplTMT0 edX5TqcoWE5XF5PJU7zeDrBJNzBepIxBDRK/TcM8p5bsIdWHPjvTUXAIAByw+90hrBsp EKtA== X-Gm-Message-State: AOAM530DCjg9FhQ//3zlQ+5nYAQ3lBVytRF3QuhvCKxzRt8D/wbb+H7I rEBUBOlrHH9E0p4uR0aaLiZwRl2rsxBQ2IJEEeJi3/ELkKOs39vcsuXVxcX1jv8eqp8MGZF+tXk +4WfiVvU= X-Received: by 2002:a5d:598c:0:b0:205:a7ab:fe52 with SMTP id n12-20020a5d598c000000b00205a7abfe52mr16279142wri.411.1649068390725; Mon, 04 Apr 2022 03:33:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNni1xe+2OzrQ/6LN9PaOou5/GWqh9V8+9jcTmy+GkNq1J8SD0X4oafcI9HzoPDHNMVUMvgw== X-Received: by 2002:a5d:598c:0:b0:205:a7ab:fe52 with SMTP id n12-20020a5d598c000000b00205a7abfe52mr16279128wri.411.1649068390461; Mon, 04 Apr 2022 03:33:10 -0700 (PDT) Received: from [192.168.0.36] ([78.19.110.230]) by smtp.gmail.com with ESMTPSA id b1-20020adfd1c1000000b002058537af75sm9405221wrd.104.2022.04.04.03.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 03:33:09 -0700 (PDT) Message-ID: <95d923da-0216-9a66-2713-17f0a6442a0c@redhat.com> Date: Mon, 4 Apr 2022 11:33:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>, Ben Magistro <koncept1@gmail.com>, dev@dpdk.org Cc: ben.magistro@trinitycyber.com, stefan.baranoff@trinitycyber.com, stable@dpdk.org, Luca Boccassi <bluca@debian.org>, Christian Ehrhardt <christian.ehrhardt@canonical.com>, "Xueming(Steven) Li" <xuemingl@nvidia.com> References: <20220404005634.2657-1-koncept1@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35D86F9B@smartserver.smartshare.dk> From: Kevin Traynor <ktraynor@redhat.com> Subject: Re: [PATCH] mbuf: expose outer vlan in mbuf dump In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86F9B@smartserver.smartshare.dk> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org On 04/04/2022 07:15, Morten Brørup wrote: >> From: Ben Magistro [mailto:koncept1@gmail.com] >> Sent: Monday, 4 April 2022 02.57 >> >> Enable printing of the outer vlan if flags indicate it is present. >> >> Signed-off-by: Ben Magistro <koncept1@gmail.com> >> >> --- >> >> While troubleshooting some QinQ offloads with various Intel i40e >> firmware[1], it was >> helpful to expose the outer vlan in the dump mbuf calls. This should >> be straightforward >> to backport and happy to do the work if accepted. I understand that >> this may not be a >> widely supported capability at this time, so we are okay if this is not >> accepted and >> we just maintain a local patch. > > Features are usually not backported, only bug fixes. > > However, since this patch proved helpful finding a bug, and it is very simple, it could be considered by the LTS maintainers. > Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it is requested for stable branches. It will be caught by stable maintainer filters when it is time for backports and can be discussed further then. (Note, it would need small rebase for older than 21.11 LTS to account for the namespaces that were added) Kevin. >> >> --- >> lib/mbuf/rte_mbuf.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/mbuf/rte_mbuf.c b/lib/mbuf/rte_mbuf.c >> index 87592faccb..a2307cebe6 100644 >> --- a/lib/mbuf/rte_mbuf.c >> +++ b/lib/mbuf/rte_mbuf.c >> @@ -674,6 +674,9 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, >> unsigned dump_len) >> fprintf(f, " pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, >> port=%u", >> m->pkt_len, m->ol_flags, m->nb_segs, m->port); >> >> + if (m->ol_flags & (RTE_MBUF_F_RX_QINQ | RTE_MBUF_F_TX_QINQ)) >> + fprintf(f, ", vlan_tci_outer=%u", m->vlan_tci_outer); >> + >> if (m->ol_flags & (RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_TX_VLAN)) >> fprintf(f, ", vlan_tci=%u", m->vlan_tci); >> >> -- >> 2.27.0 >> > > Reviewed-by: Morten Brørup <mb@smartsharesystems.com> >