patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: stable@dpdk.org, Chao Zhu <chaozhu@linux.vnet.ibm.com>,
	Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Subject: [dpdk-stable] [PATCH 1/3] eal: access hugepage_file in reverse order for powerpc
Date: Thu, 21 Jun 2018 10:57:36 +0530	[thread overview]
Message-ID: <983aedd7fe86e9e085524b355688e9cb3ec64195.1527076172.git.gowrishankar.m@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1527076172.git.gowrishankar.m@linux.vnet.ibm.com>
In-Reply-To: <cover.1527076172.git.gowrishankar.m@linux.vnet.ibm.com>

From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>

In powerpc, secondary process has to read hugepage_files in
its reverse order of indexing, so that correct VA addr is
read from hp for hugepage mapping.

Fixes: 284ae3e9ff ("eal/ppc: fix mmap for memory initialization")
Cc: stable@dpdk.org

Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
---
 lib/librte_eal/linuxapp/eal/eal_memory.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index 16a181c..2dcb3b5 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -1455,7 +1455,11 @@ void numa_error(char *where)
 		/* find the hugepages for this segment and map them
 		 * we don't need to worry about order, as the server sorted the
 		 * entries before it did the second mmap of them */
+#ifdef RTE_ARCH_PPC_64
+		for (i = num_hp-1; i < num_hp && offset < mcfg->memseg[s].len; i--){
+#else
 		for (i = 0; i < num_hp && offset < mcfg->memseg[s].len; i++){
+#endif
 			if (hp[i].memseg_id == (int)s){
 				fd = open(hp[i].filepath, O_RDWR);
 				if (fd < 0) {
-- 
1.9.1

  parent reply	other threads:[~2018-06-21  5:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 12:53 [dpdk-stable] [PATCH 0/3] eal: clean up mapping hugepages in secondary process for ppc64le Gowrishankar
2018-06-21  5:27 ` Gowrishankar
2018-06-21  5:27 ` Gowrishankar [this message]
2018-06-21  5:27 ` [dpdk-stable] [PATCH 2/3] eal: reorder calling munmap on zero-mapped memory Gowrishankar
2018-06-21  5:27 ` [dpdk-stable] [PATCH 3/3] eal: reverse powerpc changes done for hugepage overcommit Gowrishankar
2018-06-21  8:50 ` [dpdk-stable] [PATCH 0/3] eal: clean up mapping hugepages in secondary process for ppc64le Luca Boccassi
2018-06-21  8:54   ` gowrishankar muthukrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=983aedd7fe86e9e085524b355688e9cb3ec64195.1527076172.git.gowrishankar.m@linux.vnet.ibm.com \
    --to=gowrishankar.m@linux.vnet.ibm.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).