From: "Morten Brørup" <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>,
"Mingjin Ye" <mingjinx.ye@intel.com>, <luca.boccassi@gmail.com>
Cc: <dev@dpdk.org>, <qiming.yang@intel.com>, <stable@dpdk.org>,
<yidingx.zhou@intel.com>, "Yuying Zhang" <Yuying.Zhang@intel.com>,
"Beilei Xing" <beilei.xing@intel.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Kevin Traynor" <ktraynor@redhat.com>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>
Subject: RE: [PATCH v3] net/i40e: support enable/disable source pruning
Date: Mon, 17 Apr 2023 13:09:57 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87886@smartserver.smartshare.dk> (raw)
In-Reply-To: <CAJFAV8zN-cEsHpzymmf-Y-CUUeQnK+GTNegTm4qdC0VXU+F0tw@mail.gmail.com>
> From: Morten Brørup
> Sent: Monday, 17 April 2023 12.02
Resent to Luca's other email address. The debian.org address could not be reached due to SPF problems. (Luca has been informed directly.)
>
> > From: David Marchand [mailto:david.marchand@redhat.com]
> > Sent: Monday, 17 April 2023 09.11
> >
> > On Mon, Apr 17, 2023 at 3:58 AM Mingjin Ye <mingjinx.ye@intel.com> wrote:
> > >
> > > VRRP advertisement packets are dropped on i40e PF device because
> > > when a MAC address is added to a device, packets originating from
> > > that MAC address are dropped.
> > > This patch adds a PMD specific API to enable/disable source
> > > pruning to fix above issue.
>
> Please amend the above sentence to mention that this patch changes the default
> behavior, e.g.:
>
> This patch fixes the bug by disabling source pruning by default, and adds a
> PMD specific API to enable/disable source pruning.
>
> > >
> > > Bugzilla ID: 648
> > >
> > > Fixes: 94b3c1a72507 ("net/i40e: move testpmd commands")
> > > Fixes: bce83974ba2c ("net/i40e: set Tx loopback from PF")
> > > Fixes: 96974a6600ec ("net/i40e: move private APIs to a specific file")
> > > Fixes: 689bba33272d ("i40e: add VEB switching support")
> > > Fixes: 440499cf5376 ("net/i40e: support floating VEB")
> > > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> >
> > I see this as a new feature.
>
> The main purpose of PMD change itself is to fix a bug (with low probability,
> but high impact if no workaround has been implemented in the application).
>
> Adding the new function to set the source pruning behavior makes the code
> readable.
>
> >
> > Please don't mark faulty any commit that touched this code (especially
> > the ones that only moved code around).
> > This is confusing.
> >
> >
> > > Cc: stable@dpdk.org
> >
> > Cc: stable maintainers.
> >
> > This commit changes the default behavior, with no way to return to the
> > old behavior (afaics).
> > Backporting it poses a risk of breaking existing applications.
>
> Correct, but it also fixes a bug that may go unnoticed in applications until
> they are deployed in networks where VRRP is used.
>
> The default behavior was extremely strange, and the new default behavior makes
> perfect sense.
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
> NB: I wanted to add some arguments in favor of this bugfix, which I consider
> important. Please do not ignore David's warnings!
next prev parent reply other threads:[~2023-04-17 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 1:51 Mingjin Ye
2023-04-17 7:10 ` David Marchand
2023-04-17 10:01 ` Morten Brørup
2023-04-17 11:09 ` Morten Brørup [this message]
2023-05-15 1:52 ` Zhang, Qi Z
-- strict thread matches above, loose matches on Subject: below --
2023-04-14 11:20 Mingjin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D87886@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Yuying.Zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ktraynor@redhat.com \
--cc=luca.boccassi@gmail.com \
--cc=mingjinx.ye@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).