RE: [PATCH v3 1/3] eal/unix: fix log message for madvise() failure

RE: [PATCH v3 1/3] eal/unix: fix log message for madvise() failure

[Morten Brørup]

> From: Morten Brørup
> Sent: Friday, 27 June 2025 19.51
> 
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Friday, 27 June 2025 19.34
> >
> > 27/06/2025 18:47, Morten Brørup:
> > > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > Sent: Friday, 27 June 2025 17.56
> > > >
> > > > 24/06/2025 10:03, Morten Brørup:
> > > > > In eal_mem_set_dump(), when madvise() failed, an incorrect
> reason
> > was
> > > > > logged.
> > > > >
> > > > > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > > > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > > >
> > > > We need to track the root cause with Fixes: please.
> > > >
> > >
> > > I already looked into it, and the bug was there from the initial
> > commit of this function:
> > >
> >
> https://git.dpdk.org/dpdk/commit/lib/librte_eal/unix/eal_unix_memory.c?i
> > d=c4b89ecb64eae773337f3b1367dd8b1f09737f2e
> >
> > If we don't track this origin in the commit log, it is difficult to
> > know.
> >
> > > I didn't think the Fixes tag was required if that was the case, but
> I
> > may have misunderstood this.
> >
> > Yes we must be explicit and add it.
> >
> > > Also, it's an insignificant bug, so no need to backport.
> >
> > A bug is a bug.
> > LTS maintainers or anyone maintaining his own branch will decide
> whether
> > to backport.
> >
> 
> OK. Thank you for clarifying, Thomas.

Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")