From: "Morten Brørup" <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Gage Eads" <gage.eads@intel.com>,
"Olivier Matz" <olivier.matz@6wind.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
"Bruce Richardson" <bruce.richardson@intel.com>
Subject: RE: [PATCH v3 09/18] stack: fix unaligned accesses on 128-bit
Date: Tue, 8 Jul 2025 17:41:46 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9FDA8@smartserver.smartshare.dk> (raw)
In-Reply-To: <20250708122823.3406288-10-david.marchand@redhat.com>
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Tuesday, 8 July 2025 14.28
>
> Fixes: 3340202f5954 ("stack: add lock-free implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> - struct rte_stack_lf_head old_head;
> + alignas(16) struct rte_stack_lf_head old_head;
I don't know if Bruce also commented on this one, like he did on patch 12/18; so at the risk of repeating something already mentioned...
If all uses of struct rte_stack_lf_head must be 16-byte aligned, better fix the root cause by aligning the type rather than every use of it.
Please add such a root cause fix to the 25.11 TODO list, like the alignment of the struct rte_mp_msg type.
next prev parent reply other threads:[~2025-07-08 15:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250619071037.37325-1-david.marchand@redhat.com>
2025-06-19 7:10 ` [PATCH 02/10] test/telemetry: fix test calling all commands David Marchand
2025-06-20 9:16 ` Bruce Richardson
2025-06-23 9:54 ` David Marchand
2025-06-19 7:10 ` [PATCH 04/10] eal: fix plugin dir walk David Marchand
2025-06-20 9:19 ` Bruce Richardson
2025-06-23 9:41 ` David Marchand
2025-06-19 7:10 ` [PATCH 05/10] cmdline: fix port list parsing David Marchand
2025-06-20 9:58 ` Bruce Richardson
2025-06-23 9:40 ` David Marchand
2025-06-23 10:41 ` Bruce Richardson
2025-06-19 7:10 ` [PATCH 06/10] cmdline: fix highest bit " David Marchand
2025-06-20 9:21 ` Bruce Richardson
2025-06-23 9:32 ` David Marchand
2025-06-19 7:10 ` [PATCH 07/10] tailq: fix cast macro for null pointer David Marchand
2025-06-20 9:23 ` Bruce Richardson
2025-06-19 7:10 ` [PATCH 08/10] hash: fix unaligned access in predictable RSS David Marchand
2025-06-19 7:10 ` [PATCH 09/10] stack: fix unaligned accesses on 128-bit David Marchand
[not found] ` <20250623135242.461965-1-david.marchand@redhat.com>
2025-06-23 13:52 ` [PATCH v2 02/10] test/telemetry: fix test calling all commands David Marchand
2025-06-24 15:59 ` Marat Khalili
2025-06-26 8:32 ` David Marchand
2025-06-26 9:51 ` Marat Khalili
2025-07-03 14:09 ` David Marchand
2025-07-03 15:08 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 04/10] eal: fix plugin dir walk David Marchand
2025-06-25 8:43 ` Marat Khalili
2025-07-03 14:27 ` David Marchand
2025-06-23 13:52 ` [PATCH v2 05/10] cmdline: fix port list parsing David Marchand
2025-06-23 14:00 ` Bruce Richardson
2025-06-26 9:32 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 06/10] cmdline: fix highest bit " David Marchand
2025-06-30 15:25 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 07/10] tailq: fix cast macro for null pointer David Marchand
2025-06-30 16:06 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 08/10] hash: fix unaligned access in predictable RSS David Marchand
2025-06-30 15:32 ` Bruce Richardson
2025-07-01 8:36 ` Konstantin Ananyev
2025-07-08 7:32 ` David Marchand
2025-07-08 17:58 ` Konstantin Ananyev
2025-06-23 13:52 ` [PATCH v2 09/10] stack: fix unaligned accesses on 128-bit David Marchand
2025-06-30 15:33 ` Bruce Richardson
[not found] ` <20250708122823.3406288-1-david.marchand@redhat.com>
2025-07-08 12:28 ` [PATCH v3 02/18] test/telemetry: fix test calling all commands David Marchand
2025-07-08 12:28 ` [PATCH v3 04/18] eal: fix plugin dir walk David Marchand
2025-07-08 12:28 ` [PATCH v3 05/18] cmdline: fix port list parsing David Marchand
2025-07-08 12:28 ` [PATCH v3 06/18] cmdline: fix highest bit " David Marchand
2025-07-08 12:28 ` [PATCH v3 07/18] tailq: fix cast macro for null pointer David Marchand
2025-07-08 12:28 ` [PATCH v3 08/18] hash: fix unaligned access in predictable RSS David Marchand
2025-07-08 12:35 ` Medvedkin, Vladimir
2025-07-08 12:28 ` [PATCH v3 09/18] stack: fix unaligned accesses on 128-bit David Marchand
2025-07-08 15:41 ` Morten Brørup [this message]
2025-07-08 12:28 ` [PATCH v3 13/18] graph: fix stats query with no node xstats David Marchand
2025-07-08 12:28 ` [PATCH v3 14/18] graph: fix unaligned access in stats David Marchand
2025-07-08 12:28 ` [PATCH v3 15/18] eventdev: fix listing timer adapters with telemetry David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9FDA8@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).