From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [DPDK 1/4] net/ixgbe: fix multi-queue mode check in SRIOV mode
Date: Tue, 7 Mar 2017 23:46:30 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810CED714@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1488930010-85539-1-git-send-email-jingjing.wu@intel.com>
resend by mistake, drop this.
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, March 8, 2017 7:40 AM
> To: qabuild <qabuild@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org
> Subject: [DPDK 1/4] net/ixgbe: fix multi-queue mode check in SRIOV mode
>
> In SRIOV case, ETH_MQ_RX_VMDQ_DCB and ETH_MQ_RX_DCB should be
> considered as the same meaning, due to the multi-queue mapping is the same
> SRIOV and VMDq in ixgbe.
>
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
>
> Cc: stable@dpdk.org
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 9502432..72327bc 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -4135,9 +4135,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
> break;
> }
> } else {
> - /*
> - * SRIOV active scheme
> - * Support RSS together with VMDq & SRIOV
> + /* SRIOV active scheme
> + * Support RSS together with SRIOV.
> */
> switch (dev->data->dev_conf.rxmode.mq_mode) {
> case ETH_MQ_RX_RSS:
> @@ -4145,10 +4144,13 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev
> *dev)
> ixgbe_config_vf_rss(dev);
> break;
> case ETH_MQ_RX_VMDQ_DCB:
> + case ETH_MQ_RX_DCB:
> + /* In SRIOV, the configuration is the same as VMDq case */
> ixgbe_vmdq_dcb_configure(dev);
> break;
> - /* FIXME if support DCB/RSS together with VMDq & SRIOV */
> + /* DCB/RSS together with SRIOV is not supported */
> case ETH_MQ_RX_VMDQ_DCB_RSS:
> + case ETH_MQ_RX_DCB_RSS:
> PMD_INIT_LOG(ERR,
> "Could not support DCB/RSS with VMDq &
> SRIOV");
> return -1;
> --
> 2.4.11
prev parent reply other threads:[~2017-03-07 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 23:40 Jingjing Wu
2017-03-07 23:40 ` [dpdk-stable] [DPDK 2/4] app/testpmd: fix init config for multi-queue mode Jingjing Wu
2017-03-07 23:46 ` Wu, Jingjing
2017-03-07 23:40 ` [dpdk-stable] [DPDK 3/4] app/testpmd: fix TC mapping in DCB init config Jingjing Wu
2017-03-07 23:47 ` Wu, Jingjing
2017-03-07 23:46 ` Wu, Jingjing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810CED714@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).