From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 9A67747CD;
 Tue, 25 Apr 2017 10:55:40 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 25 Apr 2017 01:55:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,248,1488873600"; d="scan'208";a="1123209869"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga001.jf.intel.com with ESMTP; 25 Apr 2017 01:55:39 -0700
Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Tue, 25 Apr 2017 01:55:38 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Tue, 25 Apr 2017 01:55:38 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002;
 Tue, 25 Apr 2017 16:55:26 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "Xing, Beilei" <beilei.xing@intel.com>, "Zhang, Qi" <qi.zhang@intel.com>, 
 "Iremonger, Bernard" <bernard.iremonger@intel.com>, "stable@dpdk.org"
 <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for
 QinQ	setup
Thread-Index: AQHSvOUM27w32iA/TUK2gCdwnubajqHVyRdw
Date: Tue, 25 Apr 2017 08:55:25 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810D4D1BD@SHSMSX103.ccr.corp.intel.com>
References: <1492701258-7968-1-git-send-email-bernard.iremonger@intel.com>
 <1493029477-27106-1-git-send-email-bernard.iremonger@intel.com>
In-Reply-To: <1493029477-27106-1-git-send-email-bernard.iremonger@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/testpmd: check port is
 stopped for QinQ	setup
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Apr 2017 08:55:41 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger
> Sent: Monday, April 24, 2017 6:25 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi <qi.zhang@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for Qin=
Q
> setup
>=20
> Check port is stopped before configuring it for QinQ, with the "vlan set =
qinq on
> <port_id>" command.
>=20
> The above command sets the hw_vlan_extend flag.
> When the port is started it calls the
> i40e_rx_vec_dev_conf_condition_check_default function to decide whether o=
r
> not to select the vector mode driver depending on the state of the
> hw_vlan_extend flag.
>=20
The command vlan set qinq on <port_id> is an common command, but not only
For i40e. I think it's better to doc it somewhere instead of changing the d=
efault
Behavior of this command.