patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: support non contiguous socket ids
Date: Tue, 9 May 2017 00:43:44 +0000	[thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D64D17@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <AM4PR05MB15051AB8F84C4E8C744A7B17C3EE0@AM4PR05MB1505.eurprd05.prod.outlook.com>

> 
> Right, i prefer the following though, what do you think?
> 
>        for (i = 0; i < RTE_MAX_LCORE; i++) {
>                 sock_num = rte_lcore_to_socket_id(i);
>                 if (new_socket_id(sock_num)) {
>                         if (num_sockets >= RTE_MAX_NUMA_NODES) {
>                                 rte_exit(EXIT_FAILURE,
>                                          "Total sockets greater than %u\n",
>                                          RTE_MAX_NUMA_NODES);
>                         }
>                         socket_ids[num_sockets++] = sock_num;
>                 }
> 
That looks good :)

> > One more thing, if this patch is fixing a bug, I think "fix" should be
> > added in title.
> 
> OK, I guess I can change the commit title and message.
> 
> BTW note that there is a V3 with Thomas requested changes.
> If we agree on above I can submit a v4 with the last updates.
> 
>
OK.
 
Thanks
Jingjing

  reply	other threads:[~2017-05-09  0:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 13:44 Shahaf Shuler
2017-05-06  1:41 ` Wu, Jingjing
2017-05-07  6:06   ` Shahaf Shuler
2017-05-08  0:54     ` Wu, Jingjing
2017-05-08 17:35       ` Shahaf Shuler
2017-05-09  0:43         ` Wu, Jingjing [this message]
2017-05-07 12:14 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2017-05-07 13:05 ` [dpdk-stable] [PATCH v3] " Shahaf Shuler
2017-05-09  7:28   ` [dpdk-stable] [PATCH v4] app/testpmd: fix mempool creation by socket id Shahaf Shuler
2017-05-09  8:54     ` Wu, Jingjing
2017-05-10 16:41       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BB6961774997848B5B42BEC655768F810D64D17@SHSMSX103.ccr.corp.intel.com \
    --to=jingjing.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).