From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 85AC323A; Tue, 24 Oct 2017 04:45:30 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 19:45:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,424,1503385200"; d="scan'208";a="1234409597" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2017 19:45:28 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Oct 2017 19:45:28 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Oct 2017 19:45:28 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 24 Oct 2017 10:45:26 +0800 From: "Wu, Jingjing" To: Shijith Thotton , "Yigit, Ferruh" CC: Gregory Etelson , Harish Patil , Thomas Monjalon , "dev@dpdk.org" , "stable@dpdk.org" , "Tan, Jianfeng" , George Prekas , "Gonzalez Monroy, Sergio" Thread-Topic: [PATCH] igb_uio: remove device reset in open Thread-Index: AQHTScQ94hltD399/UiquhN7Ucc586Lsb2wAgARrswCAAXVxwA== Date: Tue, 24 Oct 2017 02:45:25 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E9FC4A@SHSMSX103.ccr.corp.intel.com> References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> <20171023122807.GA17153@localhost.localdomain> In-Reply-To: <20171023122807.GA17153@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] igb_uio: remove device reset in open X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 02:45:31 -0000 > -----Original Message----- > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > Sent: Monday, October 23, 2017 8:28 PM > To: Yigit, Ferruh > Cc: Wu, Jingjing ; Gregory Etelson ; > Harish Patil ; Thomas Monjalon > ; dev@dpdk.org; stable@dpdk.org; Tan, Jianfeng > ; George Prekas ; Gonzalez > Monroy, Sergio > Subject: Re: [PATCH] igb_uio: remove device reset in open >=20 > On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote: > > On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > > Remove device reset during application start, the reset for > > > application exit still there. > > > > > > Reset in open removed because of following comments: > > > 1- Device reset not completed when VF driver loaded, which cause VF P= MD > > > initialization error. > > > Adding delay can solve the issue but will increase driver load tim= e. > > > > > > 2- Reset will be issues all devices unconditionally, not very efficie= nt > > > way. > > > > > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of > > > device file") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Ferruh Yigit > > > > Hi Jingjing, Shijith, Gregory, Harish, > > > > Can you please test this on top of current master (which has already > > Jingjin's > > fix) ? >=20 > Hi Ferruh, >=20 > Tested for LiquidIO cards and it works. >=20 > Thanks, > Shijith Hi, Ferruh For i40e, it's OK too. Thanks Jingjing