From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D481A0C41 for ; Mon, 6 Dec 2021 07:11:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 034A740040; Mon, 6 Dec 2021 07:11:22 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 5F47040040 for ; Mon, 6 Dec 2021 07:11:20 +0100 (CET) Received: from kwepemi100005.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4J6tNB4CVczbj5l; Mon, 6 Dec 2021 14:11:06 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by kwepemi100005.china.huawei.com (7.221.188.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 14:11:17 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 14:11:17 +0800 Message-ID: <9ad416cc-dd37-772c-9959-99a9bf2cb067@huawei.com> Date: Mon, 6 Dec 2021 14:11:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 20.11 V2 1/2] net/hns3: fix residual MAC after setting default MAC To: "Xueming(Steven) Li" , "stable@dpdk.org" CC: "fengchengwen@huawei.com" References: <20211113083412.20894-1-lihuisong@huawei.com> <20211113091753.31708-1-lihuisong@huawei.com> <20211113091753.31708-2-lihuisong@huawei.com> <51e73446d5611e014fe87104a90853e489a6680a.camel@nvidia.com> From: "lihuisong (C)" In-Reply-To: <51e73446d5611e014fe87104a90853e489a6680a.camel@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 在 2021/11/27 21:55, Xueming(Steven) Li 写道: > On Sat, 2021-11-13 at 17:17 +0800, Huisong Li wrote: >> [ upstream commit 19e67d8ebced5cb12829f75c70e6c497b5925e82 ] >> >> This problem occurs in the following scenarios: >> 1) reset is encountered when the adapter is running. >> 2) set a new default MAC address >> >> After the above two steps, the old default MAC address should be not >> take effect. But the current behavior is contrary to that. This is due >> to the change of the "default_addr_setted" in hw->mac from 'true' to >> 'false' after the reset. As a result, the old MAC address is not removed >> when the new default MAC address is set. This variable controls whether >> to delete the old default MAC address when setting the default MAC >> address. It is only used when the mac_addr_set API is called for the >> first time. In fact, when a unicast MAC address is deleted, if the >> address isn't in the MAC address table, the driver doesn't return >> failure. So this patch remove the redundant and troublesome variables to >> resolve this problem. >> >> Fixes: 7d7f9f80bbfb ("net/hns3: support MAC address related operations") >> >> Signed-off-by: Huisong Li >> Signed-off-by: Min Hu (Connor) >> --- > Applied to 20.11.4 list. > > One trailing tab removed, please run checkpatch next time :) ok，thanks😅 > > Best Regards, > Xueming Li