From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AFBA242E6C
	for <public@inbox.dpdk.org>; Fri, 14 Jul 2023 07:39:05 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9F0E94113F;
	Fri, 14 Jul 2023 07:39:05 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id DFFB240685;
 Fri, 14 Jul 2023 07:39:02 +0200 (CEST)
Received: from [192.168.1.36] (unknown [188.170.87.158])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 1849A50;
 Fri, 14 Jul 2023 08:39:01 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1849A50
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1689313141;
 bh=bUTl3xlDD5SenHvQQ2EPJz6lqb1rWPBsZdIwQMJxCOY=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=MJx59E4+vuhcTLgf3fCP96etK6iQkx8AnercQccCK459SLZ9GAhwj3IQmm1s3c4fA
 YZKGsMlkxl6Fj4DjhA6LKT1OTDzbZP2vUx8tLuoujfbjqD/e75zBgfiYcUKncsuXTY
 jQgfTGsCXQATbpPzsRfbDAGG+f47SJ8RYVOTRiFE=
Message-ID: <9c075a69-cb2e-3ca7-78ee-51aee51c0a6f@oktetlabs.ru>
Date: Fri, 14 Jul 2023 08:38:54 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow
 item parse
To: Ivan Malov <ivan.malov@arknetworks.am>, dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
 Artemii Morozov <artemii.morozov@arknetworks.am>, stable@dpdk.org
References: <20230713224002.5667-1-ivan.malov@arknetworks.am>
Content-Language: en-US
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20230713224002.5667-1-ivan.malov@arknetworks.am>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

On 7/14/23 01:40, Ivan Malov wrote:
> Such check is already done at an earlier point, in
> sfc_flow_parse_pattern(), so remove it from IPv4
> item parser. Doing so should fix Coverity issue.
> 
> Coverity issue: 395526
> Fixes: f79ce621e963 ("net/sfc: support IPv4 fragment matching in transfer rules")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>