From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>, dev@dpdk.org
Cc: rasland@nvidia.com, matan@nvidia.com, orika@nvidia.com,
thomas@monjalon.net, akozyrev@nvidia.com, stable@dpdk.org,
Kevin Traynor <ktraynor@redhat.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/2] net/mlx5: optimize inline mbuf freeing
Date: Wed, 27 Jan 2021 12:48:06 +0000 [thread overview]
Message-ID: <9d0d6047-9c72-2c98-8d01-88d6141f6fac@intel.com> (raw)
In-Reply-To: <de505791-707b-d6c8-67d7-dc080a6381fa@intel.com>
On 1/27/2021 12:44 PM, Ferruh Yigit wrote:
> On 1/22/2021 5:12 PM, Viacheslav Ovsiienko wrote:
>> The mlx5 PMD supports packet data inlining by pushing data
>> to the transmit descriptor. If packet is short enough and all
>> data are inline, the mbuf is not needed for data send anymore
>> and can be freed.
>>
>> The mbuf free was performed in the most inner loop building
>> the transmit descriptors. This patch postpones the mbuf free
>> transaction to the tx_burst routine exit, optimizing the loop
>> and allowing the bulk freeing for the multiple mbufs in single
>> pool API call.
>>
>> Cc: stable@dpdk.org
>>
>
> Hi Slava,
>
> This patch is optimization for inline mbufs, right, it is not a fix, should it
> be backported?
>
> cc'ed LTS maintainers.
>
cc'ed now.
> I am dropping the stable to for now in the next-net, can add it later based on
> discussion result.
>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>
next prev parent reply other threads:[~2021-01-27 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1608311697-31529-1-git-send-email-viacheslavo@nvidia.com>
2020-12-18 17:14 ` [dpdk-stable] [PATCH " Viacheslav Ovsiienko
[not found] ` <1609922063-13716-1-git-send-email-viacheslavo@nvidia.com>
2021-01-06 8:34 ` [dpdk-stable] [PATCH v2 " Viacheslav Ovsiienko
[not found] ` <1611335529-26503-1-git-send-email-viacheslavo@nvidia.com>
2021-01-22 17:12 ` [dpdk-stable] [PATCH v3 " Viacheslav Ovsiienko
2021-01-27 12:44 ` Ferruh Yigit
2021-01-27 12:48 ` Ferruh Yigit [this message]
2021-01-28 9:14 ` Slava Ovsiienko
2021-01-28 9:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d0d6047-9c72-2c98-8d01-88d6141f6fac@intel.com \
--to=ferruh.yigit@intel.com \
--cc=akozyrev@nvidia.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).