patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field
@ 2023-02-28 18:02 Ferruh Yigit
  2023-03-01 11:37 ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2023-02-28 18:02 UTC (permalink / raw)
  To: Thomas Monjalon, Andrew Rybchenko, Gowrishankar Muthukrishnan
  Cc: dev, stable, Bruce Richardson, Qi Zhang

'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
which is exposed via ehtdev stat APIs.

But telemetry exposes this field to user via "/ethdev/info",
instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".

Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs

Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Cc: gmuthukrishn@marvell.com
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>
---
 lib/ethdev/rte_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 0266cc82acb6..06f2c1ca001f 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6636,8 +6636,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
 	rte_tel_data_add_dict_int(d, "mtu", eth_dev->data->mtu);
 	rte_tel_data_add_dict_uint(d, "rx_mbuf_size_min",
 			eth_dev->data->min_rx_buf_size);
-	rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
-			eth_dev->data->rx_mbuf_alloc_failed);
 	rte_ether_format_addr(mac_addr, sizeof(mac_addr),
 			eth_dev->data->mac_addrs);
 	rte_tel_data_add_dict_string(d, "mac_addr", mac_addr);
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field
  2023-02-28 18:02 [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field Ferruh Yigit
@ 2023-03-01 11:37 ` Thomas Monjalon
  2023-03-01 14:08   ` Andrew Rybchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2023-03-01 11:37 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: Andrew Rybchenko, Gowrishankar Muthukrishnan, dev, stable,
	Bruce Richardson, Qi Zhang

28/02/2023 19:02, Ferruh Yigit:
> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
> which is exposed via ehtdev stat APIs.
> 
> But telemetry exposes this field to user via "/ethdev/info",
> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
> 
> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
> 
> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
> -	rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
> -			eth_dev->data->rx_mbuf_alloc_failed);

Good catch, thanks.

Acked-by: Thomas Monjalon <thomas@monjalon.net>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field
  2023-03-01 11:37 ` Thomas Monjalon
@ 2023-03-01 14:08   ` Andrew Rybchenko
  2023-03-02 15:27     ` Ferruh Yigit
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Rybchenko @ 2023-03-01 14:08 UTC (permalink / raw)
  To: Thomas Monjalon, Ferruh Yigit
  Cc: Gowrishankar Muthukrishnan, dev, stable, Bruce Richardson, Qi Zhang

On 3/1/23 14:37, Thomas Monjalon wrote:
> 28/02/2023 19:02, Ferruh Yigit:
>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
>> which is exposed via ehtdev stat APIs.
>>
>> But telemetry exposes this field to user via "/ethdev/info",
>> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>>
>> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>>
>> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> ---
>> -	rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
>> -			eth_dev->data->rx_mbuf_alloc_failed);
> 
> Good catch, thanks.
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field
  2023-03-01 14:08   ` Andrew Rybchenko
@ 2023-03-02 15:27     ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2023-03-02 15:27 UTC (permalink / raw)
  To: Andrew Rybchenko, Thomas Monjalon
  Cc: Gowrishankar Muthukrishnan, dev, stable, Bruce Richardson, Qi Zhang

On 3/1/2023 2:08 PM, Andrew Rybchenko wrote:
> On 3/1/23 14:37, Thomas Monjalon wrote:
>> 28/02/2023 19:02, Ferruh Yigit:
>>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
>>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
>>> which is exposed via ehtdev stat APIs.
>>>
>>> But telemetry exposes this field to user via "/ethdev/info",
>>> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>>>
>>> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>>>
>>> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>> ---
>>> -    rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
>>> -            eth_dev->data->rx_mbuf_alloc_failed);
>>
>> Good catch, thanks.
>>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> 


Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-03-02 15:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 18:02 [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field Ferruh Yigit
2023-03-01 11:37 ` Thomas Monjalon
2023-03-01 14:08   ` Andrew Rybchenko
2023-03-02 15:27     ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).