patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH v2] vhost: decrease log level for unimplemented requests
@ 2023-02-06 15:07 Maxime Coquelin
  2023-02-07  2:57 ` Xia, Chenbo
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Maxime Coquelin @ 2023-02-06 15:07 UTC (permalink / raw)
  To: dev, chenbo.xia, ktraynor, david.marchand; +Cc: Maxime Coquelin, stable

This patch changes VHOST_USER_SET_VRING_ERR and
VHOST_USER_SET_LOG_FD "not implemented" log levels from
INFO to DEBUG, as implementing these requests is not
mandatory. Having them being displayed at INFO level
may induce some confusion to the end-user.

Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")
Cc: stable@dpdk.org

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/vhost/vhost_user.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 8f33d5f4d9..551908df8e 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
 
 	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
 		close(ctx->fds[0]);
-	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
 
 	return RTE_VHOST_MSG_RESULT_OK;
 }
@@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
 		return RTE_VHOST_MSG_RESULT_ERR;
 
 	close(ctx->fds[0]);
-	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
 
 	return RTE_VHOST_MSG_RESULT_OK;
 }
-- 
2.39.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] vhost: decrease log level for unimplemented requests
  2023-02-06 15:07 [PATCH v2] vhost: decrease log level for unimplemented requests Maxime Coquelin
@ 2023-02-07  2:57 ` Xia, Chenbo
  2023-02-07 10:18 ` Kevin Traynor
  2023-02-09 12:13 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Xia, Chenbo @ 2023-02-07  2:57 UTC (permalink / raw)
  To: Maxime Coquelin, dev, ktraynor, david.marchand; +Cc: stable

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Monday, February 6, 2023 11:08 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; ktraynor@redhat.com;
> david.marchand@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; stable@dpdk.org
> Subject: [PATCH v2] vhost: decrease log level for unimplemented requests
> 
> This patch changes VHOST_USER_SET_VRING_ERR and
> VHOST_USER_SET_LOG_FD "not implemented" log levels from
> INFO to DEBUG, as implementing these requests is not
> mandatory. Having them being displayed at INFO level
> may induce some confusion to the end-user.
> 
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in
> functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  lib/vhost/vhost_user.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 8f33d5f4d9..551908df8e 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct
> virtio_net **pdev,
> 
>  	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
>  		close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
> 
>  	return RTE_VHOST_MSG_RESULT_OK;
>  }
> @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net
> **pdev,
>  		return RTE_VHOST_MSG_RESULT_ERR;
> 
>  	close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
> 
>  	return RTE_VHOST_MSG_RESULT_OK;
>  }
> --
> 2.39.1

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] vhost: decrease log level for unimplemented requests
  2023-02-06 15:07 [PATCH v2] vhost: decrease log level for unimplemented requests Maxime Coquelin
  2023-02-07  2:57 ` Xia, Chenbo
@ 2023-02-07 10:18 ` Kevin Traynor
  2023-02-09 12:13 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Kevin Traynor @ 2023-02-07 10:18 UTC (permalink / raw)
  To: Maxime Coquelin, dev, chenbo.xia, david.marchand; +Cc: stable

On 06/02/2023 15:07, Maxime Coquelin wrote:
> This patch changes VHOST_USER_SET_VRING_ERR and
> VHOST_USER_SET_LOG_FD "not implemented" log levels from
> INFO to DEBUG, as implementing these requests is not
> mandatory. Having them being displayed at INFO level
> may induce some confusion to the end-user.
> 
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>   lib/vhost/vhost_user.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 8f33d5f4d9..551908df8e 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
>   
>   	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
>   		close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
>   
>   	return RTE_VHOST_MSG_RESULT_OK;
>   }
> @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
>   		return RTE_VHOST_MSG_RESULT_ERR;
>   
>   	close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
>   
>   	return RTE_VHOST_MSG_RESULT_OK;
>   }

Acked-by: Kevin Traynor <ktraynor@redhat.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] vhost: decrease log level for unimplemented requests
  2023-02-06 15:07 [PATCH v2] vhost: decrease log level for unimplemented requests Maxime Coquelin
  2023-02-07  2:57 ` Xia, Chenbo
  2023-02-07 10:18 ` Kevin Traynor
@ 2023-02-09 12:13 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2023-02-09 12:13 UTC (permalink / raw)
  To: dev, chenbo.xia, ktraynor, david.marchand; +Cc: stable



On 2/6/23 16:07, Maxime Coquelin wrote:
> This patch changes VHOST_USER_SET_VRING_ERR and
> VHOST_USER_SET_LOG_FD "not implemented" log levels from
> INFO to DEBUG, as implementing these requests is not
> mandatory. Having them being displayed at INFO level
> may induce some confusion to the end-user.
> 
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>   lib/vhost/vhost_user.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 8f33d5f4d9..551908df8e 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
>   
>   	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
>   		close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
>   
>   	return RTE_VHOST_MSG_RESULT_OK;
>   }
> @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
>   		return RTE_VHOST_MSG_RESULT_ERR;
>   
>   	close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
>   
>   	return RTE_VHOST_MSG_RESULT_OK;
>   }


Applied to dpdk-next-virtio/main.

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-09 12:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-06 15:07 [PATCH v2] vhost: decrease log level for unimplemented requests Maxime Coquelin
2023-02-07  2:57 ` Xia, Chenbo
2023-02-07 10:18 ` Kevin Traynor
2023-02-09 12:13 ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).