patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] drivers: fix cnxk event qos devarg processing
@ 2022-05-20  7:11 Shijith Thotton
  2022-06-13  5:58 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Shijith Thotton @ 2022-05-20  7:11 UTC (permalink / raw)
  To: dev, jerinj; +Cc: Shijith Thotton, pbhagavatula, stable

Fixed qos parameters getting over written and IAQ/TAQ threshold
calculation.

Fixes: 910da32c53a9 ("event/cnxk: add device start")
Cc: stable@dpdk.org

Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
 drivers/common/cnxk/roc_sso.c      | 4 ++--
 drivers/event/cnxk/cnxk_eventdev.c | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c
index 358d37a9f2..8251c967fb 100644
--- a/drivers/common/cnxk/roc_sso.c
+++ b/drivers/common/cnxk/roc_sso.c
@@ -406,10 +406,10 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos,
 		}
 		req->grp = qos[i].hwgrp;
 		req->xaq_limit = (nb_xaq * (xaq_prcnt ? xaq_prcnt : 100)) / 100;
-		req->taq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK *
+		req->iaq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK *
 				(iaq_prcnt ? iaq_prcnt : 100)) /
 			       100;
-		req->iaq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK *
+		req->taq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK *
 				(taq_prcnt ? taq_prcnt : 100)) /
 			       100;
 	}
diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
index b66f241ef8..2455b7be2d 100644
--- a/drivers/event/cnxk/cnxk_eventdev.c
+++ b/drivers/event/cnxk/cnxk_eventdev.c
@@ -513,10 +513,10 @@ cnxk_sso_start(struct rte_eventdev *event_dev, cnxk_sso_hws_reset_t reset_fn,
 
 	plt_sso_dbg();
 	for (i = 0; i < dev->qos_queue_cnt; i++) {
-		qos->hwgrp = dev->qos_parse_data[i].queue;
-		qos->iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt;
-		qos->taq_prcnt = dev->qos_parse_data[i].taq_prcnt;
-		qos->xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt;
+		qos[i].hwgrp = dev->qos_parse_data[i].queue;
+		qos[i].iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt;
+		qos[i].taq_prcnt = dev->qos_parse_data[i].taq_prcnt;
+		qos[i].xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt;
 	}
 	rc = roc_sso_hwgrp_qos_config(&dev->sso, qos, dev->qos_queue_cnt,
 				      dev->xae_cnt);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: fix cnxk event qos devarg processing
  2022-05-20  7:11 [PATCH] drivers: fix cnxk event qos devarg processing Shijith Thotton
@ 2022-06-13  5:58 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-06-13  5:58 UTC (permalink / raw)
  To: Shijith Thotton; +Cc: dpdk-dev, Jerin Jacob, Pavan Nikhilesh, dpdk stable

On Fri, May 20, 2022 at 12:41 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> Fixed qos parameters getting over written and IAQ/TAQ threshold
> calculation.
>
> Fixes: 910da32c53a9 ("event/cnxk: add device start")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>

Applied to dpdk-next-net-eventdev/for-main. Thanks


> ---
>  drivers/common/cnxk/roc_sso.c      | 4 ++--
>  drivers/event/cnxk/cnxk_eventdev.c | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c
> index 358d37a9f2..8251c967fb 100644
> --- a/drivers/common/cnxk/roc_sso.c
> +++ b/drivers/common/cnxk/roc_sso.c
> @@ -406,10 +406,10 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos,
>                 }
>                 req->grp = qos[i].hwgrp;
>                 req->xaq_limit = (nb_xaq * (xaq_prcnt ? xaq_prcnt : 100)) / 100;
> -               req->taq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK *
> +               req->iaq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK *
>                                 (iaq_prcnt ? iaq_prcnt : 100)) /
>                                100;
> -               req->iaq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK *
> +               req->taq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK *
>                                 (taq_prcnt ? taq_prcnt : 100)) /
>                                100;
>         }
> diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
> index b66f241ef8..2455b7be2d 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.c
> +++ b/drivers/event/cnxk/cnxk_eventdev.c
> @@ -513,10 +513,10 @@ cnxk_sso_start(struct rte_eventdev *event_dev, cnxk_sso_hws_reset_t reset_fn,
>
>         plt_sso_dbg();
>         for (i = 0; i < dev->qos_queue_cnt; i++) {
> -               qos->hwgrp = dev->qos_parse_data[i].queue;
> -               qos->iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt;
> -               qos->taq_prcnt = dev->qos_parse_data[i].taq_prcnt;
> -               qos->xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt;
> +               qos[i].hwgrp = dev->qos_parse_data[i].queue;
> +               qos[i].iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt;
> +               qos[i].taq_prcnt = dev->qos_parse_data[i].taq_prcnt;
> +               qos[i].xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt;
>         }
>         rc = roc_sso_hwgrp_qos_config(&dev->sso, qos, dev->qos_queue_cnt,
>                                       dev->xae_cnt);
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-13  5:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-20  7:11 [PATCH] drivers: fix cnxk event qos devarg processing Shijith Thotton
2022-06-13  5:58 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).