* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue
[not found] <20180710103727.209243-1-shaopeng.he@intel.com>
@ 2018-07-25 18:19 ` Kevin Traynor
0 siblings, 0 replies; only message in thread
From: Kevin Traynor @ 2018-07-25 18:19 UTC (permalink / raw)
To: Shaopeng He, dev; +Cc: qi.z.zhang, stable
On 07/10/2018 11:37 AM, Shaopeng He wrote:
> Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats
> mbuf fast free offloading as No-simple, which is classified as simple tx
> in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue
> setup fail after queue was stopped. This patch fixes this bug.
>
> Fixes: 399421100e08 ("net/i40e: fix missing mbuf fast free offload")
Is it missing Cc: stable@dpdk.org tag for 18.05 stable branch?
>
> Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index 6032d5541..2bbb82fc3 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -2087,7 +2087,7 @@ i40e_dev_tx_queue_setup_runtime(struct rte_eth_dev *dev,
> }
> /* check simple tx conflict */
> if (ad->tx_simple_allowed) {
> - if (txq->offloads != 0 ||
> + if ((txq->offloads & ~DEV_TX_OFFLOAD_MBUF_FAST_FREE) != 0 ||
> txq->tx_rs_thresh < RTE_PMD_I40E_TX_MAX_BURST) {
> PMD_DRV_LOG(ERR, "No-simple tx is required.");
> return -EINVAL;
>
^ permalink raw reply [flat|nested] only message in thread