From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DCCF11077; Thu, 27 Apr 2017 12:00:56 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ADDC18048F; Thu, 27 Apr 2017 10:00:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ADDC18048F Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com ADDC18048F Received: from [10.36.112.43] (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C45F9946D; Thu, 27 Apr 2017 10:00:54 +0000 (UTC) To: Zhiyong Yang , dev@dpdk.org Cc: yuanhan.liu@linux.intel.com, ciara.loftus@intel.com, stable@dpdk.org References: <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com> <1493286083-53632-1-git-send-email-zhiyong.yang@intel.com> From: Maxime Coquelin Message-ID: <9dd4408d-0d01-5e44-06e9-8dca15bf18f8@redhat.com> Date: Thu, 27 Apr 2017 12:00:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <1493286083-53632-1-git-send-email-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 27 Apr 2017 10:00:55 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 10:00:57 -0000 On 04/27/2017 11:41 AM, Zhiyong Yang wrote: > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > new connection when negotiating to set MQ. (one queue pair works > well). > Because there exist some bugs in qemu code when introducing > VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the vhost > message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed > doesn't send the messge (The message needs to be sent only once)but > still will be waiting for dpdk's reply ack, then, qemu is always > freezing. DPDK code indeed works in the right way. > The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled > by default at the dpdk side in order to avoid the feature support of > DPDK + qemu at the same time. if doing like that, MQ can works well. > > Cc: stable@dpdk.org > > Reported-by: Ciara Loftus > Signed-off-by: Zhiyong Yang > Tested-by: Ciara Loftus > --- > > changes in V2 > 1. modify "workaround" instead of "fix" in the title. > 2. add a simple comment suggested by yuanhan > > lib/librte_vhost/vhost_user.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime