patches for DPDK stable branches
 help / color / Atom feed
From: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] rte_sched: correctly free allocated subport memory
Date: Sat, 30 May 2020 10:05:37 +0200
Message-ID: <9e7ac418-f06a-3e3e-8883-c41d543f2755@zg.ht.hr> (raw)
In-Reply-To: <BN6PR11MB0067EE4B213113FDEFABFDA1E0B10@BN6PR11MB0067.namprd11.prod.outlook.com>

On 27. 05. 2020. 13:48, Singh, Jasvinder wrote:
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Hrvoje Habjanic
>> Sent: Tuesday, May 26, 2020 6:25 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] rte_sched: correctly free allocated subport
>> memory
>>
>> In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line 865),
>> there is code to free all allocated stuff related to scheduler subport. First
>> there are some checks, and in the end, rte_bitmap_free is called.
>>
>> Now, rte_bitmap_free is a dummy function, and it just checks if provided
>> pointer to bitmap is valid or not. So, actual memory for subport is not freed.
>>
>> This patch fixes this by removing call to rte_bitmap_free, and instead calling
>> rte_free.
>>
>> Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
>> ---
>>  lib/librte_sched/rte_sched.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index
>> c0983ddda..f15a3b515 100644
>> --- a/lib/librte_sched/rte_sched.c
>> +++ b/lib/librte_sched/rte_sched.c
>> @@ -888,7 +888,7 @@ rte_sched_subport_free(struct rte_sched_port *port,
>>  		}
>>  	}
>>
>> -	rte_bitmap_free(subport->bmp);
>> +	rte_free(subport);
>>  }
>>
>>  void
>> --
>> 2.17.1
> Hi Hrvoje;
>
> I guess this is your first patch to dpdk.org, here are some suggestions when you send bug fixes;

Yes, it is.

>
> - When sending fixes, please use "fix" word in the subject line, e.g- rte_sched: fix subport memory leak
> - The commit message should include commit id corresponding to the line that you fixes as shown below for this case. 
>    Fixes: d9213b829a31 ("sched: remove pipe params config from port level")

OK, noted, thank you.

> Patch looks good to me.

Great.

As s side note, it would be nice if this could be backported to 19.11 LTS.

Regards,

H.

>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
>

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200526172455.6457-1-hrvoje.habjanic@zg.ht.hr>
2020-05-27 11:48 ` Singh, Jasvinder
2020-05-30  8:05   ` Hrvoje Habjanic [this message]
2020-06-24 22:47     ` Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e7ac418-f06a-3e3e-8883-c41d543f2755@zg.ht.hr \
    --to=hrvoje.habjanic@zg.ht.hr \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox