patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array
@ 2020-12-20 22:47 Rahul Lakkireddy
  2020-12-23  6:07 ` Li, Xiaoyun
  0 siblings, 1 reply; 3+ messages in thread
From: Rahul Lakkireddy @ 2020-12-20 22:47 UTC (permalink / raw)
  To: dev; +Cc: kaara.satwik, stable

From: Karra Satwik <kaara.satwik@chelsio.com>

Start from index 0 when going through the FEC array. This will allow
"off" to get printed for RTE_ETH_FEC_NOFEC mode.

Fixes: b19da32e3151 ("app/testpmd: add FEC command")
Cc: stable@dpdk.org

Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 3f6c8642b..a6a5baa4e 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3701,7 +3701,7 @@ show_fec_capability(unsigned int num, struct rte_eth_fec_capa *speed_fec_capa)
 		printf("%s : ",
 			rte_eth_link_speed_to_str(speed_fec_capa[i].speed));
 
-		for (j = RTE_ETH_FEC_AUTO; j < RTE_DIM(fec_mode_name); j++) {
+		for (j = 0; j < RTE_DIM(fec_mode_name); j++) {
 			if (RTE_ETH_FEC_MODE_TO_CAPA(j) &
 						speed_fec_capa[i].capa)
 				printf("%s ", fec_mode_name[j].name);
-- 
2.24.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array
  2020-12-20 22:47 [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array Rahul Lakkireddy
@ 2020-12-23  6:07 ` Li, Xiaoyun
  2021-01-15 13:53   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Li, Xiaoyun @ 2020-12-23  6:07 UTC (permalink / raw)
  To: Rahul Lakkireddy, dev; +Cc: kaara.satwik, stable

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Rahul Lakkireddy
> Sent: Monday, December 21, 2020 06:47
> To: dev@dpdk.org
> Cc: kaara.satwik@chelsio.com; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC
> array
> 
> From: Karra Satwik <kaara.satwik@chelsio.com>
> 
> Start from index 0 when going through the FEC array. This will allow "off" to get
> printed for RTE_ETH_FEC_NOFEC mode.
> 
> Fixes: b19da32e3151 ("app/testpmd: add FEC command")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> ---
>  app/test-pmd/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 3f6c8642b..a6a5baa4e 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -3701,7 +3701,7 @@ show_fec_capability(unsigned int num, struct
> rte_eth_fec_capa *speed_fec_capa)
>  		printf("%s : ",
>  			rte_eth_link_speed_to_str(speed_fec_capa[i].speed));
> 
> -		for (j = RTE_ETH_FEC_AUTO; j < RTE_DIM(fec_mode_name);
> j++) {
> +		for (j = 0; j < RTE_DIM(fec_mode_name); j++) {
>  			if (RTE_ETH_FEC_MODE_TO_CAPA(j) &
>  						speed_fec_capa[i].capa)
>  				printf("%s ", fec_mode_name[j].name);
> --
> 2.24.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array
  2020-12-23  6:07 ` Li, Xiaoyun
@ 2021-01-15 13:53   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2021-01-15 13:53 UTC (permalink / raw)
  To: Li, Xiaoyun, Rahul Lakkireddy, dev; +Cc: kaara.satwik, stable

On 12/23/2020 6:07 AM, Li, Xiaoyun wrote:

>> -----Original Message-----
>> From: stable <stable-bounces@dpdk.org> On Behalf Of Rahul Lakkireddy
>> Sent: Monday, December 21, 2020 06:47
>> To: dev@dpdk.org
>> Cc: kaara.satwik@chelsio.com; stable@dpdk.org
>> Subject: [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC
>> array
>>
>> From: Karra Satwik <kaara.satwik@chelsio.com>
>>
>> Start from index 0 when going through the FEC array. This will allow "off" to get
>> printed for RTE_ETH_FEC_NOFEC mode.
>>
>> Fixes: b19da32e3151 ("app/testpmd: add FEC command")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com>
>> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
 >
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-15 13:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-20 22:47 [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array Rahul Lakkireddy
2020-12-23  6:07 ` Li, Xiaoyun
2021-01-15 13:53   ` Ferruh Yigit

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git