From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43F5B425E1 for ; Mon, 18 Sep 2023 20:02:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3856340633; Mon, 18 Sep 2023 20:02:47 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2048.outbound.protection.outlook.com [40.107.212.48]) by mails.dpdk.org (Postfix) with ESMTP id 95E724025D; Mon, 18 Sep 2023 20:02:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZsKmvjIMQv5LnEt0Wr8GtlPM13DMazdJV3G/0aiiyZaVKfrgB7ItbIaZ01fkLwfkusntAY6mNb3GDlY1HwBCWrjqc6UXBnIvpovNWkmgmDDXCxRpI6g0J12gDXnFe+y/Ml/ZnyU96WmAWyOfRw39ziJlTojDUf13pY33WjnLkpTZPm3yKf/KfRbL0+q/9WDhsGHIThWu/BhhBAJpOMuUCSiacCmQKZt2f62qNAbRFo7q+fftYxsVeAsHfGser5eSA8zeglySwb056c0Q1DxB1Sm9V9nuavCX/EUJen/jkng4mXiztLh2+yVm1NkozIsKDYR0PXszqA/MBl/8c1IXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kL/K55yJNrPJZMj+ZBzyguYECPfQsBddLTeda9jEsQI=; b=WS/Omb74SfjLlmy3Im7yRhBgWTTeL8wiuIKVwZOIe1VyunBfE60UhbwBrHWdDj/lbYTxSD7xYAZjo26K5sRwTH1y5jcAZzJ/X8m7onu86PiOuDhSZQUcjdt8hjcMx5g/nfdgnAz7Fn7Kd32ivGOcwQIO+GDV0C0XxUT9US54bcRIRgcH+IOyuwfDDbrQUgs4b/ORBAbkVoRyajvZkYLzQHeh+8+o5imsrKqwhLspyLtcszkjo6Qn4PaYOPUs6Fip2jLAMJPayAs+XN0q9odQiLpTtw/6cwWbVmsN/lqzerxGasyfJRFvCkKg65dVdmaj4J1JCyvCQw/oDL2Pg5TP/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kL/K55yJNrPJZMj+ZBzyguYECPfQsBddLTeda9jEsQI=; b=HtYp3isKeeARWfavrlU0qpswwj8aNDr1MATaAtpgayGrFFsUGvPdn4uT+EhFq/R1bcoeduAGAKXjhqHwrs/m1EIOhQDeeQXpDLJwxgj1uGiKWg19VK2SBfptFVFZKRGBcBBenRsk+XAcb9oKv8fkuN7v25eZooimpm0ugQv/t5s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB8793.namprd12.prod.outlook.com (2603:10b6:510:27a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Mon, 18 Sep 2023 18:02:40 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 18:02:38 +0000 Message-ID: <9f6cc71e-b5d3-4d9f-9ca8-37baf839017e@amd.com> Date: Mon, 18 Sep 2023 19:02:30 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] net/mana: add 32 bit short doorbell Content-Language: en-US To: Wei Hu , dev@dpdk.org, Long Li Cc: stable@dpdk.org, Kevin Traynor , Luca Boccassi References: <20230909122347.2043969-1-weh@microsoft.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230909122347.2043969-1-weh@microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::36) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB8793:EE_ X-MS-Office365-Filtering-Correlation-Id: 6bd1f250-af94-4a79-0029-08dbb8717196 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9CYlBO9DxttBCZIVXHFnlD4JElZoPhN1VhxIbksmzfdwZwbaZeGt3OCUveSa4OhRqJpNGhyfYP/CoDCkmn+9655dRQz3BPQZ7AV5WoT2G4DJgpEc/wBP18L1rvhChtTIo/BG92aWGO681zxFK6EzbPbAibnAO8LxoSwiadEeYrX6Ym99VpiQyrq79K7w4f8uMFRU8Ue+MClF9IsQnU4349ZvxF9xqkGMZ6c61z/cXB+1hdrdM+7jhfvHQXRyJ8UIL8MWGX+LRQlcjGxgR213KcaUb3/ANHreznegXCMNY4CqTn7K9jA/aINXimZ2Krv3a4J75W3dwEw0P37+qOgTAJgXH25mjvq8ptHEgMAZ2eU3ZAyQZyLLvzIjydskMQd5jFUmQgsW2H/WUhJ/Vf+W+1W+sUBb/ZJdGH1sGTVjrF1y8+xZMamjlaS9ibo561fvjIYmc3C1lHMpR4bTtuWfYsmELOOW5C6J2zWXSKqLqCe4pcbrTt4o/M1WfwxJ9tJT1RJq+JNpnF8lHWPlfJAAv3RntDoTReB4xjhAL3JA9WNvVr83wpYu/LYoHhabVueZEzBf0S6nRIAfDncq753Kj/MbBPw2B0eUG24X+f9ttQQXThAfuxcZ6H1NA9nLoz7KLFx9upuZUW8MZ4Ae/80nBA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(366004)(136003)(346002)(396003)(1800799009)(451199024)(186009)(6506007)(6486002)(6512007)(53546011)(2906002)(26005)(2616005)(5660300002)(38100700002)(4326008)(36756003)(54906003)(66946007)(41300700001)(66476007)(110136005)(66556008)(316002)(8936002)(8676002)(6666004)(44832011)(45080400002)(478600001)(83380400001)(86362001)(31696002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTBMRTU1c0hySStCZGtnTDJkdDVOZlJOUXVSOHpxYmpNWVh0SXFOQ0IyM0Zj?= =?utf-8?B?bnBzVUtuMHl3KzVsci9ZdTJaUy9XeTN5U3NGTDAwWm5Ea2lIQ1hVdURJODdD?= =?utf-8?B?bmlsZ0FxZzlVZFlid2tncWlsaWpDVVBVN0pmbTZrVGh0a3ZJcHBQL0ZoQURk?= =?utf-8?B?L2ZidUFIcS9JUS9mdkVWZ0pwdk1rMGc0WWNDZWs0OHRkcEZQdXUvdTBOUS85?= =?utf-8?B?NmcrYzRPS2J4S1BpWnhZR2Z4c1dubEV0c3BTRFVwMm5IQ2RkU0dXbzE2MmU1?= =?utf-8?B?N3VVRGhPRVhsUlZnMkFjUEJBVUZnMlZjbUJ3dS9UaUFldStOYWtHVWhmaE0w?= =?utf-8?B?VWxBQldSb1l5bjBQMHJ2T1RjQjJjSmdpekpNUXNka3EvSDBoaVcwdEdyMXp3?= =?utf-8?B?Sm1seVhIbFdYblB0NEQ2WVdNMXpmNmNKSnQwaUxnVU9GRndQeHBJNmk0b0dG?= =?utf-8?B?TFI3ZVpNRkttd0FESkVOYjkvcTVCYkJnUGRXaThSOTZLL2YvWFZJQkhLbkcw?= =?utf-8?B?QjdjQ3NMQlBoTW02MTAzaGo3K3F6S1FrWFUzdGF4aElXY3BtNnBoWjVObjdw?= =?utf-8?B?RnNBbklid0NsRW80eWl5YldUYkpMbTlQaHNZeEdacnpPTHd1UFN0SGNZa212?= =?utf-8?B?a05JRjEvaHJ6RUJPQVRTdnhjTkVmSmFqdm4vanNVSm00SXlqQmdjeUp5V1Ju?= =?utf-8?B?cmNXMmxRWGFhWnM1Wmg3N1F0WDM5Vi80L2NDMzNxSlJwSEttbTVnNHNGZHBI?= =?utf-8?B?UzJ1V09SMFFiSGE2ZWNqMEFrV0tKS3B1R0Fma05zWG9FNzJnK3FRbDNZRld2?= =?utf-8?B?WkI4Y2FaTVVzZ2NudUVpQTFlR1lCcXI0K0FKYjBnRmJXZmZhVmt3VjFIVG4v?= =?utf-8?B?RGRlQ2xKSjhYdjZiNFVuaGZsUk9ZYzYyam5peE55V241bmVNZk5vOVFkZCsw?= =?utf-8?B?VHVGbllwZlcxcnhMeWpmQU9YMVpXa2lVclBFbjNQSmxMR1BnYVV3S2RQZFky?= =?utf-8?B?QVlKTXlIU28yNkR6cWgyaUNJL0REYnd4dUFHUVlKVERYZ0hCSEpsdkN0dWxr?= =?utf-8?B?M2s2aWhsTzYzbi9TOWJYa0xud1E5SUFUcXk3ZUhsYUJNRTJpMHYrZkx2SEZO?= =?utf-8?B?dEgyd1FJdTRqb1JpZ2pza2lNWTVzVkV5MERCTldXUDBhRXV2d2hhOFFLU0hv?= =?utf-8?B?Tm9ZTlJIZzZGWVpyeTg3YXV6aGR2OUR2dEZ0SGtURDR0R09ZQnRUUjlUeXMx?= =?utf-8?B?dzZpNnU2amFlUjZJL2F4RGZyTzZqV0R0QkhZdjQybUFXTjFsaEZXMkZpL2Ex?= =?utf-8?B?VXludHBTRlgrVGMxc0dycFZaUERPQ1NvOEIyU2xXWmdaVlN2TkNSOW5QSzhs?= =?utf-8?B?ZkVxcEdhN1RiUlRrM2Y0OU8wN3RucENJSFh0WDlHSHU1NzZxVDR6S1A0NzVT?= =?utf-8?B?Z051cTAxYnNjMmNZdWRLbkJwU2Q0WkI3Rjl2YTFQMzlBamRIV3E4MW5JT2x3?= =?utf-8?B?cDhodmJGUFVVTFpsd0xHSFAzZHZUSzNaR2JaU0dBNGhWcmxPNHBhcUdKek9J?= =?utf-8?B?dlhFa3NZa0R2YTZjODdaUlZMME9Pa1ZVT2s3bnpHUDJtTnR0TTVSNkVGb3A0?= =?utf-8?B?UmxjQ1JrVXlhUGx0d0lZVFZjbjJNQW5TVUpsU0lVL2VIZisxc1lwZEVaT2dK?= =?utf-8?B?Yy8xUm93SzhTUHpNUzJ6Mjh6bm9veGY2SWVoMWExUXVJR3ZtRkpVTmRHRkxK?= =?utf-8?B?OWdNY3FwaXVzS1FVcUYzZHJFc05aMW10dFp2ZXRJNVcxR2M5Q2gwSjh3T0FT?= =?utf-8?B?bVNnT3JhM3FLNW5MS1FjdTBXaFRVd0lSVUhHaWpIeHNaZzUvczE3TGUvY1Vv?= =?utf-8?B?NXBYUUxoa0RUUEtCVTI1ZTlVQ0RlYXkzb0dlSVNiOFp3bStjdXZVd1V0Y0xL?= =?utf-8?B?S21UVEF3c3NiTmF1eEFJTitVb0MwK3I4WFVEK05WUHVWNWdQM0ZucTBubDcr?= =?utf-8?B?eDJ3d2RmSlo1bE02YTJ4eEFSTHhkSXJwT2gwVkxUNUNpSnZkL0dCWUFsci9y?= =?utf-8?B?UDZNQlhIS0FOVE5oMWFWL21uWkxCUS9nOWlMam1vMDM2Yi9YQk4vMk03eEdo?= =?utf-8?Q?Jo8IvNaZ0P1KD0jytE9Lj692t?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bd1f250-af94-4a79-0029-08dbb8717196 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 18:02:38.0856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ed3UZ+/NUq8GP03fqhec66Zx5vtsPnYSe3kQfSb+sChhAKui39+vKyU4tkzI4DGZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8793 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 9/9/2023 1:23 PM, Wei Hu wrote: > Add 32 bit short doorbell support. Ring short doorbell when running > in 32 bit applicactions. > Hi Wei, Is this performance improvement for 32 bit, or is short doorbell support required for 32 bit support? This patch is using RTE_ARCH_32 compile time macro to enable short doorbell support, so need to decide to support 32 bit or 64 bit in compile time. Also I guess 32 bit driver can run on 64 bit arch, what will be the result in that case? My point is, instead of using compile time flag, what do you think to detect execution platform on runtime and use preferred doorbell according platform? I can see short descriptor support touches multiple functions, can the support be abstracted to let to use it based on runtime detection? > Cc: stable@dpdk.org > Similar comment as previous patch, this patch is not a fix but adding new support, not sure about backporting it. > Signed-off-by: Wei Hu > <...> > @@ -97,6 +110,7 @@ mana_alloc_and_post_rx_wqe(struct mana_rxq *rxq) > /* update queue for tracking pending packets */ > desc->pkt = mbuf; > desc->wqe_size_in_bu = wqe_size_in_bu; > + rxq->wqe_cnt_to_short_db += wqe_size_in_bu; > This variable always used within RTE_ARCH_32 block, but set here without RTE_ARCH_32 ifdef, is this intentional?