From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 05BCE1B76B;
Fri, 13 Oct 2017 23:38:25 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
13 Oct 2017 14:38:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,372,1503385200"; d="scan'208";a="909770672"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.248])
([10.241.224.248])
by FMSMGA003.fm.intel.com with ESMTP; 13 Oct 2017 14:38:23 -0700
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>, jianfeng.tan@intel.com,
shijith.thotton@caviumnetworks.com, gregory@weka.io, beilei.xing@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
References: <1507581083-33667-1-git-send-email-jingjing.wu@intel.com>
<1507581083-33667-2-git-send-email-jingjing.wu@intel.com>
<95051c86-9088-19a7-99f8-27eb1d8b525c@intel.com>
Message-ID: <9fed30ed-fc1b-2fe4-59e8-106b549eebab@intel.com>
Date: Fri, 13 Oct 2017 22:38:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <95051c86-9088-19a7-99f8-27eb1d8b525c@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH 2/2] igb_uio: fix interrupt enablement
after FLR in VM
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2017 21:38:26 -0000
On 10/13/2017 9:54 PM, Ferruh Yigit wrote:
> On 10/9/2017 9:31 PM, Jingjing Wu wrote:
>> If pass-through a VF by vfio-pci to a Qemu VM, after FLR
>> in VM, the interrupt setting is not recoverd correctly
>> to host as below:
>> in VM guest:
>> Capabilities: [70] MSI-X: Enable+ Count=5 Masked-
>> in Host:
>> Capabilities: [70] MSI-X: Enable+ Count=5 Masked-
>>
>> That was because in pci_reset_function, it first reads the
>> PCI configure and set FLR reset, and then writes PCI configure
>> as restoration. But not all the writing are successful to Host.
>> Becuase vfio-pci driver doesn't allow directly write PCI MSI-X
>> Cap.
>>
>> To fix this issue, we need to move the interrupt enablement from
>> igb_uio probe to open device file. While is also the similar as
>> the behaviour in vfio_pci kernel module code.>>
>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series applied to dpdk/master, thanks.