From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Peng, Yuan" <yuan.peng@intel.com>,
"Lu, Nannan" <nannan.lu@intel.com>, "Fu, Qi" <qi.fu@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2 06/13] net/ice: add action number check for swicth
Date: Thu, 2 Apr 2020 08:31:00 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA08035D14@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611547F1D03@SHSMSX103.ccr.corp.intel.com>
Ok
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Thursday, April 2, 2020 4:30 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; Lu, Nannan <nannan.lu@intel.com>;
> Fu, Qi <qi.fu@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> stable@dpdk.org
> Subject: RE: [PATCH v2 06/13] net/ice: add action number check for swicth
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei <wei.zhao1@intel.com>
> > Sent: Thursday, April 2, 2020 2:46 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Peng, Yuan
> > <yuan.peng@intel.com>; Lu, Nannan <nannan.lu@intel.com>; Fu, Qi
> > <qi.fu@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> > stable@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH v2 06/13] net/ice: add action number check for swicth
> >
> > The action number can only be one for DCF or PF switch filter, not
> > support large action.
>
> There is no "large action" in rte_flow, maybe just "not support multiple
> actions"?
>
> >
> > Cc: stable@dpdk.org
> > Fixes: 47d460d63233 ("net/ice: rework switch filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/ice/ice_switch_filter.c | 48
> > +++++++++++++++++++++++++++++
> > 1 file changed, 48 insertions(+)
> >
> > diff --git a/drivers/net/ice/ice_switch_filter.c
> > b/drivers/net/ice/ice_switch_filter.c
> > index d9bdf9637..cc48f22dd 100644
> > --- a/drivers/net/ice/ice_switch_filter.c
> > +++ b/drivers/net/ice/ice_switch_filter.c
> > @@ -1073,6 +1073,46 @@ ice_switch_parse_action(struct ice_pf *pf,
> > return -rte_errno;
> > }
> >
> > +static int
> > +ice_switch_check_action(const struct rte_flow_action *actions,
> > + struct rte_flow_error *error)
> > +{
> > + const struct rte_flow_action *action;
> > + enum rte_flow_action_type action_type;
> > + uint16_t actions_num = 0;
> > +
> > + for (action = actions; action->type !=
> > + RTE_FLOW_ACTION_TYPE_END; action++) {
> > + action_type = action->type;
> > + switch (action_type) {
> > + case RTE_FLOW_ACTION_TYPE_VF:
> > + case RTE_FLOW_ACTION_TYPE_RSS:
> > + case RTE_FLOW_ACTION_TYPE_QUEUE:
> > + case RTE_FLOW_ACTION_TYPE_DROP:
> > + actions_num++;
> > + break;
> > + case RTE_FLOW_ACTION_TYPE_VOID:
> > + continue;
> > + default:
> > + rte_flow_error_set(error,
> > + EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
> > + actions,
> > + "Invalid action type");
> > + return -rte_errno;
> > + }
> > + }
> > +
> > + if (actions_num > 1) {
> > + rte_flow_error_set(error,
> > + EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
> > + actions,
> > + "Invalid action number");
> > + return -rte_errno;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > static int
> > ice_switch_parse_pattern_action(struct ice_adapter *ad,
> > struct ice_pattern_match_item *array, @@ -1158,6 +1198,14 @@
> > ice_switch_parse_pattern_action(struct ice_adapter *ad,
> > goto error;
> > }
> >
> > + ret = ice_switch_check_action(actions, error);
> > + if (ret) {
> > + rte_flow_error_set(error, EINVAL,
> > + RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
> > + "Invalid input action number");
> > + goto error;
> > + }
> > +
> > if (ad->hw.dcf_enabled)
> > ret = ice_switch_parse_dcf_action(actions, error, &rule_info);
> > else
> > --
> > 2.19.1
next prev parent reply other threads:[~2020-04-02 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200313020806.21654-1-wei.zhao1@intel.com>
2020-03-13 2:08 ` [dpdk-stable] [PATCH 5/7] net/ice: change default tunnle type Wei Zhao
2020-03-13 2:08 ` [dpdk-stable] [PATCH 6/7] net/ice: add action number check for swicth Wei Zhao
2020-03-13 2:08 ` [dpdk-stable] [PATCH 7/7] net/ice: fix input set of VLAN item Wei Zhao
[not found] ` <20200402064620.47668-1-wei.zhao1@intel.com>
2020-04-02 6:46 ` [dpdk-stable] [PATCH v2 05/13] net/ice: change default tunnle type Wei Zhao
2020-04-02 6:46 ` [dpdk-stable] [PATCH v2 06/13] net/ice: add action number check for swicth Wei Zhao
2020-04-02 8:29 ` Zhang, Qi Z
2020-04-02 8:31 ` Zhao1, Wei [this message]
2020-04-03 1:49 ` Lu, Nannan
2020-04-02 6:46 ` [dpdk-stable] [PATCH v2 11/13] net/ice: fix input set of VLAN item Wei Zhao
[not found] ` <20200403024353.24681-1-wei.zhao1@intel.com>
2020-04-03 2:43 ` [dpdk-stable] [PATCH v3 05/13] net/ice: change default tunnle type Wei Zhao
2020-04-03 2:43 ` [dpdk-stable] [PATCH v3 06/13] net/ice: add action number check for swicth Wei Zhao
2020-04-03 3:15 ` Zhang, Qi Z
2020-04-03 2:43 ` [dpdk-stable] [PATCH v3 11/13] net/ice: fix input set of VLAN item Wei Zhao
[not found] ` <20200403044609.27512-1-wei.zhao1@intel.com>
2020-04-03 4:46 ` [dpdk-stable] [PATCH v4 05/13] net/ice: change default tunnle type Wei Zhao
2020-04-03 4:46 ` [dpdk-stable] [PATCH v4 06/13] net/ice: add action number check for swicth Wei Zhao
2020-04-03 4:46 ` [dpdk-stable] [PATCH v4 11/13] net/ice: fix input set of VLAN item Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA08035D14@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=nannan.lu@intel.com \
--cc=qi.fu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).