From: "Boyer, Andrew" <Andrew.Boyer@amd.com>
To: "stable@dpdk.org" <stable@dpdk.org>
Subject: Please ignore Re: [PATCH 07/12] net/ionic: fix RSS query routine
Date: Mon, 22 Jan 2024 15:44:40 +0000 [thread overview]
Message-ID: <A6009829-E4DA-493D-8DA6-9E63337AFDF0@amd.com> (raw)
In-Reply-To: <20240119204150.723-8-andrew.boyer@amd.com>
Please ignore. This was not ready for submission to the list.
My apologies,
Andrew
> On Jan 19, 2024, at 3:41 PM, Boyer, Andrew <Andrew.Boyer@amd.com> wrote:
>
> From: Akshay Dorwat <akshay.dorwat@amd.com>
>
> It can't use memcpy() because the LIF fields are only 8-bit values.
> Instead, copy the values individually.
>
> Fixes: 22e7171bc63b ("net/ionic: support RSS")
> Cc: cardigliano@ntop.org
> Cc: stable@dpdk.org
>
> Signed-off-by: Akshay Dorwat <akshay.dorwat@amd.com>
> Signed-off-by: Andrew Boyer <andrew.boyer@amd.com>
> ---
> drivers/net/ionic/ionic_ethdev.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c
> index 340fd0cd59..008e50e0b9 100644
> --- a/drivers/net/ionic/ionic_ethdev.c
> +++ b/drivers/net/ionic/ionic_ethdev.c
> @@ -561,7 +561,7 @@ ionic_dev_rss_reta_query(struct rte_eth_dev *eth_dev,
> struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
> struct ionic_adapter *adapter = lif->adapter;
> struct ionic_identity *ident = &adapter->ident;
> - int i, num;
> + int i, j, num;
> uint16_t tbl_sz = rte_le_to_cpu_16(ident->lif.eth.rss_ind_tbl_sz);
>
> IONIC_PRINT_CALL();
> @@ -582,9 +582,10 @@ ionic_dev_rss_reta_query(struct rte_eth_dev *eth_dev,
> num = reta_size / RTE_ETH_RETA_GROUP_SIZE;
>
> for (i = 0; i < num; i++) {
> - memcpy(reta_conf->reta,
> - &lif->rss_ind_tbl[i * RTE_ETH_RETA_GROUP_SIZE],
> - RTE_ETH_RETA_GROUP_SIZE);
> + for (j = 0; j < RTE_ETH_RETA_GROUP_SIZE; j++) {
> + reta_conf->reta[j] =
> + lif->rss_ind_tbl[(i * RTE_ETH_RETA_GROUP_SIZE) + j];
> + }
> reta_conf++;
> }
>
> --
> 2.17.1
>
prev parent reply other threads:[~2024-01-22 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240119204150.723-1-andrew.boyer@amd.com>
2024-01-19 20:41 ` Andrew Boyer
2024-01-22 15:44 ` Boyer, Andrew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A6009829-E4DA-493D-8DA6-9E63337AFDF0@amd.com \
--to=andrew.boyer@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).