From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E5F64399B for ; Mon, 22 Jan 2024 16:44:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 129E1406A2; Mon, 22 Jan 2024 16:44:47 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2074.outbound.protection.outlook.com [40.107.237.74]) by mails.dpdk.org (Postfix) with ESMTP id 69A13402DA for ; Mon, 22 Jan 2024 16:44:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KMZZSu8aN2vRmScI6K+KojcKXWy/Gv0Ov2EI7yC2hWxvzPgNluQOWP3ZK6n8O1b7iER1j0ejRlsY1i14wU0RyXgrIBVkfhoSR+uV+hFRz6PGAdHlsHOWgnDHGg72gay1CnuogWXrQjLMuC7ped8ogn9Kiw1S2OWB6iRHXCDyQ6Ct3nN8m+f3dcWai15LGU2cHzlE6M0UbH07dbc+f0JeaGJOgEydlDBlBNTpm928hxUCyG5f34rEkSsDbvFVixCPO8DVzcQ/yQtUmbZfUs99sKcIUxxPF/IRyDebP7JAYI7mRbCYrbV0i1KcXQE2EF3YzMx3tlcrv9WLlfwKoMXomg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JFMmhv6JahhIUBF0l6TFXXJBwalUQHn2kRQuxgBwO2k=; b=ecfdjeUM7iA472BZybi8XfCypzb7/7h2SCTvQJajO8L/xO93Vjm74RGSXjraGUB2n9PrPEboj8tYqKW6D7lIAS6lrXrJnfte3hLqxhahbkGcLNEj3uGdN/evYrByuieqOpCfgn/CXVU5SQr2woT99EX3Psv54yjWCqgbtQ8fgUuq4EJ63FYrAvPk32FzHfS0+boefKVXFg/uyU8XPA42ohCRmFBt/7aPA2t4Kkv0I8QZEjiCfVR2uL+hXj5Ghg8SU8ufU5rl85dgspBkYjiqDP1md756W8QAk3iG4Ri4g//5k9yd+sNls2NToquLLL4EvGr8ZkNE0bpidqQxWQIQCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JFMmhv6JahhIUBF0l6TFXXJBwalUQHn2kRQuxgBwO2k=; b=eHKLqC6mAFIvjxb3sVEAmxpvI8BNVnHlpE8Bkvx7deK08BeY+Hez1RUyU8U2G+AG4qwilictEEt2UF5Yf3ervMgVRDqrTpZE3Xr8BdN4yNTv53FW9AAY3t1tTHGL/79LGXQKrM9jKNkfn6vCV4YD7Lp1bFE+ogNLTxqMyC12+tg= Received: from MW6PR12MB8999.namprd12.prod.outlook.com (2603:10b6:303:247::8) by IA0PR12MB7625.namprd12.prod.outlook.com (2603:10b6:208:439::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Mon, 22 Jan 2024 15:44:41 +0000 Received: from MW6PR12MB8999.namprd12.prod.outlook.com ([fe80::b2d3:710f:1b2e:81ef]) by MW6PR12MB8999.namprd12.prod.outlook.com ([fe80::b2d3:710f:1b2e:81ef%4]) with mapi id 15.20.7202.031; Mon, 22 Jan 2024 15:44:40 +0000 From: "Boyer, Andrew" To: "stable@dpdk.org" Subject: Please ignore Re: [PATCH 07/12] net/ionic: fix RSS query routine Thread-Topic: Please ignore Re: [PATCH 07/12] net/ionic: fix RSS query routine Thread-Index: AQHaSxgEOzVcFU9bMkmqtb9RwivsurDl/ZYA Date: Mon, 22 Jan 2024 15:44:40 +0000 Message-ID: References: <20240119204150.723-1-andrew.boyer@amd.com> <20240119204150.723-8-andrew.boyer@amd.com> In-Reply-To: <20240119204150.723-8-andrew.boyer@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW6PR12MB8999:EE_|IA0PR12MB7625:EE_ x-ms-office365-filtering-correlation-id: c15bb9f7-a3aa-4340-0fcc-08dc1b610c1e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TXll/OYGdDs7Jh0cV7jpJlyrOXqGXWKFrfoCzafp+m8cxgYpnRozPiDOX7xeEOmZT2bc6g+pzvySijh2Vq9YlrGW8bo4olNnSaCwikH+FXvaxPj1uLmkNuLa9Z+MhZGkXkk6MHgPFnGZKv9TX1kKBd/vnb14avypQKH3bMZd9vMXV3DZB88AnL6441YEMGQ7egnQ4b2YgQKj+PAEJ36JMV2w87ZsUynzYz3KRa/6LeE2FiUgDyW+voGBS3hgGgRkcDRuJV8PyrZLI/lniR08nXVT0/b3T0NVaTa7wq2q/J9cmyQo2AKDeFArfpikhj+J86wWFLnMp6M2ckFDDEo4X3HaLpqcV/czQCkCLVtFW4K7mdgGOqPmIdqGENmR6YvNbQLtjupfypPDc6AdErjlqoEAFHhfVOfKbLASaxNvid7lfmWgNKdKxcDh02FmArmtFBnSUDfUytjrXbAlYjyBbvhNftaS4aa6GP70cd2DV0ZVoo5HPqh2b+YlQ4EASV1owvDiil2jrvvG3ICXvzJuNJSRKjRfkkSn77sDI/SkutUiWw+oqzc2h48ops3+RGPxDkG0bn4EIj/F9ix8xNzljYoju2KuloKtC7wCT1//NqepuoMcnCjQdrB+rbx3nq1MuUW1zsBGCNVEzKapU3IapA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW6PR12MB8999.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(396003)(376002)(136003)(366004)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(38070700009)(2906002)(66556008)(66946007)(66476007)(76116006)(91956017)(26005)(6916009)(71200400001)(6506007)(8676002)(316002)(64756008)(6486002)(8936002)(6512007)(5660300002)(53546011)(66446008)(2616005)(122000001)(478600001)(38100700002)(83380400001)(33656002)(86362001)(41300700001)(36756003)(45980500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3/tvhD96eHhpkPPt4BxHghdP3OPZlJYHkwQDosX3LipdkenK6vA8bAxg2p9i?= =?us-ascii?Q?iLSHVlr4Y58iDkQTeks7nn9fN5H2iTq5DPnb0CNNVDV4ajIbUMMkt6obMJ47?= =?us-ascii?Q?FUPrjv/dwx1vXENFBmRByZ+e/NBj//US8QsJCJ5GjPFy4y92Up8wCZQUkTb5?= =?us-ascii?Q?2r3hPwkiaqjf1kRBsk0U6earkjNwlfz8Ngp68DSdw+zT7/dnjCdJOfuSLaDe?= =?us-ascii?Q?sqDRoLAMgoGnH3siCnBeaMnczWW+MMJaZiwvxzZ9UeTJtop8fRF8zEewWbmZ?= =?us-ascii?Q?xtoQX+FkQT7pUGgVcnh8bDl74M5HBKpjLyidqyqfzjErnSxS8ugGaP6JU33W?= =?us-ascii?Q?2RbRlqmSxhHmpKWwlavWMASauBvVHNR8cf2lKCIIfaUrM654K8CDG8W6LBq2?= =?us-ascii?Q?E5Qtp9YTnf28DwfTP0qytBI2uv3Dkp2l25JTQ+uA76cN2ubXl8Y32erVq8VM?= =?us-ascii?Q?Gdz5VAV/apb461GbnNXiLE4xiytnxNz8FOzwIiMZyDJ/uvg9AujRyoCD6gwn?= =?us-ascii?Q?6n41/T4YcIJhlXiPnl47xiqQ/ETWedYg6zpe3FkKidSU3OdSfsYYYjxgVxaF?= =?us-ascii?Q?10dUq+L5LojsdeUSola0zWtS4dZEeRXjjag25xhSlN1w1vfbwKmcs8R+cEvM?= =?us-ascii?Q?NGwSd4ueQZMSYJ2CPsdsVRICokzNzH7J11ULfW4Tsy5kFnAPM+qMY2L9ZqzB?= =?us-ascii?Q?3ZGVykoShvFMe+6cu9K0QJYa18ZH6dsVFRCzNVonIC7/vPMrJBc+3JZkXkBU?= =?us-ascii?Q?twGgc5jvgknv58CcWQp8nBfbU6e1QUk96+ka9p6JkGteBbEUDhATEDeUib1V?= =?us-ascii?Q?auXPYa4qc/ZodT3COYmoSHoxNI+vI+RKI9IAFn9DZpszfqnsysP3RzrB/ihY?= =?us-ascii?Q?C3aBGhx8S21sF8CZosQ48WR0T8XNeHZvfV18zl8PtfW15FgxuHMj2nuo3Wq/?= =?us-ascii?Q?tv/c+zDC/x9VpLqAAUzHiVE6njdVLIVoBvJ3vauPpLsX4aIYcvct8wzumEsa?= =?us-ascii?Q?1ms07c37hWTNsT68I3CHwxI6GHtlLFBcHuoApl4prge9COeIgdvawpSGYuei?= =?us-ascii?Q?BNUeahgGFCz0qC7MTHFwwW+o6TnFOoWQylkY9FSYetvKukMxkQSUWM2W6IQV?= =?us-ascii?Q?uktzxfjOWsmCQBDm9eqrWz+Z9J5fjugf3iX1REJf2QSLVT119IODYB/7HY/F?= =?us-ascii?Q?4AcL+4ka4QLYF95YSuPQoPQ0lvUcKMLPUqVN68+l+fhc5Er+NsDOcR6zfkax?= =?us-ascii?Q?eSYlt8d5C3MlmR2qOylmrlBZeGrYwBQjG1K5czjN7jXss8X+wTUF/ZQIxoww?= =?us-ascii?Q?sTpbw9r+RmgIQyLvMr2vVIFV5h5+pbsaDigMGAXZRWlnR9B3+ISf+6WpKcVS?= =?us-ascii?Q?keHFLmZ6mJhcKFlwmAM19OE0kq6Qx1zNq4ek6su21bp3RtFIJceFMMhZZKeq?= =?us-ascii?Q?Al1FU5pUD7mLFB8GI03EJHJgOAhxUmYvjEQJqTlodwRXFzq5p+ySMDReLjtT?= =?us-ascii?Q?06XsX+0LjDmjViTvTYggM3XkxaeFUTMl0FSzLov/0v/goRMdgcnO9N920SHP?= =?us-ascii?Q?Ul/9ZNNbWwtjUs4hv6x1Ml7OdrLiE6Qkb4h+IjA2?= Content-Type: text/plain; charset="us-ascii" Content-ID: <2E3851628D1A1F4DAD45A107A3B2054B@namprd12.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW6PR12MB8999.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c15bb9f7-a3aa-4340-0fcc-08dc1b610c1e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2024 15:44:40.8604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NbfkgHaDF3ysn4ZJOyAVYyaUKIIM+OO9+KR7Q8PjHhmBonJXNXZoc0Gj8nIBitFi X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7625 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Please ignore. This was not ready for submission to the list. My apologies, Andrew > On Jan 19, 2024, at 3:41 PM, Boyer, Andrew wrote: >=20 > From: Akshay Dorwat >=20 > It can't use memcpy() because the LIF fields are only 8-bit values. > Instead, copy the values individually. >=20 > Fixes: 22e7171bc63b ("net/ionic: support RSS") > Cc: cardigliano@ntop.org > Cc: stable@dpdk.org >=20 > Signed-off-by: Akshay Dorwat > Signed-off-by: Andrew Boyer > --- > drivers/net/ionic/ionic_ethdev.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_e= thdev.c > index 340fd0cd59..008e50e0b9 100644 > --- a/drivers/net/ionic/ionic_ethdev.c > +++ b/drivers/net/ionic/ionic_ethdev.c > @@ -561,7 +561,7 @@ ionic_dev_rss_reta_query(struct rte_eth_dev *eth_dev, > struct ionic_lif *lif =3D IONIC_ETH_DEV_TO_LIF(eth_dev); > struct ionic_adapter *adapter =3D lif->adapter; > struct ionic_identity *ident =3D &adapter->ident; > - int i, num; > + int i, j, num; > uint16_t tbl_sz =3D rte_le_to_cpu_16(ident->lif.eth.rss_ind_tbl_sz); >=20 > IONIC_PRINT_CALL(); > @@ -582,9 +582,10 @@ ionic_dev_rss_reta_query(struct rte_eth_dev *eth_dev= , > num =3D reta_size / RTE_ETH_RETA_GROUP_SIZE; >=20 > for (i =3D 0; i < num; i++) { > - memcpy(reta_conf->reta, > - &lif->rss_ind_tbl[i * RTE_ETH_RETA_GROUP_SIZE], > - RTE_ETH_RETA_GROUP_SIZE); > + for (j =3D 0; j < RTE_ETH_RETA_GROUP_SIZE; j++) { > + reta_conf->reta[j] =3D > + lif->rss_ind_tbl[(i * RTE_ETH_RETA_GROUP_SIZE) + j]; > + } > reta_conf++; > } >=20 > --=20 > 2.17.1 >=20