From: Yongseok Koh <yskoh@mellanox.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined
Date: Tue, 4 Sep 2018 18:53:38 +0000 [thread overview]
Message-ID: <A90E4E37-013E-485A-92F9-0C9F05064712@mellanox.com> (raw)
In-Reply-To: <3669CA39-FCDC-4138-8B8F-1BD629A73197@mellanox.com>
> On Sep 4, 2018, at 11:41 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
>>
>> On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>>
>>
>>
>> -----Original Message-----
>> From: Yongseok Koh <yskoh@mellanox.com>
>> Sent: Sunday, September 2, 2018 7:00 PM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Cc: stable@dpdk.org; nd <nd@arm.com>
>> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined
>>
>>> On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>>>
>>> -----Original Message-----
>>> From: Yongseok Koh <yskoh@mellanox.com>
>>> Sent: Sunday, September 2, 2018 2:30 PM
>>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>>> Cc: stable@dpdk.org
>>> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags
>>> when __aarch64__ is defined
>>>
>>>> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>>>>
>>>> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not
>>>> optional for ArmV8. Hence NEON related code can be enabled when
>>>> __aarch64__ is defined.
>>>>
>>>> Bugzilla ID: 82
>>>> Cc: stable@dpdk.org
>>>>
>>>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>>>> Reported-by: Thomas F Herbert <therbert@redhat.com>
>>>> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>>>> Reviewed-by: Phil Yang <phil.yang@arm.com>
>>>> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>>>> Acked-by: Gavin Hu <gavin.hu@arm.com>
>>>> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>>>> ---
>>>> V2:
>>>> * Corrected the order of contribution tags
>>>> * Added Jerin's Ack
>>>
>>> I didn't check out the details yet but a quick question.
>>> Do you want me to include this patch in 17.11.4?
>>>
>>> Yes, please include.
>>
>> I didn't realized that this is fixing the meson build.
>> 17.11 doesn't have that.
>>
>> Thanks,
>> Yongseok
>>
>> It has a fix for the make build as well. Does it mean, it needs to be a different patch?
>
> I could've applied the second hunk but actually it was one minute before the
> release of 17.11.4. I'm sorry that I had to skip this patch for the release.
>
> But, I've applied it (the second hunk only) to the stable/17.11 tree today.
> Please check it out and let me know if there's an issue. This will be included
> in 17.11.5 (ETA is Nov).
>
> FYI, the most favorable way is that you send patches with '[PATCH 17.11]' prefix
> based on the latest stable/17.11 so that it is never forgotten.
One more FYI.
Even though this was sent to stable (without dev@dpdk.org), as you have also sent
a same patch[1] to dev@dpdk.org, this will be queued for next stable releases anyway
once it is merged to dpdk/master.
[1] https://mails.dpdk.org/archives/dev/2018-September/110713.html
Thanks,
Yongseok
>>>> config/arm/meson.build | 3 ++-
>>>> mk/rte.cpuflags.mk | 2 +-
>>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>>> 40dbc87..94cca49 100644
>>>> --- a/config/arm/meson.build
>>>> +++ b/config/arm/meson.build
>>>> @@ -157,7 +157,8 @@ else
>>>> endif
>>>> message(machine_args)
>>>>
>>>> -if cc.get_define('__ARM_NEON', args: machine_args) != ''
>>>> +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
>>>> + cc.get_define('__aarch64__', args: machine_args) != '')
>>>> dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
>>>> compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] endif diff --git
>>>> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841
>>>> 100644
>>>> --- a/mk/rte.cpuflags.mk
>>>> +++ b/mk/rte.cpuflags.mk
>>>> @@ -89,7 +89,7 @@ CPUFLAGS += VSX
>>>> endif
>>>>
>>>> # ARM flags
>>>> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
>>>> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
>>>> CPUFLAGS += NEON
>>>> endif
>>>>
>>>> --
>>>> 2.7.4
next prev parent reply other threads:[~2018-09-04 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 18:32 Honnappa Nagarahalli
2018-09-02 19:30 ` Yongseok Koh
2018-09-02 19:59 ` Honnappa Nagarahalli
2018-09-02 23:59 ` Yongseok Koh
2018-09-03 8:25 ` Honnappa Nagarahalli
2018-09-04 18:41 ` Yongseok Koh
2018-09-04 18:53 ` Yongseok Koh [this message]
2018-09-16 8:15 ` Thomas Monjalon
2018-09-16 14:40 ` Honnappa Nagarahalli
2018-09-16 19:23 ` Luca Boccassi
2018-09-02 18:35 Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A90E4E37-013E-485A-92F9-0C9F05064712@mellanox.com \
--to=yskoh@mellanox.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).