From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00078.outbound.protection.outlook.com [40.107.0.78]) by dpdk.org (Postfix) with ESMTP id 773EF11A4 for ; Tue, 4 Sep 2018 20:53:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=al5vK+Dz6HOb2bW1kvpotgille9raW74aM4G+Ck/0j8=; b=BMTvU+bhzump6dW2esxK1Wg+8oWmQImD9pHNpqWCbgNeWPKAsbsJVuyJL5DoQwVvG25ZnYoC4uy/tTAaPXILlzHLKHWgpLPiN9CVwOQyRPUwgq8Ba3m8pOVKJqTzbZoNmlC8ekETV7WTo25IQrfyqHPaUwwwN4Anj0SB59dzkjQ= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4090.eurprd05.prod.outlook.com (52.134.72.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Tue, 4 Sep 2018 18:53:38 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1101.016; Tue, 4 Sep 2018 18:53:38 +0000 From: Yongseok Koh To: Honnappa Nagarahalli CC: "stable@dpdk.org" , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined Thread-Index: AQHURICXbHNLRMM22UmbjAu4L7ZIzQ== Date: Tue, 4 Sep 2018 18:53:38 +0000 Message-ID: References: <1535913120-22426-1-git-send-email-honnappa.nagarahalli@arm.com> <8BD04EEF-AF53-4990-9273-A0F737EF8F4D@mellanox.com> <3669CA39-FCDC-4138-8B8F-1BD629A73197@mellanox.com> In-Reply-To: <3669CA39-FCDC-4138-8B8F-1BD629A73197@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4090; 6:Bd4QcaZYmxyPpTbaTj7SVNcrEiz/8UIeyB40mo9gBfW+/x0wV7M6DBlmUdEIdElNOQcto2e2ZX3vfsR0731DBwlddC593kHZnYiYeVg3zTIji6c09FvAU/mT0KsIuJ/MSmhaQHAOvExbhw3Lo5M/dBQpWep5gkzB8H5L7yiUt5+l/V5xYLNo3cMApP04LKJpF4k66dpTYvP6+FYTV9FuMYtknBChnXxNAl9jXm/ja6cdQoQ3nU268AAY3A2J3qG/AY7DsLmxt7QR1CSb5mhxAMZ4b9jsuwFMRDEUYeXz+PZmnPxgir9IgOmvzsS6mItJp56XchG15kX6aWYk4JSh3mt2Uk41dUhK/6VIL17qUWpAQZfZ1gfxE3CD+iK67CX9SUSEQVOKTgT58XjKtJCSK1hHo+pKb/42VpzKA7Ny0j7U6gSiMYPXDURooSEDlzY1CPBY98/SVt3g6iiuoLpdGw==; 5:14Upa2N9/QwCFyFz1Iy9BJQBYyeF0pq2w4u7R2j0YRrzxNqThqU6jZeCCEU9+SlmHgtPHGy5fqGZGQHlVoIcpRnZBaoyz/G9pKIzNlWpuIX/qJ36mbE9eaHqCLv4WwZ6VWnqw6nziRwKVoOvJZrNq2SyrNefbCdK4LjiRycZI94=; 7:DliDad36W4voN6SJJvDFt3VrLMcNt3oeLbF3HqsKNnUT5K9Z3slpWkgmhlaya0QaJWBKVeaoT9xOubTqNNdaTJ8MxIExvD+v71zPHkiGrmvk+fUJXlNqrmsXSu/h29CoyYKHMPE4qlQTVlxidkai8MicsklYm1GpfWULZb5CT9uffvQcyIF5ISSluzqvbD2XMF0gxc/cRgAhxDsxEwVyX4Ifagvg9gclNdMGNpj2NipX/4YxStQhCPZ1s8AoNzYg x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: f02038d5-749f-429f-8d47-08d61297b996 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4090; x-ms-traffictypediagnostic: DB3PR0502MB4090: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699016); SRVR:DB3PR0502MB4090; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4090; x-forefront-prvs: 0785459C39 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(39860400002)(346002)(376002)(189003)(199004)(13464003)(69234005)(186003)(7736002)(81156014)(66066001)(76176011)(6512007)(6306002)(11346002)(2616005)(2900100001)(6436002)(14454004)(26005)(2906002)(256004)(53936002)(6506007)(53546011)(305945005)(6116002)(3846002)(102836004)(86362001)(446003)(14444005)(476003)(105586002)(25786009)(68736007)(229853002)(83716003)(106356001)(33656002)(6246003)(6916009)(97736004)(81166006)(8936002)(36756003)(486006)(4326008)(316002)(54906003)(82746002)(99286004)(966005)(93886005)(5250100002)(5660300001)(6486002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4090; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ix7uj/NkrPASKMvej/+OEEws0KUf0qZWouuLCtcyWNr37B+K9dVUiAaGeG6ALbOni3NnX/qjhMLSjFfuAzcY+4b9c8n659JWxifKFecnnCLkYblfLVlGvdAC0WsDmORYh3Qnai26WL46qYjcl/CMCGRklcsIWsN4XTp4X/Hoa8MWePYnfQjDUmT7uaocfiRKWea3bdJLrA2o3D+AsR0Djrc0ycy4FU3wqhqj1TFAccUFOlXqsf2gpf8neg1zstNhTGFLGM0GwQMkkgoMGdd62385hqtiMEGnxKHFJIzDfFLB7EtrkcFvA74Wi19b4r6EjrEuwVbGwgObv38kUFRFeM8w8smu7BvbXkN2RhtYr68= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f02038d5-749f-429f-8d47-08d61297b996 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2018 18:53:38.1116 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4090 Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 18:53:39 -0000 > On Sep 4, 2018, at 11:41 AM, Yongseok Koh wrote: >=20 >>=20 >> On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli wrote: >>=20 >>=20 >>=20 >> -----Original Message----- >> From: Yongseok Koh =20 >> Sent: Sunday, September 2, 2018 7:00 PM >> To: Honnappa Nagarahalli >> Cc: stable@dpdk.org; nd >> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when = __aarch64__ is defined >>=20 >>> On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli wrote: >>>=20 >>> -----Original Message----- >>> From: Yongseok Koh >>> Sent: Sunday, September 2, 2018 2:30 PM >>> To: Honnappa Nagarahalli >>> Cc: stable@dpdk.org >>> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags=20 >>> when __aarch64__ is defined >>>=20 >>>> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli wrote: >>>>=20 >>>> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not=20 >>>> optional for ArmV8. Hence NEON related code can be enabled when=20 >>>> __aarch64__ is defined. >>>>=20 >>>> Bugzilla ID: 82 >>>> Cc: stable@dpdk.org >>>>=20 >>>> Reported-by: Raslan Darawsheh >>>> Reported-by: Thomas F Herbert >>>> Signed-off-by: Honnappa Nagarahalli >>>> Reviewed-by: Phil Yang >>>> Reviewed-by: Gavin Hu >>>> Acked-by: Gavin Hu >>>> Acked-by: Jerin Jacob >>>> --- >>>> V2: >>>> * Corrected the order of contribution tags >>>> * Added Jerin's Ack >>>=20 >>> I didn't check out the details yet but a quick question. >>> Do you want me to include this patch in 17.11.4? >>>=20 >>> Yes, please include. >>=20 >> I didn't realized that this is fixing the meson build. >> 17.11 doesn't have that. >>=20 >> Thanks, >> Yongseok >>=20 >> It has a fix for the make build as well. Does it mean, it needs to be a = different patch? >=20 > I could've applied the second hunk but actually it was one minute before = the > release of 17.11.4. I'm sorry that I had to skip this patch for the relea= se. >=20 > But, I've applied it (the second hunk only) to the stable/17.11 tree toda= y. > Please check it out and let me know if there's an issue. This will be in= cluded > in 17.11.5 (ETA is Nov). >=20 > FYI, the most favorable way is that you send patches with '[PATCH 17.11]'= prefix > based on the latest stable/17.11 so that it is never forgotten. One more FYI. Even though this was sent to stable (without dev@dpdk.org), as you have als= o sent a same patch[1] to dev@dpdk.org, this will be queued for next stable releas= es anyway once it is merged to dpdk/master. [1] https://mails.dpdk.org/archives/dev/2018-September/110713.html Thanks, Yongseok >>>> config/arm/meson.build | 3 ++- >>>> mk/rte.cpuflags.mk | 2 +- >>>> 2 files changed, 3 insertions(+), 2 deletions(-) >>>>=20 >>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index >>>> 40dbc87..94cca49 100644 >>>> --- a/config/arm/meson.build >>>> +++ b/config/arm/meson.build >>>> @@ -157,7 +157,8 @@ else >>>> endif >>>> message(machine_args) >>>>=20 >>>> -if cc.get_define('__ARM_NEON', args: machine_args) !=3D '' >>>> +if (cc.get_define('__ARM_NEON', args: machine_args) !=3D '' or >>>> + cc.get_define('__aarch64__', args: machine_args) !=3D '') >>>> dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) >>>> compile_time_cpuflags +=3D ['RTE_CPUFLAG_NEON'] endif diff --git=20 >>>> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841 >>>> 100644 >>>> --- a/mk/rte.cpuflags.mk >>>> +++ b/mk/rte.cpuflags.mk >>>> @@ -89,7 +89,7 @@ CPUFLAGS +=3D VSX >>>> endif >>>>=20 >>>> # ARM flags >>>> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) >>>> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) >>>> CPUFLAGS +=3D NEON >>>> endif >>>>=20 >>>> -- >>>> 2.7.4