From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D499AA0613 for ; Tue, 24 Sep 2019 08:48:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C26AA2B9C; Tue, 24 Sep 2019 08:48:11 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 494EE2B9C; Tue, 24 Sep 2019 08:48:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 23:48:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,543,1559545200"; d="scan'208";a="272536748" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 23 Sep 2019 23:48:04 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 23:48:03 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 23:48:03 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.23]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.89]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 14:47:57 +0800 From: "Zhang, Xiao" To: Joyce Kong , "dev@dpdk.org" CC: "nd@arm.com" , "thomas@monjalon.net" , "jerinj@marvell.com" , "gavin.hu@arm.com" , "honnappa.nagarahalli@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/i40e: fix address of first segment Thread-Index: AQHVcpvPyBg8QdYhSUabKupjj/iJZqc6Ym6A Date: Tue, 24 Sep 2019 06:47:57 +0000 Message-ID: References: <1569304125-5365-1-git-send-email-joyce.kong@arm.com> <1569304125-5365-2-git-send-email-joyce.kong@arm.com> In-Reply-To: <1569304125-5365-2-git-send-email-joyce.kong@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: fix address of first segment X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Joyce Kong [mailto:joyce.kong@arm.com] > Sent: Tuesday, September 24, 2019 1:49 PM > To: dev@dpdk.org > Cc: nd@arm.com; thomas@monjalon.net; jerinj@marvell.com; Zhang, Xiao > ; gavin.hu@arm.com; honnappa.nagarahalli@arm.com; > stable@dpdk.org > Subject: [PATCH 1/2] net/i40e: fix address of first segment >=20 > This patch fixes (dereference after null check) coverity issue. > The address of first segmented packets was not set correctly during > reassembling packets which led to this issue. >=20 > Coverity issue: 343422, 343403 > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector > driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Joyce Kong > --- > drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c > b/drivers/net/i40e/i40e_rxtx_vec_neon.c > index 864eb9a..deb185f 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c > +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c > @@ -474,6 +474,7 @@ i40e_recv_scattered_pkts_vec(void *rx_queue, struct > rte_mbuf **rx_pkts, > i++; > if (i =3D=3D nb_bufs) > return nb_bufs; > + rxq->pkt_first_seg =3D rx_pkts[i]; > } > return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i, > &split_flags[i]); > -- > 2.7.4 Reviewed-by: Xiao Zhang