RE: [EXT] Re: [PATCH 20.11 2/2] dpaa2: fix build with RTE_LIBRTE_IEEE1588

[Vanshika Shukla <vanshika.shukla@nxp.com>]

Hi,
I have reviewed the issue. 4690a6114ff6993afc5c005fc340af0b1e4dbe94 commit (https://github.com/DPDK/dpdk/commit/4690a6114ff6993afc5c005fc340af0b1e4dbe94) which is a new feature that is not required to be backported on the stable branch declares the variable that is causing issue here. I have a patch ready to fix this issue. Please confirm if I can submit the patch on stable@dpdk.org mailing list?

Regards,
Vanshika

-----Original Message-----
From: Luca Boccassi <bluca@debian.org> 
Sent: Thursday, 31 March 2022 5:56 pm
To: dpdk stable <stable@dpdk.org>
Cc: Vanshika Shukla <vanshika.shukla@nxp.com>; Lingli Chen <linglix.chen@intel.com>; Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [EXT] Re: [PATCH 20.11 2/2] dpaa2: fix build with RTE_LIBRTE_IEEE1588

Caution: EXT Email

On Tue, 29 Mar 2022 at 15:11, Luca Boccassi <bluca@debian.org> wrote:
>
> On Tue, 2022-03-29 at 13:09 +0100, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <bluca@debian.org>
> >
> > ../drivers/net/dpaa2/dpaa2_rxtx.c: In function ‘dpaa2_dev_rx’:
> > ../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: error: ‘priv’ undeclared (first use in this function); did you mean ‘ldiv’?
> >     priv->rx_timestamp =
> >     ^~~~
> >     ldiv
> >
> > Bugzilla ID: 982
> >
> > Fixes: 1d10966a22ca ("net/dpaa2: fix timestamping for IEEE1588")
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  drivers/net/dpaa2/dpaa2_rxtx.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c 
> > b/drivers/net/dpaa2/dpaa2_rxtx.c index ecd004f9fa..23e193f86c 100644
> > --- a/drivers/net/dpaa2/dpaa2_rxtx.c
> > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c
> > @@ -772,6 +772,9 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> >       const struct qbman_fd *fd;
> >       struct qbman_pull_desc pulldesc;
> >       struct rte_eth_dev_data *eth_data = dpaa2_q->eth_data;
> > +#if defined(RTE_LIBRTE_IEEE1588)
> > +     struct dpaa2_dev_priv *priv = eth_data->dev_private; #endif
> >
> >
> >       if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
> >               ret = dpaa2_affine_qbman_swp();
>
> FYI Vanshika, Hemant and Lingli

Ping - this is a blocker for the 20.11.5 LTS release, would it be possible to have a quick review from NXP?

Thanks!