From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10133A0522 for ; Wed, 1 Jul 2020 21:33:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDC341C1BC; Wed, 1 Jul 2020 21:33:56 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130080.outbound.protection.outlook.com [40.107.13.80]) by dpdk.org (Postfix) with ESMTP id 6AEDF1BFAD; Wed, 1 Jul 2020 21:33:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rgvxjy+g8SPHeA/6HHBZVOIluY2FQKOxZpSGLDC/R1KuTUo0hsKp8GTmiYjke3ZfPBmNKrmcOmReD2qFLLOruxOOtPXutyA7hX6+kU9i8/BfhyOV5zQ2AuO8Y7JCBX/Uy5djiSyMgoGd/d2gLI466pDjTsQWetdSwWfcWUQRHyyNDBJbWijw7lCntqzTr+Tpw5nGlJ/OT4nPp8znkz7Gp9mb5RYL4MXjB6toA1wjaXdHOMshGRidJkcS2mH1HW0RJL4ConIKOavB5ke2/BdeXsNw8V4DA/IXlMgRdmuwVUa8EiIzHvGMsERsuJzgeiqWOkaU54mvxlnWQdyy8h8TIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2P76L/SrI8MwEOgR/TdZ2gtzgGenZiL046AiEctQxZk=; b=JTUjvGuXVmKSh4445Yojiifj1QnKZAwmcwvuBq8PWMaYH/sKOA0LU5XOr7oeVrEvW8U4NcyX6Hr3b99iNExXYlOdAUh0rtag1n5cZGruB3Fz7QJsgis/q0pz09R6KCRWBJr/gCyu9qjmDWE7d6H+4CZdm4HO47QuXYcDekom1d+uMwQoDM0XzZvzX/boAoG4cyf0dJ0fLUgCuqPNEtk7slRH3/Qht5MDZ5t38FwJRP1gW6PkbYocYxwd+AUc2LW/YXLGux+nyoUVsiR/5YiiJ//6MXPOkVaWvy+1zPiozhQ/Vj8Nn3wg8MZmF2tuK/hpTd0c6ZRChUAPeB09Kep+Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2P76L/SrI8MwEOgR/TdZ2gtzgGenZiL046AiEctQxZk=; b=iWap+wItdt6jA+hpCeBdkfKtygXZJO0ZFMR73LlkJZeF9FZ/UM2He2a/oc1Gdk+VHvHOIaJ+/1QPZYmqiVYj6LMsnY6pGaAcoSJtqViXmd4JI2uxIjwXN0d78YDSovfWDn+BGIisJ2w/veT5SxZyQRN8g5Quzo7HHl45bpK6TD0= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM4PR0501MB2657.eurprd05.prod.outlook.com (2603:10a6:200:65::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.25; Wed, 1 Jul 2020 19:33:53 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998%7]) with mapi id 15.20.3131.028; Wed, 1 Jul 2020 19:33:53 +0000 From: Matan Azrad To: Shy Shyman , "dev@dpdk.org" CC: Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix flow META item validation Thread-Index: AQHWT96N5+DHEjwKk0KaSz7L/f098w== Date: Wed, 1 Jul 2020 19:33:53 +0000 Message-ID: References: <20200628093631.56672-1-shys@mellanox.com>, In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [87.70.223.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d4144c92-b408-4b1e-c425-08d81df5b01a x-ms-traffictypediagnostic: AM4PR0501MB2657: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: koPtAVrmIXDpTDMP+Baz6PbR3K8pHz8KRg+2sYVmmGxCHFrKerBz6xhB9HvWgcfMXH55Gxkr6D9bpbNxofORvC4Mzn1pWCkONicOLrXIdih28uNZEoJz4jt4qKp3pnVjaEAj5ttKA/sWhDpQbZi5xjcgWqeF5FOeCQF3fcrtwwmi901jCi7dbDr+3fGgQIuaMmlRactEyJbznaZvTqK0/FyAyf2fPVwye/tiP9vy3mIb2LNlo7/qeyPQ4sHZmWItLlgDYkeHXnW68yQlR/M5ip6wmx5t45dK/+hFkUEwmc0hu5ZKJ8FdSS/zplDGxgN87nQgkRdO0YhwMBnhfGZlRs0tIm8Yo4Xv76nEjZYgtuRdXONK0RZhd14swrD6ZadFoZiqlUuK6KCE4iRIW3e4YA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(66476007)(498600001)(2906002)(7696005)(71200400001)(76116006)(53546011)(66946007)(6506007)(166002)(8676002)(52536014)(64756008)(66556008)(45080400002)(66446008)(450100002)(83380400001)(186003)(5660300002)(110136005)(54906003)(26005)(86362001)(55016002)(4326008)(33656002)(8936002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: xBcmyD5FcwCPdW4+6s7BLfU1qjrjhgsw5YbIRnjpwRFHJFE79wIrARXj0T5WkVwqqFQSdBfiYQavjE/rvUS7CGd433GNmvDOeAh7GwT9W4Cz52yYvuvvXZGaYKQzKW++fPu7l1EP2gTM4ctDKYRw+PWdR66hjLnKC6gCUDDqNegFg0+Q4tLTqlB8ORJFYnhg1J0dMxw1JEv6rl5mtR23n4BNAZXidbkG0KpmyZGD8GMb07kvfhR4FiKeIEWhcDecCaThziosDe0gcLBuVRNrwWUWLhDspSu4FJLrSz34RoBrscnfqDzyMuUkFknFMK38MSy0lqMAETZi4M/pHQCqego293EPzMdpD3yVh9TTKMSzWmN4eHXiL+cBxv/reVTT87tA9X/DEGT7NAdqF9KXP8bQieYmyP4BXm9qsw9blsVWdrFsp7hJRhNl+vB0NWv5SUdtIAwKmNa2WfxBWCvfUY+/lAS/isxX33EFx4i28f8= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR0502MB4019.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4144c92-b408-4b1e-c425-08d81df5b01a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 19:33:53.0732 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JGTFE0ptWfupC0lOQhf3errZCKExDBoeQD7SJ3xL1OwFaWpcwBL85mTV16hBdHpRjmhsuubeUjFxIWixTT0E4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2657 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix flow META item validation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Done Get Outlook for Android ________________________________ From: Asaf Penso Sent: Wednesday, July 1, 2020 2:19:10 PM To: Matan Azrad Cc: Shy Shyman ; Raslan Darawsheh Subject: FW: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation Matan, can you please ACK in ML as well? Shy didn't add your ACK from the GitHub. Regards, Asaf Penso > -----Original Message----- > From: dev On Behalf Of Shy Shyman > Sent: Sunday, June 28, 2020 12:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation > > When flow is inserted with meta match item it requires a certain > register support. > As part of the flow validation of such flows, the validation > function is missing a check that the mlx5 driver is not in > legacy mode in terms of extended meta data support > (MLX5_XMETA_MODE_LEGACY flag). > If the driver is in legacy mode it will cause downstream > function that allocates needed register for meta data. > > The fix checks explicitly the conditions for support of > meta data in FDB mode. if the conditions are not met > an error message will be issued. > > Fixes: 9bf26e1318 ("ethdev: move egress metadata to dynamic field") > Cc: viacheslavo@mellanox.com > Cc: stable@dpdk.org > > Signed-off-by: Shy Shyman > --- > drivers/net/mlx5/mlx5_flow_dv.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 6318bd99cd..e037643c98 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1479,6 +1479,13 @@ flow_dv_validate_item_meta(struct rte_eth_dev > *dev __rte_unused, > "isn't supported"); > if (reg !=3D REG_A) > nic_mask.data =3D priv->sh->dv_meta_mask; > + } else if (attr->transfer) { > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ITEM, item, > + "extended metadata feature " > + "should be enabled when " > + "meta item is requested " > + "with e-switch mode "); > } > if (!mask) > mask =3D &rte_flow_item_meta_mask; > -- > 2.21.0