patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/mlx5: prohibit wildcard match for GRE protocol
@ 2018-08-02 20:54 Yongseok Koh
  2018-08-05  6:24 ` [dpdk-stable] [dpdk-dev] " Matan Azrad
  0 siblings, 1 reply; 4+ messages in thread
From: Yongseok Koh @ 2018-08-02 20:54 UTC (permalink / raw)
  To: shahafs; +Cc: dev, Yongseok Koh, stable

Currently, driver sets full mask (0xffff) for GRE protocol to device. Until
it is changed, PMD can't support wildcard match.

Fixes: f4b901a46aec ("net/mlx5: add flow GRE item")
Cc: stable@dpdk.org

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index b7500ec9d6..83ac6cbb85 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1690,8 +1690,12 @@ mlx5_flow_item_gre(const struct rte_flow_item *item,
 					  RTE_FLOW_ERROR_TYPE_ITEM,
 					  item,
 					  "L3 Layer is missing");
-	if (!mask)
-		mask = &rte_flow_item_gre_mask;
+	if (!mask || mask->protocol != 0xffff)
+		return rte_flow_error_set(error, ENOTSUP,
+					  RTE_FLOW_ERROR_TYPE_ITEM,
+					  item,
+					  "wildcard match is not supported"
+					  " for protocol field of GRE");
 	ret = mlx5_flow_item_acceptable
 		(item, (const uint8_t *)mask,
 		 (const uint8_t *)&rte_flow_item_gre_mask,
-- 
2.11.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-06 20:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02 20:54 [dpdk-stable] [PATCH] net/mlx5: prohibit wildcard match for GRE protocol Yongseok Koh
2018-08-05  6:24 ` [dpdk-stable] [dpdk-dev] " Matan Azrad
2018-08-05  7:01   ` Matan Azrad
2018-08-06 20:01     ` Yongseok Koh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).