From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF0F4A0531 for ; Sun, 26 Jan 2020 17:53:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93B6F4C8B; Sun, 26 Jan 2020 17:53:07 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com [40.107.22.77]) by dpdk.org (Postfix) with ESMTP id 9FEB7493D; Sun, 26 Jan 2020 17:53:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFimgYtjchxUx4DEM9jy9JKHCfOwKhEaJ6MF4NC6bml7oFoyC9aZy024s6B5Gx7zHbC73+tVmpXFJyXf/RCV48+d3XYmKuQfZh5K2AwqoMtQ1Xmn7nPmPwKZ1kvZeelz5DFC8XT6jKNOCDrNOUp1M30bAkihKA6VToAtFcniJbirw4dj4ot4amy+8T6b0IUhuUj6aYZjCVdgyuLTATtQEaJdTPTFfWvzjcd7q5A2I6ceCdqmetKWV4zvgZATJbAT4HO8wJMSss0t8JruaD+8E9TMdVSFM4Y7/zfzdzf6+PPdqgHbRytvpz/WM6ridpcDUMKU8iQ6BBP2rd3RPA3vfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6sMY/vgm6QTPXvpeu5oiGSftTX7BBDdH7Cjb+DhvF0=; b=VZnCsi9vG6dt2HPP5rzjcAdJFsPPfLXqdTqa0AVreixigvVOc87+Sruyh8s9UDUTJov6K3OLAhErnZHhkgTetGJeIgnTBzTdJMtXxSmJ50LQnQJjTDGjS/m07Qynlnp0zrQfZmzoZzbjDjhf6zP5oFAA4pAw5TCngEAmhv2v9Wm/lJvJX9qGAkT82youlUl3fGz0bqyu+JWH4wj93nx363DbAN36YPBpifL4DScH+JxoIeYT92uNvzhcNM5oGr2Qf4sxCBrEZMEmdLvf5JwObBoqewx086y27Wlk4gej4/ooSMPCKMhVUcUMV+gVWKZqi7Y0FiFW0SKUboIYWSn5Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6sMY/vgm6QTPXvpeu5oiGSftTX7BBDdH7Cjb+DhvF0=; b=Z8ZJre2FPuCnkWAh46xWaR4istD/MbTH3JtW84jTvbPTVGFFvOd+A7NEvXaLo7xioM2yJVqtEeE1dEuPysH60pW12D0WA3C42rb2IgpSdHA+OY92Xqp+kqlCXq0Ynv1zGr/7zyxi6kuoALIRyC4rjLVcgojdpHi8XxBQquzrI2w= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB6099.eurprd05.prod.outlook.com (20.178.118.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.22; Sun, 26 Jan 2020 16:53:02 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761%5]) with mapi id 15.20.2665.017; Sun, 26 Jan 2020 16:53:02 +0000 From: Raslan Darawsheh To: Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , Slava Ovsiienko , Dekel Peled , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix icmpv6 header rewrite actions Thread-Index: AQHV0TGIWrAQpJO8DUa52Jk7+RCuL6f9L7LA Date: Sun, 26 Jan 2020 16:53:02 +0000 Message-ID: References: <20200122142527.257004-1-shirik@mellanox.com> In-Reply-To: <20200122142527.257004-1-shirik@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ff89f39c-a63d-4d72-9fd0-08d7a28034ca x-ms-traffictypediagnostic: AM0PR05MB6099:|AM0PR05MB6099: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 02945962BD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(396003)(136003)(39860400002)(346002)(189003)(199004)(26005)(52536014)(186003)(66476007)(6506007)(86362001)(53546011)(33656002)(76116006)(66446008)(7696005)(2906002)(66946007)(478600001)(64756008)(66556008)(71200400001)(81156014)(4326008)(450100002)(110136005)(54906003)(8676002)(81166006)(316002)(5660300002)(8936002)(9686003)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB6099; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i4hyH4GaK/mdz+iz7AO43aopaGqCHX8vptrT1v2jPJANC9OHLen6vRfkwCSQcEN+nHqpwGwO30QFXVOkG3jab5dX9v+AeQhIZXhtqOCKePsciW1BMQrgaJZdETSvWILI75eeAYbiKF03pcB8nX3ZKN+ITWcOC27XxrJucxZFRihLbYROWTfeNY09Qjzq5vfEIzuBQl3JgT7ZoXSiKnG22XLiPrMAWQRx6DkL9B9ocEYcCB/8YsSWeLcoQZIwOSt0PkD5amvOceki/bj5io6JsT5WuC9p2Qi0atI2Y8TzboVi13sEqWYIlkNGAOIvrioHalo4/e9aFBp61SH9pyNUaU/Tt/qDAL0yNskQ+8S3HpfeQUpUE2kV50R6HBSg19Qf9zw4ZgZscxIQPkKT/xsv6AAvs2/H7Ud8aoWv28UQKSpA86ssQ3GPDd8/1KULNjF4 x-ms-exchange-antispam-messagedata: eB7Xp+ySOpxVhSGylfiviG16zgcJxCVUmze/KH0g4Leq0DIZCBlKQn0C0Skj4j0QXX5nRcbmEujUOdbA0m836a7XoH3//I0L4CR8TWEqw0mEZEX9atmqgwgwqkgW4zjtpybXI+sNFpPmGJH1xQPSiA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff89f39c-a63d-4d72-9fd0-08d7a28034ca X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2020 16:53:02.0397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s5oauedMiZ7R/P56S+DozRZ7TTPv7ZyCdF4AykfW5cL3VmY92RlSBZtk2zkR9bBzF26aprNxJONEsg1/nIBlTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6099 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix icmpv6 header rewrite actions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Shiri Kuzin > Sent: Wednesday, January 22, 2020 4:38 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Slava Ovsiienko > ; Dekel Peled ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix icmpv6 header rewrite actions >=20 > the ConnectX-5 HW cannot calculate the checksum for ICMPv6, therefore > flows with pattern 'ipv6 proto is 58' with actions that change the header > should be rejected. the actions that change the header in this type of fl= ow > are 'set_ipv6_src' and 'set_ipv6_dst'. >=20 > Fixes: 4bb14c83df95 ("net/mlx5: support modify header using Direct Verbs"= ) > Cc: dekelp@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Shiri Kuzin > Acked-by: Viacheslav Ovsiienko >=20 > --- > drivers/net/mlx5/mlx5_flow_dv.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 26dbaaf329..2475ff336e 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4447,6 +4447,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const > struct rte_flow_attr *attr, > uint8_t next_protocol =3D 0xff; > uint16_t ether_type =3D 0; > int actions_n =3D 0; > + uint8_t item_ipv6_proto =3D 0; > const struct rte_flow_item *gre_item =3D NULL; > struct rte_flow_item_tcp nic_tcp_mask =3D { > .hdr =3D { > @@ -4554,6 +4555,9 @@ flow_dv_validate(struct rte_eth_dev *dev, const > struct rte_flow_attr *attr, > if (items->mask !=3D NULL && > ((const struct rte_flow_item_ipv6 *) > items->mask)->hdr.proto) { > + item_ipv6_proto =3D > + ((const struct rte_flow_item_ipv6 *) > + items->spec)->hdr.proto; > next_protocol =3D > ((const struct rte_flow_item_ipv6 *) > items->spec)->hdr.proto; > @@ -4926,6 +4930,12 @@ flow_dv_validate(struct rte_eth_dev *dev, const > struct rte_flow_attr *attr, > error); > if (ret < 0) > return ret; > + if (item_ipv6_proto =3D=3D IPPROTO_ICMPV6) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ACTION, > + actions, > + "Can't change header " > + "with ICMPv6 proto"); > /* Count all modify-header actions as one action. */ > if (!(action_flags & > MLX5_FLOW_MODIFY_HDR_ACTIONS)) > ++actions_n; > -- > 2.18.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh