From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31B28A052B for ; Wed, 29 Jul 2020 17:12:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE4D34C93; Wed, 29 Jul 2020 17:12:33 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30046.outbound.protection.outlook.com [40.107.3.46]) by dpdk.org (Postfix) with ESMTP id C304A255; Wed, 29 Jul 2020 17:12:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9SbHHsSfzc79wVhJdUa0ihhx9Tjdl/WeyxV1RijcUzWBOFbMfFe9sCMZs8xHiKwD6o1QDY9w1cgcfiG3sGrObFgBgilQXP2g8YGc+Tvstg8DPpbJgxrkumBA5JT288/REazRQW4wmZPeqHBtdC1HTv7RsMhGG0XYHT4w2bFyj4Urb+GOcBRVVT/KcSNTf5wSXiq0egfejvL9CEjm4C7Yd+RstOVtNtVRrBzvFKj26+3F3enrKheogHboK5t31kEYqTe/XCJ8yiRG7rrUWjwvh4laylnHAj4yY9HpuHyyQSOmtiuoHEtq0BfxZIQk1xPohc5xJzq/N7i1BELByeVlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElivBy38gTDgyYp6PcvtBfWZXX1oZ2CW0xDy0aU1Rl8=; b=FZonOvr8MyqHs2T9vVWyCwTkG7ooNCFgA4yS42rpVZcWgOaTt0Arf5+89KddkDNKX3P0tGDXsEguo1kn7cP631Qdh7nCuS071UecMWcFHy6/sNowVBHl8vzP52c4Vxd3ukVcJKryrZRAGoyAlh/5uLMiE5fZ0FL+02WLdRP7VjmtppqiGm2X3sCp47Yq9yNh3vLabq1X8z9c1+fRBtDO6+se/Li5R0ZOinQku3mkTF5zlIpIDoBUhhxh/5xLL8LMXzL/WrN7UTIiwfL+cJHYo0KDjMoHrczR1gHpbRnpJ2d7v1eWGK+y7khhEJaFm1OkWcb7P+9X5qvWveA1hHog5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElivBy38gTDgyYp6PcvtBfWZXX1oZ2CW0xDy0aU1Rl8=; b=SSPDMe8GsVhhyXGjcmDu1LgVrp2KvRpwqyXDKuSK48ETJW2LdC/MdVo8xDkTR5yjz2TK83BlnhmYW9JJ9PLNYRiO8tgbN7mVaMZGcD934/s1kvn0D9s2KsQT8FdAhlPnZIikY5MaMFGoJMOeMuMogl4WditVJbC8mVg/NA8yLqE= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5361.eurprd05.prod.outlook.com (2603:10a6:208:f1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Wed, 29 Jul 2020 15:12:29 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3239.017; Wed, 29 Jul 2020 15:12:29 +0000 From: Raslan Darawsheh To: Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] common/mlx5: fix MAC addresses flush Thread-Index: AQHWZbSq8GuxPEYdKEuLoKtZ84XRiakepxTA Date: Wed, 29 Jul 2020 15:12:29 +0000 Message-ID: References: <1596032940-20138-1-git-send-email-shirik@mellanox.com> In-Reply-To: <1596032940-20138-1-git-send-email-shirik@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ea430102-a6aa-4a68-838f-08d833d1cf56 x-ms-traffictypediagnostic: AM0PR05MB5361: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PrOZUWgvBJChqTXDKvZRwlmDblslFlldEP5CB8Ohhi+iC1ZCAqf9+apwQn/xhiElnByhGjEIOotSWYRATby4nwcVUeSr9y9cc9GxL5I9gKyxhkOmCbnPAIgAJS55QQYERC5Mt8A2tA9THVse3LghoznA1k0WMxQ1WLyeQx6Ubjn2AWm1TIE1xZNG66wQKmdV29mC7o/vX0V0b0QxFZUccPNF0ywdnL133uwaEO62I8fpu25clHMTFyb31j6HNzLzgieVRUlzHgn6ORzLoiA+X3MdRuzd1Rg/mFgJQr95T8XUk5FiwdKgZeDDMK7tk8A0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(55016002)(478600001)(9686003)(8936002)(76116006)(66476007)(66556008)(64756008)(83380400001)(86362001)(450100002)(8676002)(5660300002)(33656002)(2906002)(66946007)(316002)(54906003)(4326008)(52536014)(71200400001)(110136005)(66446008)(53546011)(6506007)(26005)(7696005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: cwXbBeoxS64wgSC6d0Sz7caeR3AP8QQvEtMm3TGreIfsoZyS/lL/23xaU6WMddHtcUHZnBJoifof8arsVPoGb/154S+betRDxHda46Uoagu0ASv9Myvyr3fu2J4aU03GOJQCdnaJPHauEzq34ZjxCm4rElHrj461QgFszcz93VRWRZxf+iadfEQ7bnqfKimB9D5zRy/Hl5esNLM/b1pVy/Dlor3TB3hpjCxCcq8CIoYtyDRgdfNVJjLbQ+1sWsoigvTwNDnR6nd2jy4k4FWpRnm/CRNugkbWRTlrDrNrH3tDmyMf5JGssHDKsNmd3UHAhjCXrpMhaT4xwgPSpyHFvqxMQa+J0i9hExcf5EdH6BBanWcke5CSv/WtLl/AFlHOyEzqAwlLp8tn/aP+aseyk/5dmBUKvaIqp8pU4HSngTG32pERUg8LBn+zsVWiusGIu+du3acKBDnsDbrkOKKESeEAVfTPvtExgSfevhSgXyU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea430102-a6aa-4a68-838f-08d833d1cf56 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2020 15:12:29.1554 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z/afvrj5Ay96OZYmVSgBdpSXqrLtwLluMgCl7Mp/KwQu22h1cB8Izq0LiBKdSjr48dBguNFO/ZFa03UcPMfxmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5361 Subject: Re: [dpdk-stable] [PATCH] common/mlx5: fix MAC addresses flush X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Shiri Kuzin > Sent: Wednesday, July 29, 2020 5:29 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [PATCH] common/mlx5: fix MAC addresses flush >=20 > mlx5_nl_mac_addr_flush should flush all allocated MAC > addresses. >=20 > The MAC addresses array size should be of size > MLX5_MAX_MAC_ADDRESSES, but currently we return without > flushing the addresses if size is MLX5_MAX_MAC_ADDRESSES. >=20 > This was fixed by not allowing an array larger than > MLX5_MAX_MAC_ADDRESSES. >=20 > Fixes: e9a8ac59b6e2 ("common/mlx5: fix MAC addresses assert") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shiri Kuzin > Acked-by: Viacheslav Ovsiienko > --- > drivers/common/mlx5/linux/mlx5_nl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_nl.c > b/drivers/common/mlx5/linux/mlx5_nl.c > index 8ab7f6b..0ecd9c7 100644 > --- a/drivers/common/mlx5/linux/mlx5_nl.c > +++ b/drivers/common/mlx5/linux/mlx5_nl.c > @@ -790,7 +790,7 @@ struct mlx5_nl_ifindex_data { > { > int i; >=20 > - if (n <=3D 0 || n >=3D MLX5_MAX_MAC_ADDRESSES) > + if (n <=3D 0 || n > MLX5_MAX_MAC_ADDRESSES) > return; >=20 > for (i =3D n - 1; i >=3D 0; --i) { > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh