From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93904A0531 for ; Sun, 26 Jan 2020 17:04:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58EFC4C7B; Sun, 26 Jan 2020 17:04:02 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30042.outbound.protection.outlook.com [40.107.3.42]) by dpdk.org (Postfix) with ESMTP id 28E1737B1; Sun, 26 Jan 2020 17:04:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxEAKBPRvVlfRARhVsqEyIguCGUusNrilzWz2eOukPXVAUWcZ+4/1wSSRSrIXGZPKLdkwbmq4GfsZc0kKtxLuc+FEw/OmHkmLrwd/6gBFxuDsphIrpqt97naERh08ak1yDSo61YhWg6jFrgTov6rw5VeIp/pFRyICTpD833CUFScksM+zdCxS88tgz8LrMxLvLOIgBJDAuTPbCNcBlkIn1C6BmUL8hk8AtdGwl3560Lom6yAZwNMlO5kYj3ZmCUZIkshpnwqpZf9J0exAjZsvCoZIg0EPzmkuX3BHYSdYykUWpMw8R6TPBILU3SKXowhQQT3JKVpY4wMjW1REDZ8VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOSrii+BzuL10dTRLomlTMqGyq5YU0uen82udxiqwdw=; b=A3ZwFPsln//oppvz7rUaswmOtJ0g6Rj+1/AVQDd1VM8s1QWrUF66V3l7ecJ1Erpy09IT6wtG/Sj7Rl+cJZh6ABYOo564ImdS1J0rQ0zlSxZTSDjmHkSetVfArDBLjvMXy349dgIgEgVHHVhKt/6iiPdA+SnqTBq1ICCQoi2pKRy/t25FBjJrkkv0X0jtfP4z8Kv50a4WP0330oV4q5pQwYk6G67yHD5hHGLn/6/kGT9+nH9wSyy/FcvMmsgevuHKmvp47R56DWNaeAsYN3H/jugxa9aedNcHN0P6WiK7NRwk8feiNqVu8fWnrTwhs5HtBxCXELN4gPXctpkbyLc3Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOSrii+BzuL10dTRLomlTMqGyq5YU0uen82udxiqwdw=; b=W2EPanG4FrqetHS1fZyBEeLG5x5bqqEeLS1apoWHPUiiuuxKfAYsZ3YWHFI0ABh9Nzn65mI466IN/yRK/3HE2LozknQvfQzrubLjpGUEizzOTIi2X8g7Q5megTL5X4m0f5/zHGpQUf+XFAWqdrbG0AwxH816IJOhwTNBQkuot3o= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB4499.eurprd05.prod.outlook.com (52.134.92.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Sun, 26 Jan 2020 16:03:58 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761%5]) with mapi id 15.20.2665.017; Sun, 26 Jan 2020 16:03:58 +0000 From: Raslan Darawsheh To: Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix clang 3.4.2 compilation Thread-Index: AQHV0TF0c6l7eJW4E0C/vyitKty7/af9IfxA Date: Sun, 26 Jan 2020 16:03:58 +0000 Message-ID: References: <1579703770-30091-1-git-send-email-matan@mellanox.com> In-Reply-To: <1579703770-30091-1-git-send-email-matan@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 75eb3e5a-c1c5-4168-82b7-08d7a2795a2f x-ms-traffictypediagnostic: AM0PR05MB4499:|AM0PR05MB4499: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 02945962BD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(199004)(189003)(478600001)(26005)(7696005)(86362001)(2906002)(186003)(33656002)(81166006)(6636002)(55016002)(5660300002)(9686003)(53546011)(54906003)(110136005)(316002)(8676002)(81156014)(6506007)(8936002)(66946007)(71200400001)(66476007)(64756008)(66556008)(66446008)(52536014)(76116006)(4326008)(450100002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4499; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eqJMujmr0uPZuCgvRgUlXZ57Lv2506UkFRaet1TkFes0HK07eclb6OG+48084kj13SAIp3hXGi7P1V9PRRLp+8PDrdy8xjVgLbtc4UMnpa5MbO+eV/li9Dx8PBMktqXGb4rkQ+wXfjf1DBusrf73xeTbvt+DvNR8LHHph3p8kcLZgOnbk+4qIxsaFaXezHkTQsqf05S0n0QJ3naY+g/63SfgPubDceaXdleNaMwahR/SLAC/BsLKgOMtD6Q/FWo4J6QnBVAuzfQB0ITwzUSb4B2E4z+HnMzXYEvKR0uwhhEvgKNQzKQYLTjDyb6/xAr91j9WdCHiVcs1GpSTbQixVozVTJs0vKwbdt6uza5UivLvLx3aUvnMK+cFLiM9YjKkaAasn6Od0rlERauTYnprHNCeT44pKScdlWfQ/rfzQJMhL6DK+t0MZvsgaA/32nLG x-ms-exchange-antispam-messagedata: xO+ffRju4WjOyZsh+siGWML3ZgCIn3Y30k9GbdoILYVDWPbtTID5C3Tcdq0sMAjQo34Fl4orEm5Uug2CYZeEpfNllueGyuCssu7MYxCeZweJVZ9kAPpo8pE3BwC9ilIUoSBwod7lrZjeAa4zsxu0tw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75eb3e5a-c1c5-4168-82b7-08d7a2795a2f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2020 16:03:58.1740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4U1/gje2QrvpDGSBOihRRA2k7PmIskTY2TDlQfSB7u8Oiot0/brd/IeSwgG7a6RjLHuZxNsZZSYbFPsHQb9HSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4499 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix clang 3.4.2 compilation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, January 22, 2020 4:36 PM > To: Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix clang 3.4.2 compilation >=20 > Compilation massage example: > "dpdk/drivers/net/mlx5/mlx5_flow_dv.c:1087:10: error: comparison of > unsigned enum expression < 0 is always false > [-Werror,-Wtautological-compare] > if (reg < 0) > ~~~ ^ ~ > " >=20 > enum modify_reg holds only non-negative integers and in some places in > the code it was used to be compared with negative value, hence > compilation was failed. >=20 > Change all thus places to use integer instead of enum modify_reg. >=20 > Fixes: 3e8edd0ef848 ("net/mlx5: update metadata register ID query") > Fixes: 55deee1715f0 ("net/mlx5: extend flow mark support") > Cc: stable@dpdk.org >=20 > Signed-off-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.c | 2 +- > drivers/net/mlx5/mlx5_flow.h | 2 +- > drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------ > 3 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 970123b..441ca10 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -341,7 +341,7 @@ struct mlx5_flow_tunnel_info { > * The request register on success, a negative errno > * value otherwise and rte_errno is set. > */ > -enum modify_reg > +int > mlx5_flow_get_reg_id(struct rte_eth_dev *dev, > enum mlx5_feature_name feature, > uint32_t id, > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index 9832542..886d770 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -762,7 +762,7 @@ uint64_t mlx5_flow_hashfields_adjust(struct > mlx5_flow *dev_flow, int tunnel, > uint64_t hash_fields); > uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t > priority, > uint32_t subpriority); > -enum modify_reg mlx5_flow_get_reg_id(struct rte_eth_dev *dev, > +int mlx5_flow_get_reg_id(struct rte_eth_dev *dev, > enum mlx5_feature_name feature, > uint32_t id, > struct rte_flow_error *error); > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 5a1b426..0464fa8 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1077,7 +1077,7 @@ struct field_modify_info modify_tcp[] =3D { > {4, 0, 0}, /* dynamic instead of > MLX5_MODI_META_REG_C_1. */ > {0, 0, 0}, > }; > - enum modify_reg reg; > + int reg; >=20 > if (!mask) > return rte_flow_error_set(error, EINVAL, > @@ -1119,7 +1119,7 @@ struct field_modify_info modify_tcp[] =3D { > const struct rte_flow_attr *attr, > struct rte_flow_error *error) > { > - enum modify_reg reg =3D > + int reg =3D > mlx5_flow_get_reg_id(dev, attr->transfer ? > MLX5_METADATA_FDB : > attr->egress ? > @@ -1167,7 +1167,7 @@ struct field_modify_info modify_tcp[] =3D { > struct field_modify_info reg_c_x[] =3D { > [1] =3D {0, 0, 0}, > }; > - enum modify_reg reg =3D flow_dv_get_metadata_reg(dev, attr, > error); > + int reg =3D flow_dv_get_metadata_reg(dev, attr, error); >=20 > if (reg < 0) > return reg; > @@ -1370,7 +1370,7 @@ struct field_modify_info modify_tcp[] =3D { > struct rte_flow_item_meta nic_mask =3D { > .data =3D UINT32_MAX > }; > - enum modify_reg reg; > + int reg; > int ret; >=20 > if (!spec) > @@ -2036,7 +2036,7 @@ struct field_modify_info modify_tcp[] =3D { > { > const struct rte_flow_action_set_meta *conf; > uint32_t nic_mask =3D UINT32_MAX; > - enum modify_reg reg; > + int reg; >=20 > if (!mlx5_flow_ext_mreg_supported(dev)) > return rte_flow_error_set(error, ENOTSUP, > @@ -6124,7 +6124,7 @@ struct field_modify_info modify_tcp[] =3D { > meta_m =3D &rte_flow_item_meta_mask; > meta_v =3D (const void *)item->spec; > if (meta_v) { > - enum modify_reg reg; > + int reg; > uint32_t value =3D meta_v->data; > uint32_t mask =3D meta_m->data; >=20 > -- > 1.8.3.1 Patches applied to next-net-mlx, Kindest regards, Raslan Darawsheh