patches for DPDK stable branches
 help / color / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Suanming Mou <suanmingm@mellanox.com>,
	Slava Ovsiienko <viacheslavo@mellanox.com>,
	Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix interrupt installation timing
Date: Sun, 31 May 2020 14:04:39 +0000
Message-ID: <AM0PR05MB6707893B3AB8C9E05F78F8BAC28D0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1590657729-245207-1-git-send-email-suanmingm@mellanox.com>

Hi,

> -----Original Message-----
> From: Suanming Mou <suanmingm@mellanox.com>
> Sent: Thursday, May 28, 2020 12:22 PM
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix interrupt installation timing
> 
> Currently, the DevX counter query works asynchronously with Devx
> interrupt handler return the query result. When port closes, the
> interrupt handler will be uninstalled and the Devx comp obj will
> also be destroyed. Meanwhile the query is still not cancelled.
> 
> In this case, counter query may use the invalid Devx comp which
> has been destroyed, and query failure with invalid FD will be
> reported.
> 
> Adjust the shared interrupt install and uninstall timing to make
> the counter asynchronous query stop before interrupt uninstall.
> 
> Fixes: f15db67 ("net/mlx5: accelerate DV flow counter query")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> v2: fix by adjusting the interrupt install timing.
> ---
>  drivers/net/mlx5/mlx5.c         | 101 +++++++++++++----
>  drivers/net/mlx5/mlx5.h         |   5 -
>  drivers/net/mlx5/mlx5_ethdev.c  | 243 ----------------------------------------
>  drivers/net/mlx5/mlx5_trigger.c |  17 ++-
>  4 files changed, 97 insertions(+), 269 deletions(-)


Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15  8:56 [dpdk-stable] [PATCH] net/mlx5: fix counter query fail during port closing Suanming Mou
2020-05-28  9:22 ` [dpdk-stable] [PATCH v2] net/mlx5: fix interrupt installation timing Suanming Mou
2020-05-31 14:04   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB6707893B3AB8C9E05F78F8BAC28D0@AM0PR05MB6707.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=suanmingm@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox