From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DD9DA04EF for ; Sun, 31 May 2020 16:04:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 732A31D526; Sun, 31 May 2020 16:04:43 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60080.outbound.protection.outlook.com [40.107.6.80]) by dpdk.org (Postfix) with ESMTP id AE0C51D178; Sun, 31 May 2020 16:04:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fwqy8rbJDwXON4AIXwKZyNzbiIjqfjwFeilgi/1UkCr6FyCEE8mKD2u7pxNKPA7Iqjxf8UnThBrBJTtXnBQVmehnY+96gViNDXqm7umNPd7d6P9fMaS4TlOWNwBHj31M69RXyljd7JjTbLVfeSKf8loxxBZF1MIro4fLT1jMy/2BYXveWXlwhL5wYzgAV0ao/oPF/Yd3n4a6mVbnuFJsszahVoPDQPU5QuNIFZ4Jc86dP59CwpBIBNKEFsBFbrchC8Ui/CeuhhxnIPTHL4pidyKR04Ix2o3ZduyMOaAXR5/STOT7//k9FCH+s9OIdg0tgIPhWXg4exjyUDNC0nnbKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O/r+/FEf+SmO3JLBv5G6njP4Mn8QScKjeEIkftiiOVc=; b=YF1bGYTgg3pLAr0UdWtT+25fL7cIiJAOAVonYUquLp8EKLO/TyonLtgQbiz3X0o6I+1ruDEuOy+bnDxmve1gm0ZZLdI5xegNkOwBAgdhUoZCAvYvAL0W6l/xmZFTC/8oNZMywt5wIygpGpyZY/wrQisU/vHxzLYt0QSae7UVVdY3+XVXC1u2aU20mGssp2JazimVy4OHLT+R408dtskJD/QPhPK93zl1uRk6PWtG+RAHIlwKaVNX0GwtxFiiUIMg7Kvc2HGAA4opMwN7w9L+UCCbJ1IPDXTqh4tzTW2mlNjpbXPUCOs+LsD7Y3kk+C06eYABPH7HIrIekaJdY6HsnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O/r+/FEf+SmO3JLBv5G6njP4Mn8QScKjeEIkftiiOVc=; b=bJTFhx9b7XpNNV7RC0oB2XMwT0iqE1pUoJtx9l9k1Eiiyib0ksrhCH2MsbsG/JgHmZC3pODa4Heu1M7vUI+F0xlmjWCD1KKwrXMWKGPVoGsxOrTorjPeEVHkP1p/Gej7YFfe7TZrYx0EdDdmSpLF0yffgTV+8o3POsxIWFS5/+A= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6145.eurprd05.prod.outlook.com (2603:10a6:208:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Sun, 31 May 2020 14:04:39 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%7]) with mapi id 15.20.3045.024; Sun, 31 May 2020 14:04:39 +0000 From: Raslan Darawsheh To: Suanming Mou , Slava Ovsiienko , Matan Azrad , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix interrupt installation timing Thread-Index: AQHWNNF+S2Q0fOvAJkiqwzbii5B2SKjCPxEw Date: Sun, 31 May 2020 14:04:39 +0000 Message-ID: References: <1589533003-322710-1-git-send-email-suanmingm@mellanox.com> <1590657729-245207-1-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1590657729-245207-1-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b5efa244-aab3-4c42-e6f1-08d8056b8f4e x-ms-traffictypediagnostic: AM0PR05MB6145: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 0420213CCD x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EdYY6J9Ig00//V2xUYJSthKrKIKKhLPtgUXXe+od4kFyeOkImz4fiRjOwu/76wlbj8KC8dDdRJW6WmgaR9NlRgyUeywb1zE8vPomF2DIOHrnosy/oU1Ulhg73dSq3i8a7IP0HkIOBTYF0Nip73MvBDbPNTUtZj3ywxj6kxeJTFkAj96ec+Ptf9LhK5JvO7JyUpUt6FRvRHcUeABMDYECUtkbR8Tiqkq+GIYZF6kieCF8eptrZYyKsQLhlWMlDvWcuybZfwGLXSlhBLLDaO4oP0DddIMuGIV53SwQYMjBcrNXUEJkO1n/JG3fk7Apu+wKZB2nZqVhyy7qhZnSILM8PQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(83380400001)(9686003)(66556008)(76116006)(66946007)(86362001)(66446008)(64756008)(71200400001)(66476007)(55016002)(4326008)(450100002)(26005)(6506007)(53546011)(52536014)(2906002)(186003)(33656002)(316002)(7696005)(110136005)(5660300002)(8936002)(8676002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jPaThdvnzNWt5EZvfmw3WVZTmL5Qcav1G8kCGx7zB+g6mMhRzQx+vIYO5n1eFXOM7xvy2DfBXlyPWsK4zc0F50g5bxSedUKcmPzsdO+RNNByncuAhRH5WBNAPEK91yGaN6dOgX7cY63YU9DeK3OujxdjmNd+tm0b8HGG3U3H/lhvPLRsJLEFZmEAGG+mj3BEdIUvW0j7xGlNxY5aQ+td7k3HIlX7G2eYm/9WUiLMVkq65LfmT481jqq64mj8O2nkcldHiFoJjPTSF3PBi1mkkjJvFEvd9f1T6SRAxYwMtTL3xnW3FCgOFP1/vHoAZLUrE+ohZuGoPjDqfhPjVgxXoVE9X0DbByepdVAHTE6kWbJfS3hQw9qY/MljHSdSX9TCzwbjKjq7irJxbvtVy1P9X2qJ2I+iaDpJnYb+zJMvR4/F2Z/tc9Ic74y7Cojrw6/EX9h7jhufDWkrx+8b4oMbKk1DyhZ+19+WdDWeI48yH1I= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5efa244-aab3-4c42-e6f1-08d8056b8f4e X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2020 14:04:39.6220 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nrFS7FQgIxxgGibLkeoon6OS/icdc8PG7aW6gE3E9w5l1yi68xLI3/aHlVjPL2ajx8smjXWTVsXryaCdq6ZmRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6145 Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix interrupt installation timing X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Thursday, May 28, 2020 12:22 PM > To: Slava Ovsiienko ; Matan Azrad > ; dev@dpdk.org > Cc: Raslan Darawsheh ; stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix interrupt installation timing >=20 > Currently, the DevX counter query works asynchronously with Devx > interrupt handler return the query result. When port closes, the > interrupt handler will be uninstalled and the Devx comp obj will > also be destroyed. Meanwhile the query is still not cancelled. >=20 > In this case, counter query may use the invalid Devx comp which > has been destroyed, and query failure with invalid FD will be > reported. >=20 > Adjust the shared interrupt install and uninstall timing to make > the counter asynchronous query stop before interrupt uninstall. >=20 > Fixes: f15db67 ("net/mlx5: accelerate DV flow counter query") > Cc: stable@dpdk.org >=20 > Signed-off-by: Suanming Mou > Acked-by: Matan Azrad > --- > v2: fix by adjusting the interrupt install timing. > --- > drivers/net/mlx5/mlx5.c | 101 +++++++++++++---- > drivers/net/mlx5/mlx5.h | 5 - > drivers/net/mlx5/mlx5_ethdev.c | 243 ----------------------------------= ------ > drivers/net/mlx5/mlx5_trigger.c | 17 ++- > 4 files changed, 97 insertions(+), 269 deletions(-) Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh